Re: [PATCH v3 20/21] perf annotate-arm64: Support per-cpu variable access tracking

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] Missing explicit inclusion of <string.h> for POSIX string functions.
--

commit 2114d02145b83196afb640a1330f3e5c5b83b2b7
Author: Tengda Wu <wutengda@huaweicloud.com>

    perf annotate-arm64: Support per-cpu variable access tracking
    
    Extend update_insn_state() for arm64 to handle per-cpu variable
    addressing.

[ ... ]

> diff --git a/tools/perf/util/annotate-data.c b/tools/perf/util/annotate-data.c
> index 6fa5cd373a464..b0bf0437168bb 100644
> --- a/tools/perf/util/annotate-data.c
> +++ b/tools/perf/util/annotate-data.c

[Severity: Low]
This is a pre-existing issue, but this file appears to be missing an explicit
inclusion of <string.h> for POSIX string functions.

At the top of the file, <string.h> is not included alongside the other headers:

#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <inttypes.h>
#include <linux/zalloc.h>

However, the code uses strcmp() in data_type_cmp():

static int data_type_cmp(const void *_key, const struct rb_node *node)
{
...
	return strcmp(key->self.type_name, type->self.type_name);
}

Will this cause the build to fail when compiling under musl libc, which does
not implicitly include <string.h> through other system headers?

> @@ -1252,11 +1252,33 @@ static enum type_match_result check_matching_type(struct type_state *state,
>  	}
>  
>  	if (state->regs[reg].kind == TSR_KIND_PERCPU_BASE) {
> -		u64 var_addr = dloc->op->offset;
> +		u64 var_addr;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701035355.752944-1-wutengda@huaweicloud.com?part=20