All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: ziy@nvidia.com
Cc: akpm@linux-foundation.org, vbabka@kernel.org, surenb@google.com,
	mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org,
	david@kernel.org, ljs@kernel.org, baolin.wang@linux.alibaba.com,
	liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com,
	dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
	rppt@kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mm/compaction: stop recording free page order in page->private
Date: Wed,  1 Jul 2026 14:49:37 +0800	[thread overview]
Message-ID: <20260701064937.5131-1-lance.yang@linux.dev> (raw)
In-Reply-To: <20260628-keep-subpage-private-zero-at-free-v1-1-f4ce3930d10f@nvidia.com>


On Sun, Jun 28, 2026 at 10:56:19PM -0400, Zi Yan wrote:
>Commit 733aea0b3a7bb ("mm/compaction: add support for >0 order folio
>memory compaction.") stores isolated free pages in an array indexed by free
>page orders, it is no longer needed to store the order in each page's
>->private field. And there is no code using the stored order. Stop doing
>that.
>
>It also prepares for an upcoming change that ensures subpage->private is
>zero at page free time and the removal of set_page_private(0) from
>prep_compound_tail(). In alloc_contig_frozen_range_noprof(),
>isolate_freepages_range() is used to grab free pages from buddy allocator
>and it leaves the aforementioned page->private set until
>either split_free_frozen_pages() or prep_new_page() is called. That
>triggers the upcoming subpage->private nonzero check along once
>set_page_private(0) is removed from prep_compound_tail(), which is called
>via prep_new_page().
>
>Signed-off-by: Zi Yan <ziy@nvidia.com>
>---

IIUC, after isolation, the order is tracked by the per-order freelist :)
LGTM, feel free to add:

Reviewed-by: Lance Yang <lance.yang@linux.dev>


  parent reply	other threads:[~2026-07-01  6:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  2:56 [PATCH 0/4] Keep subpage private zero at free and folio split time Zi Yan
2026-06-29  2:56 ` [PATCH 1/4] mm/compaction: stop recording free page order in page->private Zi Yan
2026-06-29 14:28   ` Vlastimil Babka (SUSE)
2026-06-29 15:03     ` Zi Yan
2026-06-30  1:32   ` Baolin Wang
2026-06-30  1:37     ` Zi Yan
2026-07-01  8:54       ` David Hildenbrand (Arm)
2026-07-01  6:49   ` Lance Yang [this message]
2026-06-29  2:56 ` [PATCH 2/4] mm/huge_memory: add page->private check back in __split_folio_to_order() Zi Yan
2026-06-29 14:39   ` Vlastimil Babka (SUSE)
2026-06-29 15:05     ` Zi Yan
2026-07-01  8:56     ` David Hildenbrand (Arm)
2026-07-01 11:01       ` Lance Yang
2026-07-01 11:08         ` David Hildenbrand (Arm)
2026-07-01 13:32           ` Zi Yan
2026-06-29  2:56 ` [PATCH 3/4] mm/page_alloc: make sure subpage->private is zero at page free time Zi Yan
2026-06-29 14:53   ` Vlastimil Babka (SUSE)
2026-06-29 15:07     ` Zi Yan
2026-06-29  2:56 ` [PATCH 4/4] mm/page_alloc: remove set_page_private() in prep_compound_tail() Zi Yan
2026-06-29 15:45   ` Vlastimil Babka (SUSE)
2026-06-29 16:50     ` Zi Yan
2026-07-01  8:58   ` David Hildenbrand (Arm)
2026-07-01 12:25     ` Lance Yang
2026-07-01 13:33       ` Zi Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701064937.5131-1-lance.yang@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.