From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Mike Rapoport <rppt@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mm/compaction: stop recording free page order in page->private
Date: Wed, 1 Jul 2026 10:54:23 +0200 [thread overview]
Message-ID: <3fb5ee48-259c-4c25-a749-1e6b2aa10ae2@kernel.org> (raw)
In-Reply-To: <DJLZZTX7E1X9.34WYVOYEX83TK@nvidia.com>
On 6/30/26 03:37, Zi Yan wrote:
> On Mon Jun 29, 2026 at 9:32 PM EDT, Baolin Wang wrote:
>>
>>
>> On 6/29/26 10:56 AM, Zi Yan wrote:
>>> Commit 733aea0b3a7bb ("mm/compaction: add support for >0 order folio
>>> memory compaction.") stores isolated free pages in an array indexed by free
>>> page orders, it is no longer needed to store the order in each page's
>>> ->private field. And there is no code using the stored order. Stop doing
>>> that.
>>>
>>> It also prepares for an upcoming change that ensures subpage->private is
>>
>> I noticed that people tend to avoid using the term "subpage" now, though
>> I understand what you mean by it here. :)
>>
>> [1] https://lore.kernel.org/all/20260623125723.2503832-1-dev.jain@arm.com/
>
> Thanks. I was confused which to use subpage or tail page. Now I know
> tail page is the way to go.
Agreed, and agreed that the large comment is not required here.
Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-07-01 8:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 2:56 [PATCH 0/4] Keep subpage private zero at free and folio split time Zi Yan
2026-06-29 2:56 ` [PATCH 1/4] mm/compaction: stop recording free page order in page->private Zi Yan
2026-06-29 14:28 ` Vlastimil Babka (SUSE)
2026-06-29 15:03 ` Zi Yan
2026-06-30 1:32 ` Baolin Wang
2026-06-30 1:37 ` Zi Yan
2026-07-01 8:54 ` David Hildenbrand (Arm) [this message]
2026-07-01 6:49 ` Lance Yang
2026-06-29 2:56 ` [PATCH 2/4] mm/huge_memory: add page->private check back in __split_folio_to_order() Zi Yan
2026-06-29 14:39 ` Vlastimil Babka (SUSE)
2026-06-29 15:05 ` Zi Yan
2026-07-01 8:56 ` David Hildenbrand (Arm)
2026-07-01 11:01 ` Lance Yang
2026-07-01 11:08 ` David Hildenbrand (Arm)
2026-07-01 13:32 ` Zi Yan
2026-06-29 2:56 ` [PATCH 3/4] mm/page_alloc: make sure subpage->private is zero at page free time Zi Yan
2026-06-29 14:53 ` Vlastimil Babka (SUSE)
2026-06-29 15:07 ` Zi Yan
2026-06-29 2:56 ` [PATCH 4/4] mm/page_alloc: remove set_page_private() in prep_compound_tail() Zi Yan
2026-06-29 15:45 ` Vlastimil Babka (SUSE)
2026-06-29 16:50 ` Zi Yan
2026-07-01 8:58 ` David Hildenbrand (Arm)
2026-07-01 12:25 ` Lance Yang
2026-07-01 13:33 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb5ee48-259c-4c25-a749-1e6b2aa10ae2@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.