Re: [PATCH v8 22/22] TEST(do-not-upstream): fake qemu vendor JSON + mapfile entry for CounterIDMask path

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] This patch contains fake test data and is explicitly marked as 'do-not-upstream'.
- [Medium] The patch adds a mapfile entry for '0x0-0x2a-0x0' which is not documented in the commit message.
--

commit 2c14c47c4b1f0c0aa09f9d1287cb457e27674f5b
Author: Atish Patra <atishp@meta.com>
Subject: TEST(do-not-upstream): fake qemu vendor JSON + mapfile entry for CounterIDMask path

This commit adds fake JSON events and mapfile entries for a QEMU virt
environment to test the CounterIDMask path in jevents.

> diff --git a/tools/perf/pmu-events/arch/riscv/mapfile.csv b/tools/perf/pmu-events/arch/riscv/mapfile.csv
> --- a/tools/perf/pmu-events/arch/riscv/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/riscv/mapfile.csv
> @@ -24,3 +24,5 @@
>  0x602-0x3-0x0,v1,openhwgroup/cva6,core
>  0x67e-0x80000000db0000[89]0-0x[[:xdigit:]]+,v1,starfive/dubhe-80,core
>  0x31e-0x8000000000008a45-0x[[:xdigit:]]+,v1,andes/ax45,core
> +0x0-0x0-0x0,v1,qemu/virt,core
> +0x0-0x2a-0x0,v1,qemu/virt,core

[Severity: Medium]
The commit message explicitly states that it adds a mapfile entry for
0x0-0x0-0x0, but it looks like a second entry for 0x0-0x2a-0x0 was also
included here. Should this additional entry be documented in the commit
message, or was it included by mistake?

> diff --git a/tools/perf/pmu-events/arch/riscv/qemu/virt/events.json b/tools/perf/pmu-events/arch/riscv/qemu/virt/events.json
> new file mode 100644
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/qemu/virt/events.json
> @@ -0,0 +1,26 @@
> +[
> +  {
> +    "EventName": "fake-json-any",

[Severity: Medium]
Since the commit subject explicitly marks this as a test that should not be
upstreamed, and it populates the PMU event list with artificial hardware
events, was this patch included in the series by accident?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-counter_delegation-v8-0-7909f863a645@meta.com?part=22