* [PATCH] drm/syncobj: Use kmalloc_objs for chains
@ 2026-07-01 14:31 Jonathan Cavitt
2026-07-01 14:48 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cavitt @ 2026-07-01 14:31 UTC (permalink / raw)
To: dri-devel
Cc: alex.zuo, jonathan.cavitt, tobias.hector, jason, airlied, chris,
christian.koenig, david1.zhou, lionel.g.landwerlin
Use kmalloc_objs instead of kmalloc_array when initializing chains in
drm_syncobj_timeline_signal_ioctl.
Concern caught by static analysis.
Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: Tobias Hector <Tobias.Hector@amd.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chunming Zhou <david1.zhou@amd.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
drivers/gpu/drm/drm_syncobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index c9dbf64c0c9f..2fa170a29a62 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -1619,7 +1619,7 @@ drm_syncobj_timeline_signal_ioctl(struct drm_device *dev, void *data,
goto err_points;
}
- chains = kmalloc_array(args->count_handles, sizeof(void *), GFP_KERNEL);
+ chains = kmalloc_objs(*chains, args->count_handles, GFP_KERNEL);
if (!chains) {
ret = -ENOMEM;
goto err_points;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/syncobj: Use kmalloc_objs for chains
2026-07-01 14:31 [PATCH] drm/syncobj: Use kmalloc_objs for chains Jonathan Cavitt
@ 2026-07-01 14:48 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2026-07-01 14:48 UTC (permalink / raw)
To: Jonathan Cavitt, dri-devel
Cc: alex.zuo, tobias.hector, jason, airlied, chris, david1.zhou,
lionel.g.landwerlin
On 7/1/26 16:31, Jonathan Cavitt wrote:
> Use kmalloc_objs instead of kmalloc_array when initializing chains in
> drm_syncobj_timeline_signal_ioctl.
>
> Concern caught by static analysis.
>
> Suggested-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Cc: Tobias Hector <Tobias.Hector@amd.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Chunming Zhou <david1.zhou@amd.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/drm_syncobj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index c9dbf64c0c9f..2fa170a29a62 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -1619,7 +1619,7 @@ drm_syncobj_timeline_signal_ioctl(struct drm_device *dev, void *data,
> goto err_points;
> }
>
> - chains = kmalloc_array(args->count_handles, sizeof(void *), GFP_KERNEL);
> + chains = kmalloc_objs(*chains, args->count_handles, GFP_KERNEL);
> if (!chains) {
> ret = -ENOMEM;
> goto err_points;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-01 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01 14:31 [PATCH] drm/syncobj: Use kmalloc_objs for chains Jonathan Cavitt
2026-07-01 14:48 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.