From: Stefan Hajnoczi <stefanha@redhat.com>
To: Zhang Chen <zhangckid@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Dr . David Alan Gilbert" <dave@treblig.org>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Jason Wang <jasowang@redhat.com>,
Fam Zheng <fam@euphon.net>
Subject: Re: [PATCH V9 08/17] monitor: switch to iothread_unsafe_get_aio_context()
Date: Wed, 1 Jul 2026 18:16:42 +0200 [thread overview]
Message-ID: <20260701161642.GB413397@fedora> (raw)
In-Reply-To: <20260624070851.13342-9-zhangckid@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On Wed, Jun 24, 2026 at 03:08:42PM +0800, Zhang Chen wrote:
> Since previous patches introduced explicit monitor tracking and reference
> counting via IOThreadHolder during initialization, standard global calls
> to iothread_get_aio_context() are no longer appropriate for raw context
> fetches.
>
> Switch the remaining fallback sites in monitor_suspend(), monitor_resume(),
> and monitor_init_qmp() to use iothread_unsafe_get_aio_context(). This aligns
> with the new safe ref/unref lifecycles introduced for monitor tracking.
Why is the unsafe API used here? monitor_data_init() now takes a
reference and gets the AioContext. Can you use that AioContext here
instead of fetching it with iothread_unsafe_get_aio_context()?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-02 6:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 7:08 [PATCH V9 00/17] iothread: Support tracking and querying IOThread holders Zhang Chen
2026-06-24 7:08 ` [PATCH V9 01/17] qapi/misc: Fix missed query-iothreads items Zhang Chen
2026-06-24 7:08 ` [PATCH V9 02/17] iothread: introduce iothread_ref/unref to track attached devices Zhang Chen
2026-06-24 15:51 ` Stefan Hajnoczi
2026-06-24 22:47 ` Zhang Chen
2026-06-26 8:46 ` Markus Armbruster
2026-06-29 6:58 ` Zhang Chen
2026-06-29 10:42 ` Markus Armbruster
2026-07-06 9:06 ` Zhang Chen
2026-07-06 10:44 ` Markus Armbruster
2026-06-24 7:08 ` [PATCH V9 03/17] iothread: tracking iothread users with holder name Zhang Chen
2026-06-24 17:10 ` Stefan Hajnoczi
2026-06-24 22:48 ` Zhang Chen
2026-06-24 7:08 ` [PATCH V9 04/17] iothread: introduce iothread_unsafe_get_aio_context() Zhang Chen
2026-06-24 17:19 ` Stefan Hajnoczi
2026-06-24 22:47 ` Zhang Chen
2026-06-24 7:08 ` [PATCH V9 05/17] block/export: track IOThread reference in BlockExport Zhang Chen
2026-06-24 17:51 ` Stefan Hajnoczi
2026-06-24 23:06 ` Zhang Chen
2026-06-25 13:31 ` Stefan Hajnoczi
2026-06-25 15:16 ` Stefan Hajnoczi
2026-06-29 6:01 ` Zhang Chen
2026-07-01 16:10 ` Stefan Hajnoczi
2026-06-24 7:08 ` [PATCH V9 06/17] monitor: refactor monitor_data_init() to pass ID Zhang Chen
2026-06-26 13:04 ` Markus Armbruster
2026-06-26 13:31 ` Daniel P. Berrangé
2026-06-29 8:31 ` Zhang Chen
2026-06-24 7:08 ` [PATCH V9 07/17] monitor: support iothread ref/unref for anonymous monitors Zhang Chen
2026-06-24 7:08 ` [PATCH V9 08/17] monitor: switch to iothread_unsafe_get_aio_context() Zhang Chen
2026-07-01 16:16 ` Stefan Hajnoczi [this message]
2026-07-06 8:59 ` Zhang Chen
2026-06-24 7:08 ` [PATCH V9 09/17] virtio-vq-mapping: track iothread-vq-mapping references using device path Zhang Chen
2026-06-24 7:08 ` [PATCH V9 10/17] virtio: use iothread_get/put_aio_context for thread pinning Zhang Chen
2026-06-24 7:08 ` [PATCH V9 11/17] net/colo: track IOThread references using path-based holder Zhang Chen
2026-06-24 7:08 ` [PATCH V9 12/17] virtio-balloon: Update tracking iothread users with holder Zhang Chen
2026-06-24 7:08 ` [PATCH V9 13/17] vfio-user/proxy: Update tracking iothread users with holder name Zhang Chen
2026-06-24 7:08 ` [PATCH V9 14/17] xen-block: " Zhang Chen
2026-06-24 7:08 ` [PATCH V9 15/17] qapi: examine IOThread attachment status via query-iothreads Zhang Chen
2026-06-24 7:08 ` [PATCH V9 16/17] iothread: simplify API by merging iothread_get_aio_context variants Zhang Chen
2026-06-24 7:08 ` [PATCH V9 17/17] tests/unit/iothread: Update the iothread_get_aio_context Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701161642.GB413397@fedora \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.