* [PATCH RFC net-next] net: hns3: add VF representor for tc flower queue selection
@ 2026-07-01 13:08 Jijie Shao
2026-07-01 16:56 ` kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: Jijie Shao @ 2026-07-01 13:08 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, andrew+netdev, horms
Cc: shenjian15, liuyonglong, chenhao418, yangshuaisong, netdev,
linux-kernel, shaojijie
Background
The hns3 driver supports configuring FD (Flow Director) rules via
ethtool to specify queue mapping or drop actions for traffic received
by the PF. ethtool also supports specifying a vf parameter to
configure the same rules for VF traffic (ethtool -U eth0 flow-type
tcp4 vf 1 queue 3).
The community recommends using tc flower to replace ethtool ntuple/rss
flow configuration. tc flower already supports FD rule configuration
on the PF side, but there is currently no mechanism to configure
equivalent rules for VF traffic through tc flower.
The hns3 FD engine is a TCAM-based match+action engine, not a
switching or forwarding engine. It matches packets by the DST_VPORT
tuple (vport_id) in TCAM key metadata, with actions being queue
selection or packet drop. FD rules are configured by the PF driver
and sent to firmware. Since firmware has visibility into all PF and
VF vport resources, the PF can configure queue selection and drop
rules on behalf of VFs.
Motivation
We would like to add tc flower support for configuring queue selection
and drop rules on VF traffic in the hns3 driver. We investigated
several approaches:
Approach A (REDIRECT + QUEUE_MAPPING dual action):
Configure tc flower on the PF netdev, using FLOW_ACTION_REDIRECT to
specify the VF device and FLOW_ACTION_RX_QUEUE_MAPPING for the queue.
However, REDIRECT semantically means "redirect the packet to another
device" (forwarding), while the hns3 FD engine does not forward
packets -- it only matches packets and selects a queue or drops them.
The semantics do not align.
Approach B (MARK encoding vf_id):
Use FLOW_ACTION_MARK high bits to encode the VF ID and
QUEUE_MAPPING for the queue number. But MARK is designed for packet
marking for downstream processing. Encoding driver-internal
parameters in it is a semantic abuse with no community precedent.
Approach C (VF Representor):
Create a representor net_device for each VF. TC flower rules are
configured on the representor, whose identity implicitly encodes
the VF. This approach has clear semantics -- "configure a rule for
VF1" means operating on VF1's representor -- and has precedent
in other drivers. Considering code complexity, semantic correctness,
and alignment with community conventions, we chose Approach C.
This RFC patch presents our initial implementation to gather feedback
on whether this approach is reasonable and what improvements are needed.
Approach
Introduce VF representor net_devices to provide tc flower capability
equivalent to ethtool "flow-type ... vf N queue M".
The PF creates one representor net_device (e.g. eno2_rep0) per VF at
SRIOV enable time, serving as the tc flower rule configuration handle.
The representor is NOT a switch port and does NOT participate in
datapath forwarding -- its ndo_start_xmit simply drops packets.
When a tc flower rule is configured on the representor, the PF driver
automatically extracts the corresponding VF vport from the
representor's cb_priv (struct hclge_vf_rep) and sets DST_VPORT in
the TCAM key to that VF's vport_id, so the FD engine only matches
packets destined for that VF.
Implementation
- Extract hclge_add_cls_flower_common() from hclge_add_cls_flower(),
accepting a struct hclge_vport pointer to derive vport_id and
num_tqps, shared by both PF and VF representor paths.
- Set rule->vf_id to vport->vport_id (0 for PF, hardware-assigned
vport_id for VF) for TCAM DST_VPORT matching and FD counter
differentiation.
- Queue ID is validated against the VF's actual queue count
(vport->nic.kinfo.num_tqps).
- VF representor does NOT support implicit TC selection via classid
(HCLGE_FD_ACTION_SELECT_TC). Only explicit actions are supported:
- FLOW_ACTION_RX_QUEUE_MAPPING: queue selection
- FLOW_ACTION_DROP: packet drop
- VF representor creation failure does not roll back SRIOV. The VF
datapath works independently and is not affected.
- ndo_get_phys_port_name returns "pfNvfM" for user-space
identification.
This is an RFC patch for early review. It has been through basic
verification but is not intended for formal submission. Further
review and testing are required.
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/Makefile | 2 +-
drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 +
.../net/ethernet/hisilicon/hns3/hns3_enet.c | 16 +-
.../ethernet/hisilicon/hns3/hns3pf/hclge_fd.c | 48 +++++-
.../ethernet/hisilicon/hns3/hns3pf/hclge_fd.h | 7 +
.../hisilicon/hns3/hns3pf/hclge_main.c | 2 +
.../hisilicon/hns3/hns3pf/hclge_main.h | 6 +
.../hisilicon/hns3/hns3pf/hclge_vf_rep.c | 159 ++++++++++++++++++
.../hisilicon/hns3/hns3pf/hclge_vf_rep.h | 21 +++
9 files changed, 251 insertions(+), 12 deletions(-)
create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c
create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.h
diff --git a/drivers/net/ethernet/hisilicon/hns3/Makefile b/drivers/net/ethernet/hisilicon/hns3/Makefile
index 5785d4c5709e..6fd83c959495 100644
--- a/drivers/net/ethernet/hisilicon/hns3/Makefile
+++ b/drivers/net/ethernet/hisilicon/hns3/Makefile
@@ -24,6 +24,6 @@ hclgevf-objs = hns3vf/hclgevf_main.o hns3vf/hclgevf_mbx.o hns3vf/hclgevf_devlin
obj-$(CONFIG_HNS3_HCLGE) += hclge.o hclge-common.o
hclge-objs = hns3pf/hclge_main.o hns3pf/hclge_mdio.o hns3pf/hclge_tm.o hns3pf/hclge_regs.o \
hns3pf/hclge_mbx.o hns3pf/hclge_err.o hns3pf/hclge_debugfs.o hns3pf/hclge_ptp.o hns3pf/hclge_devlink.o \
- hns3pf/hclge_fd.o
+ hns3pf/hclge_fd.o hns3pf/hclge_vf_rep.o
hclge-$(CONFIG_HNS3_DCB) += hns3pf/hclge_dcb.o
diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
index a8798eecd9fb..d2c1c73617a4 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
@@ -796,6 +796,8 @@ struct hnae3_ae_ops {
int (*get_link_diagnosis_info)(struct hnae3_handle *handle,
u32 *status_code);
void (*clean_vf_config)(struct hnae3_ae_dev *ae_dev, int num_vfs);
+ int (*create_vf_reps)(struct hnae3_ae_dev *ae_dev, int num_vfs);
+ void (*destroy_vf_reps)(struct hnae3_ae_dev *ae_dev);
int (*get_dscp_prio)(struct hnae3_handle *handle, u8 dscp,
u8 *tc_map_mode, u8 *priority);
void (*get_wol)(struct hnae3_handle *handle,
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 6ecb32e28e79..f393e9f81fa6 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -3211,6 +3211,7 @@ static void hns3_remove(struct pci_dev *pdev)
**/
static int hns3_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)
{
+ struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
int ret;
if (!(hns3_is_phys_func(pdev) && IS_ENABLED(CONFIG_PCI_IOV))) {
@@ -3220,13 +3221,24 @@ static int hns3_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)
if (num_vfs) {
ret = pci_enable_sriov(pdev, num_vfs);
- if (ret)
+ if (ret) {
dev_err(&pdev->dev, "SRIOV enable failed %d\n", ret);
- else
+ } else {
+ if (ae_dev->ops->create_vf_reps) {
+ ret = ae_dev->ops->create_vf_reps(ae_dev,
+ num_vfs);
+ if (ret)
+ dev_warn(&pdev->dev,
+ "failed to create VF representors: %d\n",
+ ret);
+ }
return num_vfs;
+ }
} else if (!pci_vfs_assigned(pdev)) {
int num_vfs_pre = pci_num_vf(pdev);
+ if (ae_dev->ops->destroy_vf_reps)
+ ae_dev->ops->destroy_vf_reps(ae_dev);
pci_disable_sriov(pdev);
hns3_clean_vf_config(pdev, num_vfs_pre);
} else {
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.c
index 2fccb0a870b5..8cd9a1a8eff1 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.c
@@ -6,6 +6,7 @@
#include <net/vxlan.h>
#include "hclge_fd.h"
#include "hclge_main.h"
+#include "hclge_vf_rep.h"
static const struct key_info meta_data_key_info[] = {
{ PACKET_TYPE_ID, 6 },
@@ -2285,6 +2286,7 @@ static int hclge_get_cls_key_ip_tos(const struct flow_rule *flow,
}
static int hclge_get_tc_flower_action(struct hclge_dev *hdev,
+ struct hclge_vport *vport,
struct flow_cls_offload *cls_flower,
struct hclge_fd_rule *rule)
{
@@ -2292,10 +2294,17 @@ static int hclge_get_tc_flower_action(struct hclge_dev *hdev,
struct netlink_ext_ack *extack = cls_flower->common.extack;
struct hnae3_handle *handle = &hdev->vport[0].nic;
struct flow_action *action = &flow->action;
+ u16 num_tqps = vport->nic.kinfo.num_tqps;
struct flow_action_entry *act;
int tc;
if (!flow_action_has_entries(&flow->action)) {
+ if (vport != &hdev->vport[0]) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "VF does not support select TC action");
+ return -EOPNOTSUPP;
+ }
+
tc = tc_classid_to_hwtc(handle->netdev, cls_flower->classid);
if (tc < 0 || tc > hdev->tc_max) {
NL_SET_ERR_MSG_FMT_MOD(extack,
@@ -2311,11 +2320,10 @@ static int hclge_get_tc_flower_action(struct hclge_dev *hdev,
act = &action->entries[0];
switch (act->id) {
case FLOW_ACTION_RX_QUEUE_MAPPING:
- if (act->rx_queue >= handle->kinfo.num_tqps) {
+ if (act->rx_queue >= num_tqps) {
NL_SET_ERR_MSG_FMT_MOD(extack,
"queue id (%u) should be less than %u",
- act->rx_queue,
- handle->kinfo.num_tqps);
+ act->rx_queue, num_tqps);
return -EINVAL;
}
@@ -2423,12 +2431,11 @@ static int hclge_check_cls_flower(struct hclge_dev *hdev,
return 0;
}
-int hclge_add_cls_flower(struct hnae3_handle *handle,
- struct flow_cls_offload *cls_flower)
+static int hclge_add_cls_flower_common(struct hclge_dev *hdev,
+ struct hclge_vport *vport,
+ struct flow_cls_offload *cls_flower)
{
struct netlink_ext_ack *extack = cls_flower->common.extack;
- struct hclge_vport *vport = hclge_get_vport(handle);
- struct hclge_dev *hdev = vport->back;
struct hclge_fd_rule *rule;
int ret;
@@ -2451,14 +2458,14 @@ int hclge_add_cls_flower(struct hnae3_handle *handle,
return ret;
}
- ret = hclge_get_tc_flower_action(hdev, cls_flower, rule);
+ ret = hclge_get_tc_flower_action(hdev, vport, cls_flower, rule);
if (ret) {
kfree(rule);
return ret;
}
rule->location = cls_flower->common.prio - 1;
- rule->vf_id = 0;
+ rule->vf_id = vport->vport_id;
rule->cls_flower.cookie = cls_flower->cookie;
rule->rule_type = HCLGE_FD_TC_FLOWER_ACTIVE;
@@ -2469,6 +2476,21 @@ int hclge_add_cls_flower(struct hnae3_handle *handle,
return ret;
}
+int hclge_add_cls_flower(struct hnae3_handle *handle,
+ struct flow_cls_offload *cls_flower)
+{
+ struct hclge_vport *vport = hclge_get_vport(handle);
+
+ return hclge_add_cls_flower_common(vport->back, vport, cls_flower);
+}
+
+int hclge_add_cls_flower_vf(struct hclge_vf_rep *vf_rep,
+ struct flow_cls_offload *cls_flower)
+{
+ return hclge_add_cls_flower_common(vf_rep->hdev, vf_rep->vport,
+ cls_flower);
+}
+
static struct hclge_fd_rule *hclge_find_cls_flower(struct hclge_dev *hdev,
unsigned long cookie)
{
@@ -2522,6 +2544,14 @@ int hclge_del_cls_flower(struct hnae3_handle *handle,
return 0;
}
+int hclge_del_cls_flower_vf(struct hclge_vf_rep *vf_rep,
+ struct flow_cls_offload *cls_flower)
+{
+ struct hclge_dev *hdev = vf_rep->hdev;
+
+ return hclge_del_cls_flower(&hdev->vport[0].nic, cls_flower);
+}
+
static void hclge_sync_fd_list(struct hclge_dev *hdev, struct hlist_head *hlist)
{
struct hclge_fd_rule *rule;
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.h
index 2f66cc9c3c65..200d81ce12c8 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_fd.h
@@ -6,6 +6,8 @@
struct hnae3_handle;
struct hclge_dev;
+struct hclge_vf_rep;
+struct flow_cls_offload;
int hclge_init_fd_config(struct hclge_dev *hdev);
int hclge_add_fd_entry(struct hnae3_handle *handle, struct ethtool_rxnfc *cmd);
@@ -26,6 +28,11 @@ int hclge_add_cls_flower(struct hnae3_handle *handle,
int hclge_del_cls_flower(struct hnae3_handle *handle,
struct flow_cls_offload *cls_flower);
bool hclge_is_cls_flower_active(struct hnae3_handle *handle);
+
+int hclge_add_cls_flower_vf(struct hclge_vf_rep *vf_rep,
+ struct flow_cls_offload *cls_flower);
+int hclge_del_cls_flower_vf(struct hclge_vf_rep *vf_rep,
+ struct flow_cls_offload *cls_flower);
int hclge_clear_arfs_rules(struct hclge_dev *hdev);
void hclge_sync_fd_table(struct hclge_dev *hdev);
void hclge_rfs_filter_expire(struct hclge_dev *hdev);
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index fc8587c80813..5f88187f1ca8 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -10534,6 +10534,8 @@ static const struct hnae3_ae_ops hclge_ops = {
.get_ts_info = hclge_ptp_get_ts_info,
.get_link_diagnosis_info = hclge_get_link_diagnosis_info,
.clean_vf_config = hclge_clean_vport_config,
+ .create_vf_reps = hclge_create_vf_reps,
+ .destroy_vf_reps = hclge_destroy_vf_reps,
.get_dscp_prio = hclge_get_dscp_prio,
.get_wol = hclge_get_wol,
.set_wol = hclge_set_wol,
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
index 7419481422c3..4f11b9c38e69 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
@@ -17,6 +17,9 @@
#include "hnae3.h"
#include "hclge_comm_rss.h"
#include "hclge_comm_tqp_stats.h"
+#include "hclge_vf_rep.h"
+
+struct hclge_vf_rep;
#define HCLGE_MOD_VERSION "1.0"
#define HCLGE_DRIVER_NAME "hclge"
@@ -935,6 +938,9 @@ struct hclge_dev {
bool cur_promisc;
int num_alloc_vfs; /* Actual number of VFs allocated */
+ struct hclge_vf_rep **vf_reps;
+ u16 num_vf_reps;
+
struct hclge_comm_tqp *htqp;
struct hclge_vport *vport;
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c
new file mode 100644
index 000000000000..c51336040d6f
--- /dev/null
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c
@@ -0,0 +1,159 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright (c) 2026 Hisilicon Limited.
+
+#include <linux/netdevice.h>
+#include <linux/pci.h>
+#include <net/flow_offload.h>
+
+#include "hclge_main.h"
+#include "hclge_vf_rep.h"
+#include "hclge_fd.h"
+
+static netdev_tx_t hclge_vf_rep_xmit(struct sk_buff *skb,
+ struct net_device *dev)
+{
+ dev_kfree_skb_any(skb);
+ dev->stats.tx_dropped++;
+ return NETDEV_TX_OK;
+}
+
+static int hclge_vf_rep_get_phys_port_name(struct net_device *dev,
+ char *buf, size_t len)
+{
+ struct hclge_vf_rep *vf_rep = netdev_priv(dev);
+ struct hclge_dev *hdev = vf_rep->hdev;
+ int rc;
+
+ rc = snprintf(buf, len, "pf%uvf%u", PCI_FUNC(hdev->pdev->devfn),
+ vf_rep->vport->vport_id - 1);
+ if (rc >= len)
+ return -EOPNOTSUPP;
+
+ return 0;
+}
+
+static int hclge_vf_rep_setup_tc_block_cb(enum tc_setup_type type,
+ void *type_data, void *cb_priv)
+{
+ struct flow_cls_offload *cls_flower = type_data;
+ struct hclge_vf_rep *vf_rep = cb_priv;
+
+ if (!tc_cls_can_offload_and_chain0(vf_rep->netdev, type_data))
+ return -EOPNOTSUPP;
+
+ switch (type) {
+ case TC_SETUP_CLSFLOWER:
+ switch (cls_flower->command) {
+ case FLOW_CLS_REPLACE:
+ return hclge_add_cls_flower_vf(vf_rep, cls_flower);
+ case FLOW_CLS_DESTROY:
+ return hclge_del_cls_flower_vf(vf_rep, cls_flower);
+ default:
+ return -EOPNOTSUPP;
+ }
+ default:
+ return -EOPNOTSUPP;
+ }
+}
+
+static LIST_HEAD(hclge_vf_rep_block_cb_list);
+
+static int hclge_vf_rep_setup_tc(struct net_device *dev,
+ enum tc_setup_type type, void *type_data)
+{
+ struct hclge_vf_rep *vf_rep = netdev_priv(dev);
+
+ switch (type) {
+ case TC_SETUP_BLOCK:
+ return flow_block_cb_setup_simple(type_data,
+ &hclge_vf_rep_block_cb_list,
+ hclge_vf_rep_setup_tc_block_cb,
+ vf_rep, vf_rep, true);
+ default:
+ return -EOPNOTSUPP;
+ }
+}
+
+static const struct net_device_ops hclge_vf_rep_netdev_ops = {
+ .ndo_start_xmit = hclge_vf_rep_xmit,
+ .ndo_get_phys_port_name = hclge_vf_rep_get_phys_port_name,
+ .ndo_setup_tc = hclge_vf_rep_setup_tc,
+};
+
+static void hclge_vf_rep_net_setup(struct net_device *ndev)
+{
+ ndev->netdev_ops = &hclge_vf_rep_netdev_ops;
+ ndev->needs_free_netdev = true;
+ ndev->features |= NETIF_F_HW_TC;
+}
+
+int hclge_create_vf_reps(struct hnae3_ae_dev *ae_dev, int num_vfs)
+{
+ struct hclge_dev *hdev = ae_dev->priv;
+ struct hclge_vf_rep *vf_rep;
+ struct net_device *ndev;
+ char name[IFNAMSIZ];
+ int ret, i;
+
+ if (!num_vfs)
+ return 0;
+
+ hdev->vf_reps = kcalloc(num_vfs, sizeof(struct hclge_vf_rep *),
+ GFP_KERNEL);
+ if (!hdev->vf_reps)
+ return -ENOMEM;
+
+ for (i = 0; i < num_vfs; i++) {
+ snprintf(name, IFNAMSIZ, "%s_rep%d",
+ hdev->vport[0].nic.netdev->name, i);
+ ndev = alloc_netdev(sizeof(struct hclge_vf_rep), name,
+ NET_NAME_UNKNOWN, ether_setup);
+ if (!ndev) {
+ ret = -ENOMEM;
+ goto err;
+ }
+
+ hclge_vf_rep_net_setup(ndev);
+
+ vf_rep = netdev_priv(ndev);
+ vf_rep->hdev = hdev;
+ vf_rep->vport = &hdev->vport[i + HCLGE_VF_VPORT_START_NUM];
+ vf_rep->netdev = ndev;
+
+ ret = register_netdev(ndev);
+ if (ret) {
+ free_netdev(ndev);
+ goto err;
+ }
+
+ hdev->vf_reps[i] = vf_rep;
+ }
+
+ hdev->num_vf_reps = num_vfs;
+ return 0;
+
+err:
+ while (i--)
+ unregister_netdev(hdev->vf_reps[i]->netdev);
+ kfree(hdev->vf_reps);
+ hdev->vf_reps = NULL;
+ return ret;
+}
+
+void hclge_destroy_vf_reps(struct hnae3_ae_dev *ae_dev)
+{
+ struct hclge_dev *hdev = ae_dev->priv;
+ int i;
+
+ if (!hdev->vf_reps)
+ return;
+
+ for (i = 0; i < hdev->num_vf_reps; i++) {
+ if (hdev->vf_reps[i])
+ unregister_netdev(hdev->vf_reps[i]->netdev);
+ }
+
+ kfree(hdev->vf_reps);
+ hdev->vf_reps = NULL;
+ hdev->num_vf_reps = 0;
+}
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.h
new file mode 100644
index 000000000000..fb2080ae627b
--- /dev/null
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.h
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/* Copyright (c) 2026 Hisilicon Limited. */
+
+#ifndef __HCLGE_VF_REP_H
+#define __HCLGE_VF_REP_H
+
+struct hnae3_ae_dev;
+struct hclge_dev;
+struct hclge_vport;
+struct net_device;
+
+struct hclge_vf_rep {
+ struct hclge_dev *hdev;
+ struct hclge_vport *vport;
+ struct net_device *netdev;
+};
+
+int hclge_create_vf_reps(struct hnae3_ae_dev *ae_dev, int num_vfs);
+void hclge_destroy_vf_reps(struct hnae3_ae_dev *ae_dev);
+
+#endif
base-commit: 1c664ec4b9ea827b609d296921ed5bad8a40a158
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFC net-next] net: hns3: add VF representor for tc flower queue selection
2026-07-01 13:08 [PATCH RFC net-next] net: hns3: add VF representor for tc flower queue selection Jijie Shao
@ 2026-07-01 16:56 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-07-01 16:56 UTC (permalink / raw)
To: Jijie Shao; +Cc: oe-kbuild-all
Hi Jijie,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on 1c664ec4b9ea827b609d296921ed5bad8a40a158]
url: https://github.com/intel-lab-lkp/linux/commits/Jijie-Shao/net-hns3-add-VF-representor-for-tc-flower-queue-selection/20260701-213500
base: 1c664ec4b9ea827b609d296921ed5bad8a40a158
patch link: https://lore.kernel.org/r/20260701130806.695180-1-shaojijie%40huawei.com
patch subject: [PATCH RFC net-next] net: hns3: add VF representor for tc flower queue selection
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260702/202607020021.909sTNav-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260702/202607020021.909sTNav-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607020021.909sTNav-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c: In function 'hclge_create_vf_reps':
>> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c:107:45: warning: '_rep' directive output may be truncated writing 4 bytes into a region of size between 1 and 16 [-Wformat-truncation=]
107 | snprintf(name, IFNAMSIZ, "%s_rep%d",
| ^~~~
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c:107:42: note: directive argument in the range [0, 2147483646]
107 | snprintf(name, IFNAMSIZ, "%s_rep%d",
| ^~~~~~~~~~
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c:107:17: note: 'snprintf' output between 6 and 30 bytes into a destination of size 16
107 | snprintf(name, IFNAMSIZ, "%s_rep%d",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
108 | hdev->vport[0].nic.netdev->name, i);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/_rep +107 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_vf_rep.c
89
90 int hclge_create_vf_reps(struct hnae3_ae_dev *ae_dev, int num_vfs)
91 {
92 struct hclge_dev *hdev = ae_dev->priv;
93 struct hclge_vf_rep *vf_rep;
94 struct net_device *ndev;
95 char name[IFNAMSIZ];
96 int ret, i;
97
98 if (!num_vfs)
99 return 0;
100
101 hdev->vf_reps = kcalloc(num_vfs, sizeof(struct hclge_vf_rep *),
102 GFP_KERNEL);
103 if (!hdev->vf_reps)
104 return -ENOMEM;
105
106 for (i = 0; i < num_vfs; i++) {
> 107 snprintf(name, IFNAMSIZ, "%s_rep%d",
108 hdev->vport[0].nic.netdev->name, i);
109 ndev = alloc_netdev(sizeof(struct hclge_vf_rep), name,
110 NET_NAME_UNKNOWN, ether_setup);
111 if (!ndev) {
112 ret = -ENOMEM;
113 goto err;
114 }
115
116 hclge_vf_rep_net_setup(ndev);
117
118 vf_rep = netdev_priv(ndev);
119 vf_rep->hdev = hdev;
120 vf_rep->vport = &hdev->vport[i + HCLGE_VF_VPORT_START_NUM];
121 vf_rep->netdev = ndev;
122
123 ret = register_netdev(ndev);
124 if (ret) {
125 free_netdev(ndev);
126 goto err;
127 }
128
129 hdev->vf_reps[i] = vf_rep;
130 }
131
132 hdev->num_vf_reps = num_vfs;
133 return 0;
134
135 err:
136 while (i--)
137 unregister_netdev(hdev->vf_reps[i]->netdev);
138 kfree(hdev->vf_reps);
139 hdev->vf_reps = NULL;
140 return ret;
141 }
142
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-01 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01 13:08 [PATCH RFC net-next] net: hns3: add VF representor for tc flower queue selection Jijie Shao
2026-07-01 16:56 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.