All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: [PATCH v1 0/6] Improve ata_scsi_report_supported_opcodes()
Date: Thu,  2 Jul 2026 10:56:40 +0900	[thread overview]
Message-ID: <20260702015646.1702539-1-dlemoal@kernel.org> (raw)

The implementation of ata_scsi_report_supported_opcodes() mostly satisfies
the internal use when an ATA device is probed from the SCSI layer, but it
is very incomplete. The code is also not very flexible for extending
support for new commands.

This patch series address these issues, cleaning up the implementation and
making REPORT SUPPORTED OPERATION CODES fully functional. E.g., with these
changes, sg_opcodes can be used for listing all SCSI commands that are
supported by libata-scsi and a device.

Example:

     # sg_opcodes /dev/sda
       ATA       WDC  WUH722626AL  WZ41
       Peripheral device type: disk
    
     Opcode  Service    CDB  RWCDLP,  Name
     (hex)   action(h)  size   CDLP
     -----------------------------------------------
      00                  6    0,0    Test Unit Ready
      01                  6    0,0    Rezero Unit
      03                  6    0,0    Request Sense
      08                  6    0,0    Read(6)
      0a                  6    0,0    Write(6)
      0b                  6    0,0    Seek(6)
      12                  6    0,0    Inquiry
      15                  6    0,0    Mode select(6)
      1a                  6    0,0    Mode sense(6)
      1b                  6    0,0    Start stop unit
      1d                  6    0,0    Send diagnostic
      25                 10    0,0    Read capacity(10)
      28                 10    0,0    Read(10)
      2a                 10    0,0    Write(10)
      2b                 10    0,0    Seek(10)
      2f                 10    0,0    Verify(10)
      35                 10    0,0    Synchronize cache(10)
      55                 10    0,0    Mode select(10)
      5a                 10    0,0    Mode sense(10)
      7f                 32    0,0    Variable length
      85                 16    0,0    ATA pass-through(16)
      88                 16    1,1    Read(16)
      8a                 16    1,2    Write(16)
      8f                 16    0,0    Verify(16)
      91                 16    0,0    Synchronize cache(16)
      93                 16    0,0    Write same(16)
      9e       10        16    0,0    Read capacity(16)
      a0                 12    0,0    Report luns
      a1                 12    0,0    ATA pass-through(12)
      a3        c        12    0,0    Report supported operation codes

Damien Le Moal (6):
  ata: libata: rename ata_dev_is_zac()
  ata: libata-scsi: refactor ata_scsi_report_supported_opcodes()
  ata: libata-scsi: improve service action support in
    ata_scsi_report_supported_opcodes()
  ata: libata-scsi: improves checks for ZBC_IN and ZBC_OUT commands
    support
  ata: libata-scsi: support reporting options 2 in REPORT SUPPORTED
    OPERATION CODES
  ata: libata-scsi: support the all command format for reporting
    supported commands

 drivers/ata/libata-core.c |   6 +-
 drivers/ata/libata-scsi.c | 252 +++++++++++++++++++++++++++++---------
 drivers/ata/libata.h      |   2 +-
 3 files changed, 199 insertions(+), 61 deletions(-)

-- 
2.54.0


             reply	other threads:[~2026-07-02  1:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  1:56 Damien Le Moal [this message]
2026-07-02  1:56 ` [PATCH v1 1/6] ata: libata: rename ata_dev_is_zac() Damien Le Moal
2026-07-02  1:56 ` [PATCH v1 2/6] ata: libata-scsi: refactor ata_scsi_report_supported_opcodes() Damien Le Moal
2026-07-02  1:56 ` [PATCH v1 3/6] ata: libata-scsi: improve service action support in ata_scsi_report_supported_opcodes() Damien Le Moal
2026-07-02  2:11   ` sashiko-bot
2026-07-02  1:56 ` [PATCH v1 4/6] ata: libata-scsi: improves checks for ZBC_IN and ZBC_OUT commands support Damien Le Moal
2026-07-02  2:07   ` sashiko-bot
2026-07-02  2:19     ` Damien Le Moal
2026-07-02  1:56 ` [PATCH v1 5/6] ata: libata-scsi: support reporting options 2 in REPORT SUPPORTED OPERATION CODES Damien Le Moal
2026-07-02  2:13   ` sashiko-bot
2026-07-02  1:56 ` [PATCH v1 6/6] ata: libata-scsi: support the all command format for reporting supported commands Damien Le Moal
2026-07-02  2:11   ` sashiko-bot
2026-07-02  2:27     ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702015646.1702539-1-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.