* [PATCH 1/2] bpf: default log level should be NOTICE
@ 2026-07-01 22:34 Stephen Hemminger
2026-07-01 22:34 ` [PATCH 2/2] bpf: silence noisy message Stephen Hemminger
2026-07-02 8:40 ` [PATCH 1/2] bpf: default log level should be NOTICE Marat Khalili
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Hemminger @ 2026-07-01 22:34 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Konstantin Ananyev, Marat Khalili
BPF is used by other services now and the default log
level should match other libraries.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/bpf/bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/bpf/bpf.c b/lib/bpf/bpf.c
index 740c080591..695454a2d4 100644
--- a/lib/bpf/bpf.c
+++ b/lib/bpf/bpf.c
@@ -78,4 +78,4 @@ __rte_bpf_jit(struct rte_bpf *bpf)
return rc;
}
-RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, NOTICE);
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] bpf: silence noisy message
2026-07-01 22:34 [PATCH 1/2] bpf: default log level should be NOTICE Stephen Hemminger
@ 2026-07-01 22:34 ` Stephen Hemminger
2026-07-02 8:36 ` Marat Khalili
2026-07-02 8:40 ` [PATCH 1/2] bpf: default log level should be NOTICE Marat Khalili
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2026-07-01 22:34 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Konstantin Ananyev, Marat Khalili
The recent loader change causes a log message every time BPF
is used. For example, running dpdk-dumpcap cause:
BPF: rte_bpf_load_ex(): successfully creates ...
This is a debug message and should not normally be needed.
Fixes: 55192fe168b9 ("bpf: introduce extensible load API")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/bpf/bpf_load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/bpf/bpf_load.c b/lib/bpf/bpf_load.c
index 2fd0ee0720..36f6556fd5 100644
--- a/lib/bpf/bpf_load.c
+++ b/lib/bpf/bpf_load.c
@@ -286,7 +286,7 @@ rte_bpf_load_ex(const struct rte_bpf_prm_ex *prm)
return NULL;
}
- RTE_BPF_LOG_FUNC_LINE(INFO, "successfully creates %p(jit={.func=%p,.sz=%zu});",
+ RTE_BPF_LOG_FUNC_LINE(DEBUG, "successfully creates %p(jit={.func=%p,.sz=%zu});",
load.bpf, load.bpf->jit.raw, load.bpf->jit.sz);
return load.bpf;
}
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH 2/2] bpf: silence noisy message
2026-07-01 22:34 ` [PATCH 2/2] bpf: silence noisy message Stephen Hemminger
@ 2026-07-02 8:36 ` Marat Khalili
2026-07-02 16:30 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Marat Khalili @ 2026-07-02 8:36 UTC (permalink / raw)
To: Stephen Hemminger, dev@dpdk.org; +Cc: Konstantin Ananyev
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday 1 July 2026 23:35
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Konstantin Ananyev <konstantin.ananyev@huawei.com>;
> Marat Khalili <marat.khalili@huawei.com>
> Subject: [PATCH 2/2] bpf: silence noisy message
>
> The recent loader change causes a log message every time BPF
> is used. For example, running dpdk-dumpcap cause:
> BPF: rte_bpf_load_ex(): successfully creates ...
>
> This is a debug message and should not normally be needed.
>
> Fixes: 55192fe168b9 ("bpf: introduce extensible load API")
The commit message and Fixes tag are not 100% accurate, this message existed before:
https://github.com/DPDK/dpdk/blob/09e4f37ddd0f7d5cc7c696741f31f1582c73a716/lib/bpf/bpf_load_elf.c#L331-L333
(In fact I tried to eliminate it, but had to but back at the insistence of AI reviewer
and even broke the build in the process...)
So naturally I support downgrading this message. With the commit message corrected,
Acked-by: Marat Khalili <marat.khalili@huawei.com>
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/bpf/bpf_load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/bpf/bpf_load.c b/lib/bpf/bpf_load.c
> index 2fd0ee0720..36f6556fd5 100644
> --- a/lib/bpf/bpf_load.c
> +++ b/lib/bpf/bpf_load.c
> @@ -286,7 +286,7 @@ rte_bpf_load_ex(const struct rte_bpf_prm_ex *prm)
> return NULL;
> }
>
> - RTE_BPF_LOG_FUNC_LINE(INFO, "successfully creates %p(jit={.func=%p,.sz=%zu});",
> + RTE_BPF_LOG_FUNC_LINE(DEBUG, "successfully creates %p(jit={.func=%p,.sz=%zu});",
> load.bpf, load.bpf->jit.raw, load.bpf->jit.sz);
> return load.bpf;
> }
> --
> 2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] bpf: default log level should be NOTICE
2026-07-01 22:34 [PATCH 1/2] bpf: default log level should be NOTICE Stephen Hemminger
2026-07-01 22:34 ` [PATCH 2/2] bpf: silence noisy message Stephen Hemminger
@ 2026-07-02 8:40 ` Marat Khalili
1 sibling, 0 replies; 6+ messages in thread
From: Marat Khalili @ 2026-07-02 8:40 UTC (permalink / raw)
To: Stephen Hemminger, dev@dpdk.org; +Cc: Konstantin Ananyev
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday 1 July 2026 23:35
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Konstantin Ananyev <konstantin.ananyev@huawei.com>;
> Marat Khalili <marat.khalili@huawei.com>
> Subject: [PATCH 1/2] bpf: default log level should be NOTICE
>
> BPF is used by other services now and the default log
> level should match other libraries.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/bpf/bpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/bpf/bpf.c b/lib/bpf/bpf.c
> index 740c080591..695454a2d4 100644
> --- a/lib/bpf/bpf.c
> +++ b/lib/bpf/bpf.c
> @@ -78,4 +78,4 @@ __rte_bpf_jit(struct rte_bpf *bpf)
> return rc;
> }
>
> -RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, INFO);
> +RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, NOTICE);
> --
> 2.53.0
Acked-by: Marat Khalili <marat.khalili@huawei.com>
(I wonder if this default should have a name like LIB_DEFAULT.)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-02 16:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01 22:34 [PATCH 1/2] bpf: default log level should be NOTICE Stephen Hemminger
2026-07-01 22:34 ` [PATCH 2/2] bpf: silence noisy message Stephen Hemminger
2026-07-02 8:36 ` Marat Khalili
2026-07-02 16:30 ` Stephen Hemminger
2026-07-02 16:34 ` Marat Khalili
2026-07-02 8:40 ` [PATCH 1/2] bpf: default log level should be NOTICE Marat Khalili
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.