All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: "Michel Dänzer" <michel.daenzer@mailbox.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: 7.1 regression bisected to "usb: core: Fix SuperSpeed root hub wMaxPacketSize"
Date: Thu, 2 Jul 2026 10:51:52 +0200	[thread overview]
Message-ID: <20260702105152.415afeaa.michal.pecio@gmail.com> (raw)
In-Reply-To: <577c7ba6-c638-4e73-acac-fbf6c4fb4ccc@linux.intel.com>

On Thu, 2 Jul 2026 00:09:42 +0300, Mathias Nyman wrote:
> On 7/1/26 19:02, Michel Dänzer wrote:
> > 
> > The ethernet port of a Lenovo ThinkPad USB-C Dock Gen2 connected to
> > a ThinkPad P14s Gen 5 AMD stopped working in 7.1.
> > 
> >   ip addr show enx482ae347e7c3
> > 
> > says the interface doesn't exist. The only thing about it in dmesg
> > is:
> > 
> >   r8152 8-1.1:1.0 enx482ae347e7c3: renamed from eth0
> > 
> > In previous kernels, dmesg had more lines about it:
> > 
> >   r8152 8-1.1:1.0 enx482ae347e7c3: renamed from eth0
> >   r8152 8-1.1:1.0 enx482ae347e7c3: carrier on
> >   r8152 8-1.1:1.0 enx482ae347e7c3: carrier off
> >   r8152 8-1.1:1.0 enx482ae347e7c3: carrier on
> > 
> > 
> > I bisected this to d1e280334b7f ("usb: core: Fix SuperSpeed root
> > hub wMaxPacketSize"). Reverting that commit on top of 7.1.2 fixes
> > the issue.

Incredibly bizarre, I wonder if it's some userspace madness.

Does this alternative patch (on top of the revert) break it too?
https://lore.kernel.org/linux-usb/20260504111353.55ba2530.michal.pecio@gmail.com/

> That patch limits USB3 roothub change bitmap from 4 bytes to 2 bytes,
> which should be enough for the max 15 children USB3 hubs support.
> Odd that this change impacts the usb ethernet device of that dock.

Very odd: as you said before, hub driver wouldn't support more than
15 ports anyway, the problem occurs on port 1, and is not any obvious
hub issue like connection event never noticed by the kernel.

I thought that maybe writing the status change URB overflows its
transfer buffer, but usb_hcd_poll_rh_status() seems to be handling
such cases correctly. And xhci_hub_status_data() isn't even aware
of URB length, so it can't be sensitive to this change.

> If possible, could you share a dmesg with usbcore dynamic debug
> enabled
> 
> mount -t debugfs none /sys/kernel/debug
> echo 'module usbcore =p' >/sys/kernel/debug/dynamic_debug/control
> <connect dock>
> dmesg

If not possible, please at least post ordinary dmesg. Even if there is
nothing more about "enx482ae347e7c3", there might be about "8-1.1:1.0".
The snippet above is a small part of typical r8152 connection log.

Regards,
Michal


  reply	other threads:[~2026-07-02  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 16:02 7.1 regression bisected to "usb: core: Fix SuperSpeed root hub wMaxPacketSize" Michel Dänzer
2026-07-01 21:09 ` Mathias Nyman
2026-07-02  8:51   ` Michal Pecio [this message]
2026-07-02 12:20     ` Michel Dänzer
2026-07-02 12:22       ` Greg Kroah-Hartman
2026-07-02 12:25         ` Michel Dänzer
2026-07-02 12:38           ` Greg Kroah-Hartman
2026-07-02 16:34             ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702105152.415afeaa.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=michel.daenzer@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.