All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Michel Dänzer" <michel.daenzer@mailbox.org>,
	"Michal Pecio" <michal.pecio@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: 7.1 regression bisected to "usb: core: Fix SuperSpeed root hub wMaxPacketSize"
Date: Thu, 2 Jul 2026 00:09:42 +0300	[thread overview]
Message-ID: <577c7ba6-c638-4e73-acac-fbf6c4fb4ccc@linux.intel.com> (raw)
In-Reply-To: <cb287e3d-3066-4820-b464-6208b947974b@mailbox.org>

On 7/1/26 19:02, Michel Dänzer wrote:
> 
> The ethernet port of a Lenovo ThinkPad USB-C Dock Gen2 connected to a ThinkPad P14s Gen 5 AMD stopped working in 7.1.
> 
>   ip addr show enx482ae347e7c3
> 
> says the interface doesn't exist. The only thing about it in dmesg is:
> 
>   r8152 8-1.1:1.0 enx482ae347e7c3: renamed from eth0
> 
> In previous kernels, dmesg had more lines about it:
> 
>   r8152 8-1.1:1.0 enx482ae347e7c3: renamed from eth0
>   r8152 8-1.1:1.0 enx482ae347e7c3: carrier on
>   r8152 8-1.1:1.0 enx482ae347e7c3: carrier off
>   r8152 8-1.1:1.0 enx482ae347e7c3: carrier on
> 
> 
> I bisected this to d1e280334b7f ("usb: core: Fix SuperSpeed root hub wMaxPacketSize"). Reverting that commit on top of 7.1.2 fixes the issue.
> 
> 

Thanks for reporting this.

That patch limits USB3 roothub change bitmap from 4 bytes to 2 bytes, which
should be enough for the max 15 children USB3 hubs support.
Odd that this change impacts the usb ethernet device of that dock.

It's not an important change, and should be reverted to get things working.
It also reveals there might be a off-by-one or similar bug in hub or xhci code.
would be nice to get that fixed.

Does the roothub have 15 USB3 ports?

If possible, could you share a dmesg with usbcore dynamic debug enabled

mount -t debugfs none /sys/kernel/debug
echo 'module usbcore =p' >/sys/kernel/debug/dynamic_debug/control
<connect dock>
dmesg

Thanks
Mathias

  reply	other threads:[~2026-07-01 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 16:02 7.1 regression bisected to "usb: core: Fix SuperSpeed root hub wMaxPacketSize" Michel Dänzer
2026-07-01 21:09 ` Mathias Nyman [this message]
2026-07-02  8:51   ` Michal Pecio
2026-07-02 12:20     ` Michel Dänzer
2026-07-02 12:22       ` Greg Kroah-Hartman
2026-07-02 12:25         ` Michel Dänzer
2026-07-02 12:38           ` Greg Kroah-Hartman
2026-07-02 16:34             ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577c7ba6-c638-4e73-acac-fbf6c4fb4ccc@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.pecio@gmail.com \
    --cc=michel.daenzer@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.