All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhuoying Cai <zycai@linux.ibm.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,
	richard.henderson@linaro.org, david@kernel.org,
	walling@linux.ibm.com, jjherne@linux.ibm.com,
	pasic@linux.ibm.com, borntraeger@linux.ibm.com,
	farman@linux.ibm.com, mjrosato@linux.ibm.com, iii@linux.ibm.com,
	eblake@redhat.com, armbru@redhat.com, zycai@linux.ibm.com,
	alifm@linux.ibm.com, brueckner@linux.ibm.com,
	pierrick.bouvier@oss.qualcomm.com, jdaley@linux.ibm.com
Subject: [PATCH v13 10/33] hw/s390x: Define finite size for single entry VCEntry
Date: Thu,  2 Jul 2026 22:29:08 -0400	[thread overview]
Message-ID: <20260703022933.1805010-11-zycai@linux.ibm.com> (raw)
In-Reply-To: <20260703022933.1805010-1-zycai@linux.ibm.com>

Define MAX_VCENTRY_SIZE(8KB) and CERT_BUF_MAX_LEN to establish a finite
size for a single entry VCEntry. Add validation in update_cert_store()
to ensure certificate data does not exceed this limit.

This finite size definition is needed for proper memory allocation and
will be used in a later commit to handle VCEntry structures with known
size constraints.

Signed-off-by: Zhuoying Cai <zycai@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
---
 hw/s390x/cert-store.c          | 6 ++++++
 include/hw/s390x/ipl/diag320.h | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/hw/s390x/cert-store.c b/hw/s390x/cert-store.c
index aa2c1259eb..e5f79c4ed7 100644
--- a/hw/s390x/cert-store.c
+++ b/hw/s390x/cert-store.c
@@ -86,6 +86,12 @@ static int update_cert_store(S390IPLCertificateStore *cert_store,
     cert_buf_size = ROUND_UP(cert->der_size, 4);
     data_buf_size = keyid_buf_size + hash_buf_size + cert_buf_size;
 
+    if (data_buf_size > CERT_BUF_MAX_LEN) {
+        error_report("Certificate data size %zu exceeds maximum buffer size %ld",
+                     data_buf_size, CERT_BUF_MAX_LEN);
+        return -1;
+    }
+
     if (cert_store->largest_cert_size < data_buf_size) {
         cert_store->largest_cert_size = data_buf_size;
     }
diff --git a/include/hw/s390x/ipl/diag320.h b/include/hw/s390x/ipl/diag320.h
index 7fda2d44fd..f3c23a3176 100644
--- a/include/hw/s390x/ipl/diag320.h
+++ b/include/hw/s390x/ipl/diag320.h
@@ -92,6 +92,9 @@ struct VCEntry {
 };
 typedef struct VCEntry VCEntry;
 
+#define MAX_VCENTRY_SIZE      (8 * 1024)
+#define CERT_BUF_MAX_LEN      (MAX_VCENTRY_SIZE - sizeof(VCEntryHeader))
+
 struct VCBlockHeader {
     uint32_t in_len;
     uint32_t reserved0;
-- 
2.54.0



  parent reply	other threads:[~2026-07-03  2:30 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03  2:28 [PATCH v13 00/33] Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices Zhuoying Cai
2026-07-03  2:28 ` [PATCH v13 01/33] Add boot-certs to s390-ccw-virtio machine type option Zhuoying Cai
2026-07-03 13:24   ` Matthew Rosato
2026-07-03  2:29 ` [PATCH v13 02/33] crypto/x509-utils: Refactor with GNUTLS fallback Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 03/33] crypto/x509-utils: Add helper functions for certificate store Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 04/33] hw/s390x/ipl: Create " Zhuoying Cai
2026-07-03 16:56   ` Matthew Rosato
2026-07-03  2:29 ` [PATCH v13 05/33] s390x/diag: Introduce DIAG 320 for Certificate Store Facility Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 06/33] s390x/diag: Refactor address validation check from diag308_parm_check Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 07/33] s390x/diag: Implement DIAG 320 subcode 1 Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 08/33] crypto/x509-utils: Add helper functions for DIAG 320 subcode 2 Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 09/33] s390x/diag: Implement " Zhuoying Cai
2026-07-03  2:29 ` Zhuoying Cai [this message]
2026-07-03  2:29 ` [PATCH v13 11/33] s390x/diag: Introduce DIAG 508 for secure IPL operations Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 12/33] crypto/x509-utils: Add helper functions for DIAG 508 subcode 1 Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 13/33] s390x/diag: Generalize s390_ipl_read/write to accept void * Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 14/33] s390x/diag: Implement DIAG 508 subcode 1 for signature verification Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 15/33] s390x/ipl: Introduce IPL Information Report Block (IIRB) Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 16/33] pc-bios/s390-ccw: Define memory for IPLB and convert IPLB to pointers Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 17/33] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 18/33] hw/s390x/ipl: Rework s390_ipl_map_iplb_chain for certificate storage Zhuoying Cai
2026-07-03 13:47   ` Eric Farman
2026-07-03  2:29 ` [PATCH v13 19/33] s390x: Guest support for Secure-IPL Facility Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 20/33] pc-bios/s390-ccw: Refactor zipl_run() Zhuoying Cai
2026-07-03  2:40   ` Philippe Mathieu-Daudé
2026-07-03  2:29 ` [PATCH v13 21/33] pc-bios/s390-ccw: Rework zipl_load_segment function Zhuoying Cai
2026-07-03  2:38   ` Philippe Mathieu-Daudé
2026-07-03 14:28     ` Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 22/33] pc-bios/s390-ccw: Introduce ZiplBootMode enum for IPL mode selection Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 23/33] pc-bios/s390-ccw: Add signature verification for secure IPL in audit mode Zhuoying Cai
2026-07-03 11:40   ` Eric Farman
2026-07-03 13:56     ` Zhuoying Cai
2026-07-04  0:43       ` Eric Farman
2026-07-03 13:58     ` Eric Farman
2026-07-03  2:29 ` [PATCH v13 24/33] pc-bios/s390-ccw: Add signed component address overlap checks Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 25/33] s390x: Guest support for Secure-IPL Code Loading Attributes Facility (SCLAF) Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 26/33] pc-bios/s390-ccw: Add additional security checks for secure boot Zhuoying Cai
2026-07-03 12:17   ` Eric Farman
2026-07-03  2:29 ` [PATCH v13 27/33] Add secure-boot to s390-ccw-virtio machine type option Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 28/33] hw/s390x/ipl: Set IPIB flags for secure IPL Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 29/33] pc-bios/s390-ccw: Handle true secure IPL mode Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 30/33] hw/s390x/ipl: Handle secure boot with multiple boot devices Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 31/33] tests/functional/s390x: Add secure IPL functional test Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 32/33] docs/specs: Add secure IPL documentation Zhuoying Cai
2026-07-03  2:29 ` [PATCH v13 33/33] docs/system/s390x: " Zhuoying Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703022933.1805010-11-zycai@linux.ibm.com \
    --to=zycai@linux.ibm.com \
    --cc=alifm@linux.ibm.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=brueckner@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@kernel.org \
    --cc=eblake@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jdaley@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=jrossi@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.