Re: [PATCH v3 07/10] nvme-multipath: add nvme_mpath_synchronize()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a wrapper `nvme_mpath_synchronize()` that calls an undefined function `mpath_synchronize()`, relying on a missing dependency (`libmultipath`), which leads to a build failure.
--

commit f655883eea782b4086749f2985502e444177db21
Author: John Garry <john.g.garry@oracle.com>

nvme-multipath: add nvme_mpath_synchronize()

This commit adds a wrapper function which calls into mpath_synchronize
for the NVME multipath subsystem.

> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index 35618285caf89..292526c9dda29 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -1078,6 +1078,11 @@ void nvme_mpath_ioctl_begin(struct mpath_device *mpath_device,
>  			unsigned int cmd, void **opaque);
>  void nvme_mpath_ioctl_finish(void *opaque);
>  
> +static inline void nvme_mpath_synchronize(struct nvme_ns_head *head)
> +{
> +	mpath_synchronize(&head->mpath_head);

[Severity: Low]
Does this code build cleanly? It appears that mpath_synchronize() is not 
declared or defined in the current tree. This seems like it would cause 
a compiler error due to an implicit function declaration when building 
with NVME multipath enabled. 

Is this patch relying on a missing dependency or missing header inclusion?

> +}
> +
>  static inline void nvme_trace_bio_complete(struct request *req)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703103204.3724406-1-john.g.garry@oracle.com?part=7