Re: [PATCH v3 08/10] nvme-multipath: add nvme_{add,delete}_ns()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The function `nvme_add_ns()` unconditionally accesses `ns->ctrl->nr_active`, which is conditionally compiled, causing a build failure when `CONFIG_NVME_MULTIPATH` is disabled.
- [Low] The patch introduces calls to undeclared functions (`mpath_add_device`, `mpath_delete_device`), causing a hard compilation failure.
--

commit 6769aa1dce3bd34edd5c71bc4aa5c9950e9c148a
Author: John Garry <john.g.garry@oracle.com>

nvme-multipath: add nvme_{add,delete}_ns()

This commit adds wrapper functions to call into the mpath_add_device and
mpath_delete_device APIs. The per-NS gendisk pointer is utilized as the
mpath_device disk pointer for libmultipath references.

> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h

[ ... ]

> @@ -1041,6 +1041,18 @@ extern const struct block_device_operations nvme_bdev_ops;
>  
>  void nvme_delete_ctrl_sync(struct nvme_ctrl *ctrl);
>  struct nvme_ns *nvme_find_path(struct nvme_ns_head *head);
> +
> +static inline void nvme_add_ns(struct nvme_ns *ns)
> +{
> +	mpath_add_device(&ns->mpath_device, &ns->head->mpath_head,
> +		ns->disk, ns->ctrl->numa_node, &ns->ctrl->nr_active);

[Severity: Low]
Will this cause a build failure when CONFIG_NVME_MULTIPATH is disabled?
Looking at struct nvme_ctrl, the nr_active field is conditionally compiled,
but nvme_add_ns accesses it unconditionally.

Also, are mpath_add_device and mpath_delete_device declared in a header
that is included here? It appears these functions might be undeclared,
which would result in implicit declaration errors during the build.

> +}
> +
> +static inline bool nvme_delete_ns(struct nvme_ns *ns)
> +{
> +	return mpath_delete_device(&ns->mpath_device);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703103204.3724406-1-john.g.garry@oracle.com?part=8