All of lore.kernel.org
 help / color / mirror / Atom feed
* [frank-w-bpi-r2-4.14:7.1-rc 167/167] drivers/net/dsa/mxl862xx/mxl862xx.c:4685:3-4: Unneeded semicolon
@ 2026-07-03 13:35 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-07-03 13:35 UTC (permalink / raw)
  To: Frank Wunderlich; +Cc: oe-kbuild-all

tree:   https://github.com/frank-w/BPI-R2-4.14 7.1-rc
head:   866eb49750d39fe938dca71acece6f1540bb1123
commit: f3d4d709103380acbd6a4faaa28fd38c5e97b0b4 [167/167] net: dsa: mxl862xx: add ds-mux (WIP)
config: sparc64-randconfig-r064-20260702 (https://download.01.org/0day-ci/archive/20260703/202607032107.mphW923g-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 9.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607032107.mphW923g-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/dsa/mxl862xx/mxl862xx.c:4685:3-4: Unneeded semicolon

vim +4685 drivers/net/dsa/mxl862xx/mxl862xx.c

  4614	
  4615	static int mxl862xx_probe(struct mdio_device *mdiodev)
  4616	{
  4617		struct device *dev = &mdiodev->dev;
  4618		struct mxl862xx_priv *priv;
  4619		struct device_node *mux_np;
  4620		struct dsa_switch *ds;
  4621		int err, i;
  4622	
  4623		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
  4624		if (!priv)
  4625			return -ENOMEM;
  4626	
  4627		priv->mdiodev = mdiodev;
  4628	
  4629		ds = devm_kzalloc(dev, sizeof(*ds), GFP_KERNEL);
  4630		if (!ds)
  4631			return -ENOMEM;
  4632	
  4633		priv->ds = ds;
  4634		ds->dev = dev;
  4635		ds->priv = priv;
  4636		ds->ops = &mxl862xx_switch_ops;
  4637		ds->phylink_mac_ops = &mxl862xx_phylink_mac_ops;
  4638		ds->num_ports = MXL862XX_MAX_PORTS;
  4639		ds->fdb_isolation = true;
  4640		ds->max_num_bridges = MXL862XX_MAX_BRIDGES;
  4641		ds->num_lag_ids = MXL862XX_MAX_LAG_IDS;
  4642	
  4643		mxl862xx_host_init(priv);
  4644	
  4645		for (i = 0; i < MXL862XX_MAX_PORTS; i++) {
  4646			priv->ports[i].priv = priv;
  4647			INIT_WORK(&priv->ports[i].host_flood_work,
  4648				  mxl862xx_host_flood_work_fn);
  4649			spin_lock_init(&priv->ports[i].stats_lock);
  4650		}
  4651	
  4652		INIT_DELAYED_WORK(&priv->stats_work, mxl862xx_stats_work_fn);
  4653	
  4654		priv->tag_proto = DSA_TAG_PROTO_MXL862;
  4655	
  4656		dev_set_drvdata(dev, ds);
  4657	
  4658		err = dsa_register_switch(ds);
  4659		if (err) {
  4660			set_bit(MXL862XX_FLAG_WORK_STOPPED, &priv->flags);
  4661			cancel_delayed_work_sync(&priv->stats_work);
  4662			mxl862xx_host_shutdown(priv);
  4663			for (i = 0; i < MXL862XX_MAX_PORTS; i++)
  4664				cancel_work_sync(&priv->ports[i].host_flood_work);
  4665			return err;
  4666		}
  4667	
  4668		mux_np = of_get_child_by_name(priv->ds->dev->of_node, "ds-mux-bus");
  4669		if (mux_np) {
  4670			struct device_node *child;
  4671	
  4672			for_each_available_child_of_node(mux_np, child) {
  4673				if (!of_device_is_compatible(child,
  4674							     "mxl862xx,ds-mux"))
  4675					continue;
  4676	
  4677				if (!of_device_is_available(child))
  4678					continue;
  4679	
  4680				err = ds_add_mux(priv, child);
  4681				if (err)
  4682					dev_err(dev, "failed to add mux\n");
  4683	
  4684				of_node_put(mux_np);
> 4685			};
  4686		}
  4687	
  4688		return 0;
  4689	}
  4690	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-03 13:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-03 13:35 [frank-w-bpi-r2-4.14:7.1-rc 167/167] drivers/net/dsa/mxl862xx/mxl862xx.c:4685:3-4: Unneeded semicolon kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.