All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com, vkoul@kernel.org,
	linux-phy@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 01/36] dt-bindings: phy: rockchip-usbdp: add improved ports scheme
Date: Fri, 03 Jul 2026 23:42:22 +0000	[thread overview]
Message-ID: <20260703234222.7ECFB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260703-rockchip-usbdp-cleanup-v10-1-a392711ca8a9@collabora.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the deprecation keyword ('depreated' instead of 'deprecated').
--

commit 80cbcd5498584cd573a979a5b4e236da93d09776
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

dt-bindings: phy: rockchip-usbdp: add improved ports scheme

This commit introduces a proper port scheme to the Rockchip USBDP PHY binding
to support USB-C DP AltMode, replacing an undocumented scheme. It deprecates
the single port node in favor of a ports node containing multiple specific
endpoints. The new design roughly follows the Qualcomm QMP USB4-USB3-DP PHY
controller binding while adding an additional port for the USB-C SBU mux.

> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> index 8b7059d5b1826..35d6717b9cc9e 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> @@ -110,10 +110,34 @@ properties:
>  
>    port:
>      $ref: /schemas/graph.yaml#/properties/port
> +    depreated: true
        ^^^^^^^^^

[Severity: Low]
This isn't a bug, but there is a typo here ("depreated" instead of
"deprecated").

>      description:
>        A port node to link the PHY to a TypeC controller for the purpose of
>        handling orientation switching.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703-rockchip-usbdp-cleanup-v10-0-a392711ca8a9@collabora.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com, vkoul@kernel.org,
	linux-phy@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 01/36] dt-bindings: phy: rockchip-usbdp: add improved ports scheme
Date: Fri, 03 Jul 2026 23:42:22 +0000	[thread overview]
Message-ID: <20260703234222.7ECFB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260703-rockchip-usbdp-cleanup-v10-1-a392711ca8a9@collabora.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the deprecation keyword ('depreated' instead of 'deprecated').
--

commit 80cbcd5498584cd573a979a5b4e236da93d09776
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

dt-bindings: phy: rockchip-usbdp: add improved ports scheme

This commit introduces a proper port scheme to the Rockchip USBDP PHY binding
to support USB-C DP AltMode, replacing an undocumented scheme. It deprecates
the single port node in favor of a ports node containing multiple specific
endpoints. The new design roughly follows the Qualcomm QMP USB4-USB3-DP PHY
controller binding while adding an additional port for the USB-C SBU mux.

> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> index 8b7059d5b1826..35d6717b9cc9e 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> @@ -110,10 +110,34 @@ properties:
>  
>    port:
>      $ref: /schemas/graph.yaml#/properties/port
> +    depreated: true
        ^^^^^^^^^

[Severity: Low]
This isn't a bug, but there is a typo here ("depreated" instead of
"deprecated").

>      description:
>        A port node to link the PHY to a TypeC controller for the purpose of
>        handling orientation switching.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703-rockchip-usbdp-cleanup-v10-0-a392711ca8a9@collabora.com?part=1

  reply	other threads:[~2026-07-03 23:42 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 18:13 [PATCH v10 00/36] phy: rockchip: usbdp: Clean up the mess Sebastian Reichel
2026-07-03 18:13 ` Sebastian Reichel
2026-07-03 18:13 ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 01/36] dt-bindings: phy: rockchip-usbdp: add improved ports scheme Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:42   ` sashiko-bot [this message]
2026-07-03 23:42     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 02/36] phy: rockchip: usbdp: Update mode_change after error handling Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 03/36] phy: rockchip: usbdp: Do not lose USB3 PHY status Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 04/36] phy: rockchip: usbdp: Fix devm_clk_bulk_get_all check Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 05/36] phy: rockchip: usbdp: Handle missing clock-names DT property gracefully Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 06/36] phy: rockchip: usbdp: Drop seamless DP takeover Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 07/36] phy: rockchip: usbdp: Keep clocks running on PHY re-init Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 08/36] phy: rockchip: usbdp: Amend SSC modulation deviation Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:44   ` sashiko-bot
2026-07-03 23:44     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 09/36] phy: rockchip: usbdp: Fix LFPS detect threshold control Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 10/36] phy: rockchip: usbdp: Add missing mode_change update Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 11/36] phy: rockchip: usbdp: Support single-lane DP Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 12/36] phy: rockchip: usbdp: Limit DP lane count to muxed lanes Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 13/36] phy: rockchip: usbdp: Rename DP lane functions Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:46   ` sashiko-bot
2026-07-03 23:46     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 14/36] phy: rockchip: usbdp: Use FIELD_PREP_WM16_CONST Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 15/36] phy: rockchip: usbdp: Cleanup DP lane selection function Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 16/36] phy: rockchip: usbdp: Register DP aux bridge Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 17/36] phy: rockchip: usbdp: Drop DP HPD handling Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 18/36] phy: rockchip: usbdp: Rename mode_change to phy_needs_reinit Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 19/36] phy: rockchip: usbdp: Re-init the PHY on orientation change Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:51   ` sashiko-bot
2026-07-03 23:51     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 20/36] phy: rockchip: usbdp: Factor out lane_mux_sel setup Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:51   ` sashiko-bot
2026-07-03 23:51     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 21/36] phy: rockchip: usbdp: Properly handle TYPEC_STATE_SAFE and TYPEC_STATE_USB Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 22/36] phy: rockchip: usbdp: Use guard functions for mutex Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 23/36] phy: rockchip: usbdp: Clear USB status on PHY exit Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:49   ` sashiko-bot
2026-07-03 23:49     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 24/36] phy: rockchip: usbdp: Hold mutex in DP PHY configure Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 25/36] phy: rockchip: usbdp: Add some extra debug messages Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 26/36] phy: rockchip: usbdp: Avoid xHCI SErrors Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 27/36] phy: rockchip: usbdp: Handle rk_udphy_reset_deassert errors Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 28/36] phy: rockchip: usbdp: Only enable USB3 when not in high-speed mode Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 29/36] phy: core: add notifier infrastructure Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 30/36] usb: dwc3: core: support PHY reset notifications Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:59   ` sashiko-bot
2026-07-03 23:59     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 31/36] phy: rockchip: usbdp: Add phy reset notification support Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 32/36] phy: rockchip: usbdp: Drop -EPROBE_DEFER hack Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-04  0:12   ` sashiko-bot
2026-07-04  0:12     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 33/36] phy: rockchip: usbdp: Rename mode to hw_mode Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 34/36] phy: rockchip: usbdp: Simplify power state handling Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 23:58   ` sashiko-bot
2026-07-03 23:58     ` sashiko-bot
2026-07-03 18:13 ` [PATCH v10 35/36] phy: rockchip: usbdp: Re-init PHY on mux change Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13 ` [PATCH v10 36/36] phy: rockchip: usbdp: Add USB-C state without DP enabled Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-03 18:13   ` Sebastian Reichel
2026-07-04  0:01   ` sashiko-bot
2026-07-04  0:01     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703234222.7ECFB1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.