From: Tom Rini <trini@konsulko.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: Peter Robinson <pbrobinson@gmail.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
u-boot@lists.denx.de,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Stefano Babic <sbabic@nabladev.com>,
Fabio Estevam <festevam@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] imx93_frdm: Add OP-TEE device tree node
Date: Mon, 6 Jul 2026 08:59:06 -0600 [thread overview]
Message-ID: <20260706145906.GW749385@bill-the-cat> (raw)
In-Reply-To: <DJRKOYKA0DDQ.PI5Q86TGLP22@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2481 bytes --]
On Mon, Jul 06, 2026 at 04:54:17PM +0200, Mathieu Dubois-Briand wrote:
> Hi,
>
> On Mon Jul 6, 2026 at 4:14 PM CEST, Peter Robinson wrote:
> > On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand
> > <mathieu.dubois-briand@bootlin.com> wrote:
> >>
> >> Add missing firmware/optee node, so is can be both used and copied into
> >> Linux device tree by optee_copy_firmware_node(). This is consistent with
> >> other i.MX93 boards.
> >
> > Shouldn't this be going to the upstream Linux DT at which point get it
> > when we resync?
>
> I don't think it should. Or maybe it should, but then we are doing wrong
> things for other boards, particularly for the i.MX family.
>
> We have this node in the -u-boot.dtsi file for various other boards:
>
> git grep "linaro,optee-tz" -- '*-u-boot.dtsi'
> arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz";
> arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz";
Since I assume this would still pass validation in the Linux kernel,
yes, it looks like a lot of platforms are doing it wrong here and should
be pushing this upstream. Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-06 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:34 [PATCH] imx93_frdm: Add OP-TEE device tree node Mathieu Dubois-Briand
2026-07-06 14:14 ` Peter Robinson
2026-07-06 14:54 ` Mathieu Dubois-Briand
2026-07-06 14:59 ` Tom Rini [this message]
2026-07-06 15:37 ` Mathieu Dubois-Briand
2026-07-06 15:54 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706145906.GW749385@bill-the-cat \
--to=trini@konsulko.com \
--cc=festevam@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=sbabic@nabladev.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.