Re: [PATCH] imx93_frdm: Add OP-TEE device tree node

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Mon Jul 6, 2026 at 4:59 PM CEST, Tom Rini wrote:
> On Mon, Jul 06, 2026 at 04:54:17PM +0200, Mathieu Dubois-Briand wrote:
>> Hi,
>> 
>> On Mon Jul 6, 2026 at 4:14 PM CEST, Peter Robinson wrote:
>> > On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand
>> > <mathieu.dubois-briand@bootlin.com> wrote:
>> >>
>> >> Add missing firmware/optee node, so is can be both used and copied into
>> >> Linux device tree by optee_copy_firmware_node(). This is consistent with
>> >> other i.MX93 boards.
>> >
>> > Shouldn't this be going to the upstream Linux DT at which point get it
>> > when we resync?
>> 
>> I don't think it should. Or maybe it should, but then we are doing wrong
>> things for other boards, particularly for the i.MX family.
>> 
>> We have this node in the -u-boot.dtsi file for various other boards:
>> 
>> git grep "linaro,optee-tz" -- '*-u-boot.dtsi'
>> arch/arm/dts/imx8mm-u-boot.dtsi:                        compatible = "linaro,optee-tz";
>> arch/arm/dts/imx8mn-u-boot.dtsi:                        compatible = "linaro,optee-tz";
>> arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi:                  compatible = "linaro,optee-tz";
>> arch/arm/dts/imx8mp-navqp-u-boot.dtsi:                  compatible = "linaro,optee-tz";
>> arch/arm/dts/imx8mp-u-boot.dtsi:                        compatible = "linaro,optee-tz";
>> arch/arm/dts/imx91-11x11-evk-u-boot.dtsi:                       compatible = "linaro,optee-tz";
>> arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi:                      compatible = "linaro,optee-tz";
>> arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi:                        compatible = "linaro,optee-tz";
>> arch/arm/dts/imx93-11x11-evk-u-boot.dtsi:                       compatible = "linaro,optee-tz";
>> arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi:                      compatible = "linaro,optee-tz";
>> arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi:                 compatible = "linaro,optee-tz";
>> arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi:                        compatible = "linaro,optee-tz";
>> arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi:                        compatible = "linaro,optee-tz";
>> arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi:                       compatible = "linaro,optee-tz";
>> arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi:                       compatible = "linaro,optee-tz";
>
> Since I assume this would still pass validation in the Linux kernel,
> yes, it looks like a lot of platforms are doing it wrong here and should
> be pushing this upstream. Thanks.

Ok, so I suspect I should instead submit a similar patch against the
Kernel.

Should I try to add something similar for other i.MX boards and stm32
boards at the same time? So they could later be removed from u-boot.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com