All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: rppt@kernel.org, Thomas Gleixner <tglx@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-mm@kvack.org, Sang-Heon Jeon <ekffu200098@gmail.com>,
	Ard Biesheuvel <ardb@kernel.org>, Chris Zankel <chris@zankel.net>,
	"H. Peter Anvin" <hpa@zytor.com>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	linux-kernel@vger.kernel.org,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Rich Felker <dalias@libc.org>,
	x86@kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH v2 1/5] x86/setup: remove unreachable memblock_reserve() return value check
Date: Tue,  7 Jul 2026 01:37:49 +0900	[thread overview]
Message-ID: <20260706163753.193875-2-ekffu200098@gmail.com> (raw)
In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com>

trim_snb_memory() runs from early_reserve_memory() in setup_arch(), before
e820__memblock_setup() calls memblock_allow_resize(). At that point
memblock_reserve() either succeeds or panics, never returning an error.

Therefore the return value check is unreachable, so remove it and the
related logic.

No functional change.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 arch/x86/kernel/setup.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 46882ce79c3a..f9395bc632ca 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -742,11 +742,8 @@ static void __init trim_snb_memory(void)
 	 * setup_arch(), so there is no need to reserve it here.
 	 */
 
-	for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
-		if (memblock_reserve(bad_pages[i], PAGE_SIZE))
-			printk(KERN_WARNING "failed to reserve 0x%08lx\n",
-			       bad_pages[i]);
-	}
+	for (i = 0; i < ARRAY_SIZE(bad_pages); i++)
+		memblock_reserve(bad_pages[i], PAGE_SIZE);
 }
 
 static void __init trim_bios_range(void)
-- 
2.43.0


  reply	other threads:[~2026-07-06 16:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 16:37 [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot Sang-Heon Jeon
2026-07-06 16:37 ` Sang-Heon Jeon [this message]
2026-07-06 16:37 ` [PATCH v2 2/5] sh: remove unreachable memblock_reserve() return value check Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 3/5] powerpc/fadump: remove unreachable memblock_reserve() return value checks Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 4/5] xtensa: " Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 5/5] Revert "tpm: do not ignore memblock_reserve return value" Sang-Heon Jeon
2026-07-07  6:17 ` [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot Mike Rapoport
2026-07-07 13:24   ` Sang-Heon Jeon
2026-07-07 13:40     ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260706163753.193875-2-ekffu200098@gmail.com \
    --to=ekffu200098@gmail.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=chris@zankel.net \
    --cc=dalias@libc.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hpa@zytor.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maddy@linux.ibm.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=rppt@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.