From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: rppt@kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-mm@kvack.org, Sang-Heon Jeon <ekffu200098@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
Chris Zankel <chris@zankel.net>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Thomas Gleixner <tglx@kernel.org>
Subject: [PATCH v2 2/5] sh: remove unreachable memblock_reserve() return value check
Date: Tue, 7 Jul 2026 01:37:50 +0900 [thread overview]
Message-ID: <20260706163753.193875-3-ekffu200098@gmail.com> (raw)
In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com>
reserve_crashkernel() runs from early_reserve_mem() in paging_init(),
before the same function calls memblock_allow_resize(). At that point
memblock_reserve() either succeeds or panics, never returning an error.
Therefore the return value check is unreachable, so remove it and the
related logic.
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
arch/sh/kernel/machine_kexec.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/sh/kernel/machine_kexec.c b/arch/sh/kernel/machine_kexec.c
index 37073ca1e0ad..ba9c412f14d9 100644
--- a/arch/sh/kernel/machine_kexec.c
+++ b/arch/sh/kernel/machine_kexec.c
@@ -165,12 +165,7 @@ void __init reserve_crashkernel(void)
goto disable;
}
} else {
- ret = memblock_reserve(crashk_res.start, crash_size);
- if (unlikely(ret < 0)) {
- pr_err("crashkernel reservation failed - "
- "memory is in use\n");
- goto disable;
- }
+ memblock_reserve(crashk_res.start, crash_size);
}
crashk_res.end = crashk_res.start + crash_size - 1;
--
2.43.0
next prev parent reply other threads:[~2026-07-06 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 16:37 [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 1/5] x86/setup: remove unreachable memblock_reserve() return value check Sang-Heon Jeon
2026-07-06 16:37 ` Sang-Heon Jeon [this message]
2026-07-06 16:37 ` [PATCH v2 3/5] powerpc/fadump: remove unreachable memblock_reserve() return value checks Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 4/5] xtensa: " Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 5/5] Revert "tpm: do not ignore memblock_reserve return value" Sang-Heon Jeon
2026-07-07 6:17 ` [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot Mike Rapoport
2026-07-07 13:24 ` Sang-Heon Jeon
2026-07-07 13:40 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706163753.193875-3-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.