Re: [PATCH v2 6/7] KVM: x86: Move supported EFER bits to kvm_caps

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Leftover function declarations for `kvm_enable_efer_bits()` and `kvm_disable_efer_bits()` in `arch/x86/kvm/msrs.h` after their definitions were removed.
--

commit eef68f2b444ee82f826a87d9dc12393124877c19
Author: Yosry Ahmed <yosry@kernel.org>

KVM: x86: Move supported EFER bits to kvm_caps

This commit moves the supported EFER bits into kvm_caps.supported_efer_bits 
to allow them to be recomputed during vendor initialization. It also removes 
the kvm_enable_efer_bits() and kvm_disable_efer_bits() helpers in favor of 
open-coding the updates directly to kvm_caps.

> diff --git a/arch/x86/kvm/msrs.c b/arch/x86/kvm/msrs.c
> index 10669c5418da3..66fa7140d65d9 100644
> --- a/arch/x86/kvm/msrs.c
> +++ b/arch/x86/kvm/msrs.c
[ ... ]
> @@ -650,18 +647,6 @@ static int set_efer(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>  	return 0;
>  }
>  
> -void kvm_enable_efer_bits(u64 mask)
> -{
> -	efer_supported_bits |= mask;
> -}
> -EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_enable_efer_bits);
> -
> -void kvm_disable_efer_bits(u64 mask)
> -{
> -	efer_supported_bits &= ~mask;
> -}
> -EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_disable_efer_bits);
> -

[Severity: Low]
This isn't a bug, but did this commit leave dangling function declarations for
kvm_enable_efer_bits() and kvm_disable_efer_bits() in arch/x86/kvm/msrs.h?

It appears the prototypes were not removed from the header file when these
implementations were deleted here.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706195413.1966458-1-yosry@kernel.org?part=6