Re: [PATCH v2 6/7] KVM: x86: Move supported EFER bits to kvm_caps

[Yosry Ahmed <yosry@kernel.org>]

On Mon, Jul 06, 2026 at 08:05:33PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Leftover function declarations for `kvm_enable_efer_bits()` and `kvm_disable_efer_bits()` in `arch/x86/kvm/msrs.h` after their definitions were removed.
> --
> 
> commit eef68f2b444ee82f826a87d9dc12393124877c19
> Author: Yosry Ahmed <yosry@kernel.org>
> 
> KVM: x86: Move supported EFER bits to kvm_caps
> 
> This commit moves the supported EFER bits into kvm_caps.supported_efer_bits 
> to allow them to be recomputed during vendor initialization. It also removes 
> the kvm_enable_efer_bits() and kvm_disable_efer_bits() helpers in favor of 
> open-coding the updates directly to kvm_caps.
> 
> > diff --git a/arch/x86/kvm/msrs.c b/arch/x86/kvm/msrs.c
> > index 10669c5418da3..66fa7140d65d9 100644
> > --- a/arch/x86/kvm/msrs.c
> > +++ b/arch/x86/kvm/msrs.c
> [ ... ]
> > @@ -650,18 +647,6 @@ static int set_efer(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> >  	return 0;
> >  }
> >  
> > -void kvm_enable_efer_bits(u64 mask)
> > -{
> > -	efer_supported_bits |= mask;
> > -}
> > -EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_enable_efer_bits);
> > -
> > -void kvm_disable_efer_bits(u64 mask)
> > -{
> > -	efer_supported_bits &= ~mask;
> > -}
> > -EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_disable_efer_bits);
> > -
> 
> [Severity: Low]
> This isn't a bug, but did this commit leave dangling function declarations for
> kvm_enable_efer_bits() and kvm_disable_efer_bits() in arch/x86/kvm/msrs.h?
> 
> It appears the prototypes were not removed from the header file when these
> implementations were deleted here.

Yeah, this needs to be folded in:

diff --git a/arch/x86/kvm/msrs.h b/arch/x86/kvm/msrs.h
index 89f10447cdddf..4cb9ca8bff979 100644
--- a/arch/x86/kvm/msrs.h
+++ b/arch/x86/kvm/msrs.h
@@ -58,8 +58,6 @@ int kvm_get_set_one_reg(struct kvm_vcpu *vcpu, unsigned int ioctl,
 int kvm_get_reg_list(struct kvm_vcpu *vcpu,
                     struct kvm_reg_list __user *user_list);

-void kvm_enable_efer_bits(u64);
-void kvm_disable_efer_bits(u64);
 bool kvm_valid_efer(struct kvm_vcpu *vcpu, u64 efer);
 int kvm_emulate_msr_read(struct kvm_vcpu *vcpu, u32 index, u64 *data);
 int kvm_emulate_msr_write(struct kvm_vcpu *vcpu, u32 index, u64 data);