All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Eugene Mavick <mavick4022@gmail.com>
Cc: hansg@kernel.org, straube.linux@gmail.com, nikolayof23@gmail.com,
	khomenkov@mailbox.org, william.hansen.baird@gmail.com,
	maxwell2119@163.com, dikshakdevgan@gmail.com,
	arthur.stupa@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: fix line length warning
Date: Tue, 7 Jul 2026 13:00:25 +0200	[thread overview]
Message-ID: <2026070709-janitor-shuffling-c263@gregkh> (raw)
In-Reply-To: <20260601093757.612130-2-mavick4022@gmail.com>

On Mon, Jun 01, 2026 at 05:37:56PM +0800, Eugene Mavick wrote:
> Split comment exceeding 100 columns to improve readability and clear
> checkpatch warning
> 
> Signed-off-by: Eugene Mavick <mavick4022@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> index a1b7fe843979..02f8564d32a7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> @@ -222,7 +222,8 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
>  
>  	/*  Commented by Albert 2009/08/13 */
>  	/*  For the SMC router, the sequence number of first packet of WPS handshake will be 0. */
> -	/*  In this case, this packet will be dropped by recv_decache function if we use the 0x00 as the default value for tid_rxseq variable. */
> +	/*  This packet will be dropped by recv_decache function */
> +	/*  if we use the 0x00 as the default value for tid_rxseq variable. */
>  	/*  So, we initialize the tid_rxseq variable as the 0xffff. */

Why not just turn this into a proper multi-line comment block?

thanks,

greg k-h

  reply	other threads:[~2026-07-07 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  9:37 [PATCH 0/2] staging: rtl8723bs: rtw_sta_mgt cleanup series Eugene Mavick
2026-06-01  9:37 ` [PATCH 1/2] staging: rtl8723bs: fix line length warning Eugene Mavick
2026-07-07 11:00   ` Greg KH [this message]
2026-06-01  9:37 ` [PATCH 2/2] staging: rtl8723bs: fix alignment Eugene Mavick
2026-07-12  8:35 ` [PATCH 0/2] staging: rtl8723bs: rtw_sta_mgt cleanup series Eugene Mavick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070709-janitor-shuffling-c263@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arthur.stupa@gmail.com \
    --cc=dikshakdevgan@gmail.com \
    --cc=hansg@kernel.org \
    --cc=khomenkov@mailbox.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mavick4022@gmail.com \
    --cc=maxwell2119@163.com \
    --cc=nikolayof23@gmail.com \
    --cc=straube.linux@gmail.com \
    --cc=william.hansen.baird@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.