[PATCH 0/2] staging: rtl8723bs: rtw_sta_mgt cleanup series

[PATCH 0/2] staging: rtl8723bs: rtw_sta_mgt cleanup series

[Eugene Mavick]

Fix line length and indentation issues in core/rtw_sta_mgt.c

Eugene Mavick (2):
  staging: rtl8723bs: fix line length warning
  staging: rtl8723bs: fix alignment

 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.51.2

[PATCH 1/2] staging: rtl8723bs: fix line length warning

[Eugene Mavick]

Split comment exceeding 100 columns to improve readability and clear
checkpatch warning

Signed-off-by: Eugene Mavick <mavick4022@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index a1b7fe843979..02f8564d32a7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -222,7 +222,8 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
 
 	/*  Commented by Albert 2009/08/13 */
 	/*  For the SMC router, the sequence number of first packet of WPS handshake will be 0. */
-	/*  In this case, this packet will be dropped by recv_decache function if we use the 0x00 as the default value for tid_rxseq variable. */
+	/*  This packet will be dropped by recv_decache function */
+	/*  if we use the 0x00 as the default value for tid_rxseq variable. */
 	/*  So, we initialize the tid_rxseq variable as the 0xffff. */
 
 	for (i = 0; i < 16; i++)
-- 
2.51.2

[PATCH 2/2] staging: rtl8723bs: fix alignment

[Eugene Mavick]

Fix alignment to improve code readability and clear checkpatch warning:
CHECK: Alignment should match open parenthesis

Signed-off-by: Eugene Mavick <mavick4022@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index 02f8564d32a7..e534045dd467 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -249,7 +249,7 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
 
 		/* init recv timer */
 		timer_setup(&preorder_ctrl->reordering_ctrl_timer,
-				rtw_reordering_ctrl_timeout_handler, 0);
+			    rtw_reordering_ctrl_timeout_handler, 0);
 	}
 
 	/* init for DM */
-- 
2.51.2

Re: [PATCH 1/2] staging: rtl8723bs: fix line length warning

[Greg KH]

On Mon, Jun 01, 2026 at 05:37:56PM +0800, Eugene Mavick wrote:
> Split comment exceeding 100 columns to improve readability and clear
> checkpatch warning
> 
> Signed-off-by: Eugene Mavick <mavick4022@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> index a1b7fe843979..02f8564d32a7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> @@ -222,7 +222,8 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
>  
>  	/*  Commented by Albert 2009/08/13 */
>  	/*  For the SMC router, the sequence number of first packet of WPS handshake will be 0. */
> -	/*  In this case, this packet will be dropped by recv_decache function if we use the 0x00 as the default value for tid_rxseq variable. */
> +	/*  This packet will be dropped by recv_decache function */
> +	/*  if we use the 0x00 as the default value for tid_rxseq variable. */
>  	/*  So, we initialize the tid_rxseq variable as the 0xffff. */

Why not just turn this into a proper multi-line comment block?

thanks,

greg k-h

Re: [PATCH 0/2] staging: rtl8723bs: rtw_sta_mgt cleanup series

[Eugene Mavick]

I would like to abandon this patch series.

Best regards,
Eugene Mavick