All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v8 03/39] drm/display: bridge_connector: Pass HDMI capabilities through caps struct
Date: Wed, 8 Jul 2026 08:46:50 +0200	[thread overview]
Message-ID: <20260708-bold-ruby-potoo-c6c949@houat> (raw)
In-Reply-To: <f74ffd53-5776-4fae-a6fe-eeace5c3fc5f@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

On Fri, Jul 03, 2026 at 10:55:09PM +0300, Cristian Ciocaltea wrote:
> On 7/3/26 5:19 PM, Dmitry Baryshkov wrote:
> > On Thu, Jul 02, 2026 at 05:46:16PM +0300, Cristian Ciocaltea wrote:
> >> Switch drm_bridge_connector_init() to
> >> drmm_connector_hdmi_init_with_caps(), collecting the bridge's HDMI
> >> properties into a stack drm_connector_hdmi_caps so future HDMI 2.x
> >> capabilities can be plumbed without growing the argument list.
> >>
> >> Introduce struct drm_bridge::supported_hdmi_ver to let bridges declare
> >> the HDMI specification version they are conformant with, and forward it
> >> to the connector layer through the new caps struct so HDMI 2.x features
> >> can be gated on real source capability rather than guesswork.
> > 
> > And it's left uninitialized by the bridges, which doesn't mean anything.
> > If you don't want to touch all bridge drivers in one commit, please
> > provide some migration path and hopefully get rid of it by the end of
> > the series. 
> 
> Sure, one question though: at the end of the migration, would it be fine to
> stick with drmm_connector_hdmi_init_with_caps() and just drop
> drmm_connector_hdmi_init()?  Otherwise I'll rename it back.

Absolutely, it doesn't make any sense to keep both variants.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <mripard@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v8 03/39] drm/display: bridge_connector: Pass HDMI capabilities through caps struct
Date: Wed, 8 Jul 2026 08:46:50 +0200	[thread overview]
Message-ID: <20260708-bold-ruby-potoo-c6c949@houat> (raw)
In-Reply-To: <f74ffd53-5776-4fae-a6fe-eeace5c3fc5f@collabora.com>


[-- Attachment #1.1: Type: text/plain, Size: 1289 bytes --]

On Fri, Jul 03, 2026 at 10:55:09PM +0300, Cristian Ciocaltea wrote:
> On 7/3/26 5:19 PM, Dmitry Baryshkov wrote:
> > On Thu, Jul 02, 2026 at 05:46:16PM +0300, Cristian Ciocaltea wrote:
> >> Switch drm_bridge_connector_init() to
> >> drmm_connector_hdmi_init_with_caps(), collecting the bridge's HDMI
> >> properties into a stack drm_connector_hdmi_caps so future HDMI 2.x
> >> capabilities can be plumbed without growing the argument list.
> >>
> >> Introduce struct drm_bridge::supported_hdmi_ver to let bridges declare
> >> the HDMI specification version they are conformant with, and forward it
> >> to the connector layer through the new caps struct so HDMI 2.x features
> >> can be gated on real source capability rather than guesswork.
> > 
> > And it's left uninitialized by the bridges, which doesn't mean anything.
> > If you don't want to touch all bridge drivers in one commit, please
> > provide some migration path and hopefully get rid of it by the end of
> > the series. 
> 
> Sure, one question though: at the end of the migration, would it be fine to
> stick with drmm_connector_hdmi_init_with_caps() and just drop
> drmm_connector_hdmi_init()?  Otherwise I'll rename it back.

Absolutely, it doesn't make any sense to keep both variants.

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-07-08  6:46 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 14:46 [PATCH v8 00/39] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-07-02 14:46 ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 01/39] video/hdmi: Introduce HDMI version enum Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-03 13:55   ` Dmitry Baryshkov
2026-07-03 13:55     ` Dmitry Baryshkov
2026-07-07 11:54   ` Maxime Ripard
2026-07-07 11:54     ` Maxime Ripard
2026-07-02 14:46 ` [PATCH v8 02/39] drm/connector: Add caps-based HDMI connector init helper Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:02   ` sashiko-bot
2026-07-03 14:05   ` Dmitry Baryshkov
2026-07-03 14:05     ` Dmitry Baryshkov
2026-07-03 19:31     ` Cristian Ciocaltea
2026-07-03 19:31       ` Cristian Ciocaltea
2026-07-07 16:10       ` Maxime Ripard
2026-07-07 16:10         ` Maxime Ripard
2026-07-08 10:11         ` Cristian Ciocaltea
2026-07-08 10:11           ` Cristian Ciocaltea
2026-07-10 10:27           ` Cristian Ciocaltea
2026-07-10 10:27             ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 03/39] drm/display: bridge_connector: Pass HDMI capabilities through caps struct Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-03 14:19   ` Dmitry Baryshkov
2026-07-03 14:19     ` Dmitry Baryshkov
2026-07-03 19:55     ` Cristian Ciocaltea
2026-07-03 19:55       ` Cristian Ciocaltea
2026-07-08  6:46       ` Maxime Ripard [this message]
2026-07-08  6:46         ` Maxime Ripard
2026-07-08 10:19         ` Cristian Ciocaltea
2026-07-08 10:19           ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 04/39] drm/connector: Add HDMI 2.0 scrambler infrastructure Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:04   ` sashiko-bot
2026-07-03 14:34   ` Dmitry Baryshkov
2026-07-03 14:34     ` Dmitry Baryshkov
2026-07-03 20:54     ` Cristian Ciocaltea
2026-07-03 20:54       ` Cristian Ciocaltea
2026-07-07 12:30       ` Maxime Ripard
2026-07-07 12:30         ` Maxime Ripard
2026-07-08 10:34         ` Cristian Ciocaltea
2026-07-08 10:34           ` Cristian Ciocaltea
2026-07-09 19:25       ` Cristian Ciocaltea
2026-07-09 19:25         ` Cristian Ciocaltea
2026-07-13  8:50         ` Maxime Ripard
2026-07-13  8:50           ` Maxime Ripard
2026-07-13 10:23           ` Cristian Ciocaltea
2026-07-13 10:23             ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 05/39] drm/display: scdc-helper: Add macro for connector-prefixed debug messages Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 06/39] drm/display: scdc-helper: Add helper to set SCDC version information Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-07 15:40   ` Maxime Ripard
2026-07-07 15:40     ` Maxime Ripard
2026-07-02 14:46 ` [PATCH v8 07/39] drm/display: hdmi: Add HDMI 2.0 scrambling management helpers Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:13   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 08/39] drm/display: hdmi: Advertise SCDC source version when scrambling Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-07 15:26   ` Maxime Ripard
2026-07-07 15:26     ` Maxime Ripard
2026-07-02 14:46 ` [PATCH v8 09/39] drm/display: hdmi-state-helper: Add fallback TMDS rate validation Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:05   ` sashiko-bot
2026-07-07 11:23   ` Maxime Ripard
2026-07-07 11:23     ` Maxime Ripard
2026-07-08 10:39     ` Cristian Ciocaltea
2026-07-08 10:39       ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 10/39] drm/display: hdmi-state-helper: Sync SCDC state on hotplug Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:04   ` sashiko-bot
2026-07-07 11:31   ` Maxime Ripard
2026-07-07 11:31     ` Maxime Ripard
2026-07-08 11:21     ` Cristian Ciocaltea
2026-07-08 11:21       ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 11/39] drm/display: hdmi-state-helper: Set HDMI scrambling requirement Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:14   ` sashiko-bot
2026-07-07 11:34   ` Maxime Ripard
2026-07-07 11:34     ` Maxime Ripard
2026-07-02 14:46 ` [PATCH v8 12/39] drm/bridge: Remove redundant error check in drm_bridge_helper_reset_crtc() Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:05   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 13/39] drm/bridge: Add bridge ops for source-side HDMI 2.0 scrambling Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 14/39] drm/display: bridge_connector: Use cached connector status in .get_modes() Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 15/39] drm/display: bridge_connector: Switch to .detect_ctx() connector helper Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 16/39] drm/display: bridge_connector: Wire up HDMI 2.0 scrambler callbacks Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 17/39] drm/bridge: dw-hdmi-qp: Rate limit i2c read error messages Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 18/39] drm/bridge: dw-hdmi-qp: Provide .{enable|disable}_hpd() PHY ops Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 19/39] drm/bridge: dw-hdmi-qp: Add HDMI 2.0 SCDC scrambling support Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:08   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 20/39] drm/bridge: dw-hdmi-qp: Provide dw_hdmi_qp_hpd_notify() helper Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:03   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 21/39] drm/rockchip: dw_hdmi_qp: Add missing newlines in dev_err_probe() messages Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 22/39] drm/rockchip: dw_hdmi_qp: Use local dev variable consistently in bind() Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:03   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 23/39] drm/rockchip: dw_hdmi_qp: Drop unnecessary #include Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 24/39] drm/rockchip: dw_hdmi_qp: Defer HPD IRQ enable until after connector setup Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:11   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 25/39] drm/rockchip: dw_hdmi_qp: Mask RK3576 HPD IRQ in io_init Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 26/39] drm/rockchip: dw_hdmi_qp: Implement .{enable|disable}_hpd() PHY ops Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:13   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 27/39] drm/rockchip: dw_hdmi_qp: Use dw_hdmi_qp_hpd_notify() for HPD reports Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:15   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 28/39] drm/bridge: dw-hdmi-qp: Drop unused .setup_hpd() phy op Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 29/39] drm/vc4: hdmi: Use common TMDS char rate constants Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 30/39] drm/vc4: hdmi: Switch to drm_hdmi_mode_needs_scrambling() Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-07 12:43   ` Maxime Ripard
2026-07-07 12:43     ` Maxime Ripard
2026-07-02 14:46 ` [PATCH v8 31/39] drm/vc4: hdmi: Convert to common SCDC scrambling infrastructure Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:16   ` sashiko-bot
2026-07-07 15:36   ` Maxime Ripard
2026-07-07 15:36     ` Maxime Ripard
2026-07-08 12:53     ` Cristian Ciocaltea
2026-07-08 12:53       ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 32/39] drm/tests: connector: Add HDMI caps-based init coverage Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:10   ` sashiko-bot
2026-07-02 14:46 ` [PATCH v8 33/39] drm/tests: connector: Add HDMI source-side scrambler coverage Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 34/39] drm/tests: hdmi_state_helper: Use drmm_connector_hdmi_init_with_caps() Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 35/39] drm/tests: hdmi_state_helper: Add max_tmds_char_rate fallback tests Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 36/39] drm/tests: edid: Add 4K@60Hz EDID with 600MHz TMDS Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 37/39] drm/tests: hdmi_state_helper: Cover source-side scrambling decision Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 38/39] drm/tests: edid: Fix conformity for 1080p+4K YUV420 200MHz EDID Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 14:46 ` [PATCH v8 39/39] drm/tests: edid: Fix conformity for 4K RGB/YUV 340MHz EDID Cristian Ciocaltea
2026-07-02 14:46   ` Cristian Ciocaltea
2026-07-02 15:31 ` [PATCH v8 00/39] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-07-02 15:31   ` Cristian Ciocaltea
2026-07-06  8:33 ` Maud Spierings
2026-07-06  8:33   ` Maud Spierings
2026-07-08 16:07   ` Cristian Ciocaltea
2026-07-08 16:07     ` Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708-bold-ruby-potoo-c6c949@houat \
    --to=mripard@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=andy.yan@rock-chips.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=daniels@collabora.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel-list@raspberrypi.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.