Re: [PATCH 3/3] riscv: dts: spacemit: k3: Add UFS support

From: Yixun Lan <dlan@kernel.org>
To: Jennifer Berringer <jberring@redhat.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@sandisk.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] riscv: dts: spacemit: k3: Add UFS support
Date: Wed, 8 Jul 2026 02:17:52 +0000	[thread overview]
Message-ID: <20260708021752-GKI35811@kernel.org> (raw)
In-Reply-To: <akkSL1nQ5UieqHNs@rhdev>

Hi Jennifer,

On 10:01 Sat 04 Jul     , Jennifer Berringer wrote:
> On Thu, Jul 02, 2026 at 02:31:37AM +0000, Yixun Lan wrote:
> > Add UFS Host Controller support for SpacemiT K3 SoC, and enable
> > it both on both Pico-ITX and CoM260-IFX boards.
> > 
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> >  arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts |  4 ++++
> >  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts   |  4 ++++
> >  arch/riscv/boot/dts/spacemit/k3.dtsi           | 13 +++++++++++++
> >  3 files changed, 21 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> > index 238bb03d0e9e..b37e1c7b03e3 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> > @@ -19,3 +19,7 @@ chosen {
> >  		stdout-path = "serial0:115200n8";
> >  	};
> >  };
> > +
> > +&ufshc {
> > +	status = "okay";
> > +};
> 
> I believe k3-com260.dtsi would be a more fitting file for this change.
> UFS is soldered on the underside of the compute module and not part of
> the carrier board.
> 
Right, I agree

> Because it is next to the microSD card slot, a picture showing both can
> be seen in section 5.12 (TF-Card Interface) of the PDF version of the K3
> CoM260 User Guide. That picture is notably not visible in the HTML
> version.
> 
> https://www.spacemit.com/community/document/info?lang=en&nodepath=hardware/eco/k3_com260/com260_user_guide.md
> 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > index b89c1521e664..f1560a5a9031 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > @@ -221,3 +221,7 @@ hub@1 {
> >  &usb2_phy {
> >  	status = "okay";
> >  };
> > +
> > +&ufshc {
> > +	status = "okay";
> > +};
> 
> Nit: if sorted by label, ufshc would be before usb2_host.
> 
Right, will sort in next version

-- 
Yixun Lan (dlan)