* [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC
2026-07-07 7:11 [PATCH v9 0/2] Enable sdhc inline crypto engine for kodiak and monaco Kuldeep Singh
@ 2026-07-07 7:11 ` Kuldeep Singh
2026-07-07 8:05 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Kuldeep Singh @ 2026-07-07 7:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Kuldeep Singh, linux-arm-msm, devicetree, linux-kernel,
Neeraj Soni
From: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Add the dedicated ICE node for monaco and reference it from the SDHC
controller via qcom,ice.
Also, define power-domains and clocks properties similar to the UFS
node.
Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Co-developed-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index 400c75437978..ffb13d61ee36 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -4864,6 +4864,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
supports-cqe;
dma-coherent;
+ qcom,ice = <&sdhc_ice>;
+
mmc-ddr-1_8v;
mmc-hs200-1_8v;
mmc-hs400-1_8v;
@@ -4896,6 +4898,17 @@ opp-384000000 {
};
};
+ sdhc_ice: crypto@87c8000 {
+ compatible = "qcom,qcs8300-inline-crypto-engine",
+ "qcom,inline-crypto-engine";
+ reg = <0x0 0x087c8000 0x0 0x18000>;
+ clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>,
+ <&gcc GCC_SDCC1_AHB_CLK>;
+ clock-names = "core",
+ "iface";
+ power-domains = <&rpmhpd RPMHPD_CX>;
+ };
+
usb_1_hsphy: phy@8904000 {
compatible = "qcom,qcs8300-usb-hs-phy",
"qcom,usb-snps-hs-7nm-phy";
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC
2026-07-07 7:11 ` [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC Kuldeep Singh
@ 2026-07-07 8:05 ` sashiko-bot
0 siblings, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-07 8:05 UTC (permalink / raw)
To: Kuldeep Singh; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `qcom,ice` property is used in the SDHC node, but it is not documented in the `qcom,sdhci-msm.yaml` binding schema.
--
--- Patch [2]: [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC ---
commit f78e20bb65841709496ac90470aafd18132c8970
Author: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
arm64: dts: qcom: monaco: enable inline crypto engine for SDHC
This patch adds a dedicated Inline Crypto Engine (ICE) node for the
monaco platform. It references the new node from the SDHC controller
using the qcom,ice property and defines power-domains and clocks.
> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> index 400c754379783..ffb13d61ee36d 100644
> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi
> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
> @@ -4864,6 +4864,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> supports-cqe;
> dma-coherent;
>
> + qcom,ice = <&sdhc_ice>;
[Severity: Low]
Will this undocumented qcom,ice property cause dtbs_check warnings?
Looking at the qcom,sdhci-msm.yaml binding schema, the qcom,ice property
doesn't appear to be defined. Since the schema enforces
unevaluatedProperties: false, adding this property here might trigger
validation warnings during the build.
Should this property be added to the devicetree bindings first?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-ice_emmc_support-v9-0-701c86f3c25b@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC
@ 2026-07-08 9:08 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-07-08 9:08 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260707-ice_emmc_support-v9-2-701c86f3c25b@oss.qualcomm.com>
References: <20260707-ice_emmc_support-v9-2-701c86f3c25b@oss.qualcomm.com>
TO: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
TO: Bjorn Andersson <andersson@kernel.org>
TO: Konrad Dybcio <konradybcio@kernel.org>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
CC: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
CC: linux-arm-msm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Hi Neeraj,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 8e9685d3c41c35dd1b37df70d854137abcb2fbac]
url: https://github.com/intel-lab-lkp/linux/commits/Kuldeep-Singh/arm64-dts-qcom-kodiak-enable-inline-crypto-engine-for-SDHC/20260707-152221
base: 8e9685d3c41c35dd1b37df70d854137abcb2fbac
patch link: https://lore.kernel.org/r/20260707-ice_emmc_support-v9-2-701c86f3c25b%40oss.qualcomm.com
patch subject: [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC
:::::: branch date: 26 hours ago
:::::: commit date: 26 hours ago
config: arm64-randconfig-2055-20260707 (https://download.01.org/0day-ci/archive/20260708/202607081057.76DXsZTP-lkp@intel.com/config)
compiler: clang version 21.1.6 (https://github.com/llvm/llvm-project a832a5222e489298337fbb5876f8dcaf072c5cca)
dtschema: 2026.7.dev1+g2203c1720
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260708/202607081057.76DXsZTP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202607081057.76DXsZTP-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd-pro.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-idp.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-idp2.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
arch/arm64/boot/dts/qcom/kodiak.dtsi:5498.26-5573.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: mmc@7c4000 (qcom,sc7280-sdhci): Unevaluated properties are not allowed ('qcom,ice' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/qcom,sdhci-msm.yaml
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-08 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-08 9:08 [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-07-07 7:11 [PATCH v9 0/2] Enable sdhc inline crypto engine for kodiak and monaco Kuldeep Singh
2026-07-07 7:11 ` [PATCH v9 2/2] arm64: dts: qcom: monaco: enable inline crypto engine for SDHC Kuldeep Singh
2026-07-07 8:05 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.