Re: [PATCH v8 4/4] arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree aliases for the SPI FIU controllers `fiu1` and `fiu3` are incorrectly swapped.
--

--- Patch [4]: [PATCH v8 4/4] arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes ---
commit 58cedbdc9355efee860c7d605886caa4e600ea8c
Author: Tomer Maimon <tmaimon77@gmail.com>

arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes

Enable peripheral support for the NPCM845 evaluation board by wiring up
the SoC controller nodes to the board design. Add board aliases, GPIO-backed
MDIO buses, flash partitions, and enable various peripheral interfaces.

> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> index 5edf5d13342da..7717c3a8f76d2 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> @@ -10,6 +10,42 @@ / {
>  
>  	aliases {
>  		serial0 = &serial0;
> +		ethernet1 = &gmac1;
> +		ethernet2 = &gmac2;
> +		ethernet3 = &gmac3;
> +		mdio-gpio0 = &mdio0;
> +		mdio-gpio1 = &mdio1;
> +		fiu0 = &fiu0;
> +		fiu1 = &fiu3;
> +		fiu2 = &fiux;
> +		fiu3 = &fiu1;

[Severity: Medium]
Are the aliases for the SPI FIU controllers intentionally swapped here?

Mapping fiu1 to &fiu3 and fiu3 to &fiu1 assigns logical SPI bus spi1 to the
&fiu3 hardware controller and spi3 to the &fiu1 hardware controller.

This contradicts the partition labels defined further down in this patch for
these nodes, which expect spi1 to be fiu1 and spi3 to be fiu3:

&fiu1 {
        ...
        partition@0 {
                label = "spi1-system1";

&fiu3 {
        ...
        partition@0 {
                label = "spi3-system1";

Could this mismatch break userspace and boot scripts relying on the logical
device IDs to find system partitions?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708165929.2233934-1-tmaimon77@gmail.com?part=4