[PATCH 0/3] doc: CONTRIBUTE: hint at different kinds of contribution

[PATCH 0/3] doc: CONTRIBUTE: hint at different kinds of contribution

[Quentin Schulz]

We could benefit from having more reviewers, as well as more tests and
documentation, so let's make that explicit.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
Quentin Schulz (3):
      doc: CONTRIBUTE: use internal link instead of hardcoded external URL
      doc: CONTRIBUTE: tell people reviewing *is* contributing
      doc: CONTRIBUTE: explicitly list tests and documentation as welcome contributions

 doc/CONTRIBUTE.rst | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)
---
base-commit: ee5d46b45ec0c63f8f9dd1e816e0dac3452ccc3d
change-id: 20260708-other-contrib-31a8bb01c67c

Best regards,
--  
Quentin Schulz <quentin.schulz@cherry.de>

[PATCH 1/3] doc: CONTRIBUTE: use internal link instead of hardcoded external URL

[Quentin Schulz]

From: Quentin Schulz <quentin.schulz@cherry.de>

This way we don't need to make sure this link still points to something
that exists, as Sphinx will enforce it at build time. It also has the
added benefit that if someone builds the docs they will point at their
docs (though that is debatable whether that's useful, but at least you
stay on the same website).

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 doc/CONTRIBUTE.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/CONTRIBUTE.rst b/doc/CONTRIBUTE.rst
index a6e1cd1fb68a..0179d55dbcc0 100644
--- a/doc/CONTRIBUTE.rst
+++ b/doc/CONTRIBUTE.rst
@@ -21,8 +21,7 @@ Repository
 
 The official U-Boot repository is located at https://source.denx.de/u-boot/u-boot
 
-Further more detailed documentation can be found at the following link:
-https://docs.u-boot-project.org/en/latest/index.html
+Further more detailed documentation can be found at the following link: :doc:`/index`.
 
 Contributions
 -------------

-- 
2.55.0

Re: [PATCH 1/3] doc: CONTRIBUTE: use internal link instead of hardcoded external URL

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On Wed, Jul 08, 2026 at 07:21:13PM +0200, Quentin Schulz wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> This way we don't need to make sure this link still points to something
> that exists, as Sphinx will enforce it at build time. It also has the
> added benefit that if someone builds the docs they will point at their
> docs (though that is debatable whether that's useful, but at least you
> stay on the same website).
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/3] doc: CONTRIBUTE: use internal link instead of hardcoded external URL

[Simon Glass]

On 2026-07-08T17:21:12, Quentin Schulz <foss+uboot@0leil.net> wrote:
> doc: CONTRIBUTE: use internal link instead of hardcoded external URL
>
> This way we don't need to make sure this link still points to something
> that exists, as Sphinx will enforce it at build time. It also has the
> added benefit that if someone builds the docs they will point at their
> docs (though that is debatable whether that's useful, but at least you
> stay on the same website).
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> doc/CONTRIBUTE.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH 2/3] doc: CONTRIBUTE: tell people reviewing *is* contributing

[Quentin Schulz]

From: Quentin Schulz <quentin.schulz@cherry.de>

We are "a bit" struggling with reviewing things and it's most of the
time maintainers or long time contributors reviewing patches on the
mailing list.

Hint that reviewing is also contributing to the project and that even if
you don't feel you're an expert, your review is still welcome and can
help us catch bugs before they are merged.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 doc/CONTRIBUTE.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/doc/CONTRIBUTE.rst b/doc/CONTRIBUTE.rst
index 0179d55dbcc0..cd9a381a3eb8 100644
--- a/doc/CONTRIBUTE.rst
+++ b/doc/CONTRIBUTE.rst
@@ -38,6 +38,15 @@ script. Please don't send patches as attachments, and ensure corporate mail
 systems don't reformat patches, append disclaimers or other unnecessary notes.
 The b4 tool automates a number of components mentioned above.
 
+Code is not the only thing you can contribute to the project. As most
+open-source projects, the U-Boot project suffers from a lack of reviewers.
+Consider spending some time reading patches on `the mailing list archive
+<https://lists.denx.de/pipermail/u-boot/>`_ and providing feedback to
+contributors when something could be improved or if you have questions. Contrary
+to what's most often believed, you do not need to be an expert to review patches
+and the project will benefit from people with different skillsets and experience
+looking at the same patches and each catch different bugs.
+
 Patch Series
 ------------
 

-- 
2.55.0

Re: [PATCH 2/3] doc: CONTRIBUTE: tell people reviewing *is* contributing

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

On Wed, Jul 08, 2026 at 07:21:14PM +0200, Quentin Schulz wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> We are "a bit" struggling with reviewing things and it's most of the
> time maintainers or long time contributors reviewing patches on the
> mailing list.
> 
> Hint that reviewing is also contributing to the project and that even if
> you don't feel you're an expert, your review is still welcome and can
> help us catch bugs before they are merged.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/3] doc: CONTRIBUTE: tell people reviewing *is* contributing

[Simon Glass]

Hi Quentin,

On 2026-07-08T17:21:12, Quentin Schulz <foss+uboot@0leil.net> wrote:
> doc: CONTRIBUTE: tell people reviewing *is* contributing
>
> We are "a bit" struggling with reviewing things and it's most of the
> time maintainers or long time contributors reviewing patches on the
> mailing list.
>
> Hint that reviewing is also contributing to the project and that even if
> you don't feel you're an expert, your review is still welcome and can
> help us catch bugs before they are merged.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> doc/CONTRIBUTE.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)

> diff --git a/doc/CONTRIBUTE.rst b/doc/CONTRIBUTE.rst
> @@ -38,6 +38,15 @@ script. Please don't send patches as attachments, and ensure corporate mail
> +Code is not the only thing you can contribute to the project. As most
> +open-source projects, the U-Boot project suffers from a lack of reviewers.

'As most open-source projects' doesn't parse - there's no verb for the
comparison to hang on. Maybe 'Like most open-source projects' or 'As
with most open-source projects'? What do you think?

Regards,
Simon

[PATCH 3/3] doc: CONTRIBUTE: explicitly list tests and documentation as welcome contributions

[Quentin Schulz]

From: Quentin Schulz <quentin.schulz@cherry.de>

We don't have too many people looking at those at the moment, so having
people getting into the project by adding tests or documentation is I
believe a good thing so let's encourage those specific contributions.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 doc/CONTRIBUTE.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/CONTRIBUTE.rst b/doc/CONTRIBUTE.rst
index cd9a381a3eb8..e8fa595ed4ab 100644
--- a/doc/CONTRIBUTE.rst
+++ b/doc/CONTRIBUTE.rst
@@ -47,6 +47,13 @@ to what's most often believed, you do not need to be an expert to review patches
 and the project will benefit from people with different skillsets and experience
 looking at the same patches and each catch different bugs.
 
+The project would also benefit from more :ref:`develop/index:testing`.
+
+New sections or updates to the documentation are most welcome, e.g.
+:ref:`usage/index:shell commands`. See :doc:`/develop/docstyle`.
+
+Thank you for your help!
+
 Patch Series
 ------------
 

-- 
2.55.0

Re: [PATCH 3/3] doc: CONTRIBUTE: explicitly list tests and documentation as welcome contributions

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On Wed, Jul 08, 2026 at 07:21:15PM +0200, Quentin Schulz wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> We don't have too many people looking at those at the moment, so having
> people getting into the project by adding tests or documentation is I
> believe a good thing so let's encourage those specific contributions.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 3/3] doc: CONTRIBUTE: explicitly list tests and documentation as welcome contributions

[Simon Glass]

On 2026-07-08T17:21:12, Quentin Schulz <foss+uboot@0leil.net> wrote:
> doc: CONTRIBUTE: explicitly list tests and documentation as welcome contributions
>
> We don't have too many people looking at those at the moment, so having
> people getting into the project by adding tests or documentation is I
> believe a good thing so let's encourage those specific contributions.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> doc/CONTRIBUTE.rst | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH 0/3] doc: CONTRIBUTE: hint at different kinds of contribution

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

On Wed, Jul 08, 2026 at 07:21:12PM +0200, Quentin Schulz wrote:

> We could benefit from having more reviewers, as well as more tests and
> documentation, so let's make that explicit.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

A good idea, thanks for doing this.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]