All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shubham Patil" <shubhamsanjay.patil@amd.com>
Cc: devicetree@vger.kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	robh@kernel.org, Frank.Li@kernel.org,
	linux-i3c@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support
Date: Thu, 09 Jul 2026 06:51:44 +0000	[thread overview]
Message-ID: <20260709065145.6DB071F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260709064233.1451482-2-shubhamsanjay.patil@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `interrupts` property is missing from the `required` list in the binding schema.
--

--- Patch [1]: [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support ---
commit dfcd0f962dd67901f67582456a8fe5271491789d
Author: Manikanta Guntupalli <manikanta.guntupalli@amd.com>

dt-bindings: i3c: Add AMD I3C master controller support

This commit adds device tree binding documentation for the AMD I3C master
controller version 1.0.

> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
> new file mode 100644
> index 0000000000000..2caa245a86568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml

[ ... ]

> +properties:
> +  compatible:
> +    const: xlnx,axi-i3c-1.0
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks

[Severity: Medium]
Should the interrupts property be included in this required list?

Since I3C master controllers fundamentally rely on interrupts for handling
asynchronous bus events like In-Band Interrupts (IBIs) and Dynamic Address
Assignment (DAA), a missing requirement allows incomplete device tree nodes
to pass YAML schema validation. Will this lead to driver probe or runtime
failures when the software attempts to acquire the missing IRQ?

> +
> +allOf:
> +  - $ref: i3c.yaml#

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709064233.1451482-1-shubhamsanjay.patil@amd.com?part=1

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Shubham Patil" <shubhamsanjay.patil@amd.com>
Cc: devicetree@vger.kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	robh@kernel.org, Frank.Li@kernel.org,
	linux-i3c@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support
Date: Thu, 09 Jul 2026 06:51:44 +0000	[thread overview]
Message-ID: <20260709065145.6DB071F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260709064233.1451482-2-shubhamsanjay.patil@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `interrupts` property is missing from the `required` list in the binding schema.
--

--- Patch [1]: [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support ---
commit dfcd0f962dd67901f67582456a8fe5271491789d
Author: Manikanta Guntupalli <manikanta.guntupalli@amd.com>

dt-bindings: i3c: Add AMD I3C master controller support

This commit adds device tree binding documentation for the AMD I3C master
controller version 1.0.

> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
> new file mode 100644
> index 0000000000000..2caa245a86568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml

[ ... ]

> +properties:
> +  compatible:
> +    const: xlnx,axi-i3c-1.0
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks

[Severity: Medium]
Should the interrupts property be included in this required list?

Since I3C master controllers fundamentally rely on interrupts for handling
asynchronous bus events like In-Band Interrupts (IBIs) and Dynamic Address
Assignment (DAA), a missing requirement allows incomplete device tree nodes
to pass YAML schema validation. Will this lead to driver probe or runtime
failures when the software attempts to acquire the missing IRQ?

> +
> +allOf:
> +  - $ref: i3c.yaml#

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709064233.1451482-1-shubhamsanjay.patil@amd.com?part=1

  reply	other threads:[~2026-07-09  6:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  6:42 [PATCH v10 0/2] Add AMD I3C master controller driver and bindings Shubham Patil
2026-07-09  6:42 ` Shubham Patil
2026-07-09  6:42 ` [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support Shubham Patil
2026-07-09  6:42   ` Shubham Patil
2026-07-09  6:51   ` sashiko-bot [this message]
2026-07-09  6:51     ` sashiko-bot
2026-07-13 16:38   ` Pandey, Radhey Shyam
2026-07-13 16:38     ` Pandey, Radhey Shyam
2026-07-09  6:42 ` [PATCH v10 2/2] i3c: master: Add driver for AMD AXI I3C master controller Shubham Patil
2026-07-09  6:42   ` Shubham Patil
2026-07-09  6:57   ` sashiko-bot
2026-07-09  6:57     ` sashiko-bot
2026-07-09 19:24   ` Frank Li
2026-07-09 19:24     ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709065145.6DB071F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shubhamsanjay.patil@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.