* [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 15:20 Pengpeng Hou
2026-07-09 17:21 ` Simon Horman
2026-07-12 15:43 ` Lino Sanfilippo
0 siblings, 2 replies; 3+ messages in thread
From: Pengpeng Hou @ 2026-07-04 15:20 UTC (permalink / raw)
To: Lino Sanfilippo, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Pengpeng Hou, netdev, linux-kernel
The driver has a match table for the pci bus wired into its driver
structure, but the table is not exported with MODULE_DEVICE_TABLE().
Add the missing MODULE_DEVICE_TABLE() entry so module alias information
is generated for automatic module loading.
This is a source-level fix. It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the driver registration structure, and the missing module alias
publication.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/net/ethernet/alacritech/slicoss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index c1949ca060ca..14b74c09233e 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -34,6 +34,7 @@ static const struct pci_device_id slic_id_tbl[] = {
PCI_DEVICE_ID_ALACRITECH_OASIS) },
{ 0 }
};
+MODULE_DEVICE_TABLE(pci, slic_id_tbl);
static const char slic_stats_strings[][ETH_GSTRING_LEN] = {
"rx_packets",
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE()
2026-07-04 15:20 [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-09 17:21 ` Simon Horman
2026-07-12 15:43 ` Lino Sanfilippo
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-07-09 17:21 UTC (permalink / raw)
To: Pengpeng Hou
Cc: Lino Sanfilippo, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
On Sat, Jul 04, 2026 at 11:20:53PM +0800, Pengpeng Hou wrote:
> The driver has a match table for the pci bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE()
2026-07-04 15:20 [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-09 17:21 ` Simon Horman
@ 2026-07-12 15:43 ` Lino Sanfilippo
1 sibling, 0 replies; 3+ messages in thread
From: Lino Sanfilippo @ 2026-07-12 15:43 UTC (permalink / raw)
To: Pengpeng Hou, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel
Hi,
On 04.07.26 17:20, Pengpeng Hou wrote:
> The driver has a match table for the pci bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index c1949ca060ca..14b74c09233e 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -34,6 +34,7 @@ static const struct pci_device_id slic_id_tbl[] = {
> PCI_DEVICE_ID_ALACRITECH_OASIS) },
> { 0 }
> };
> +MODULE_DEVICE_TABLE(pci, slic_id_tbl);
>
> static const char slic_stats_strings[][ETH_GSTRING_LEN] = {
> "rx_packets",
Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-12 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 15:20 [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-09 17:21 ` Simon Horman
2026-07-12 15:43 ` Lino Sanfilippo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.