All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Nick Li <nick.li@foursemi.com>,
	Herve Codina <herve.codina@bootlin.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Srinivas Kandagatla <srini@kernel.org>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Linus Walleij <linusw@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	u.kleine-koenig@baylibre.com, Zhang Yi <zhangyi@everest-semi.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Kees Cook <kees@kernel.org>, HyeongJun An <sammiee5311@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Qianfeng Rong <rongqianfeng@vivo.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 12/27] ASoC: codecs: max98095: Use guard() for mutex locks
Date: Fri, 10 Jul 2026 12:04:56 +0700	[thread overview]
Message-ID: <20260710050511.14439-10-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260710050511.14439-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/codecs/max98095.c | 35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)

diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c
index ced9bd4d94da..c47bfa2378b8 100644
--- a/sound/soc/codecs/max98095.c
+++ b/sound/soc/codecs/max98095.c
@@ -5,6 +5,7 @@
  * Copyright 2011 Maxim Integrated Products
  */
 
+#include <linux/cleanup.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/kernel.h>
@@ -1532,15 +1533,17 @@ static int max98095_put_eq_enum(struct snd_kcontrol *kcontrol,
 	regsave = snd_soc_component_read(component, M98095_088_CFG_LEVEL);
 	snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, 0);
 
-	mutex_lock(&max98095->lock);
-	snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, M98095_SEG);
-	m98095_eq_band(component, channel, 0, coef_set->band1);
-	m98095_eq_band(component, channel, 1, coef_set->band2);
-	m98095_eq_band(component, channel, 2, coef_set->band3);
-	m98095_eq_band(component, channel, 3, coef_set->band4);
-	m98095_eq_band(component, channel, 4, coef_set->band5);
-	snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, 0);
-	mutex_unlock(&max98095->lock);
+	scoped_guard(mutex, &max98095->lock) {
+		snd_soc_component_update_bits(component, M98095_00F_HOST_CFG,
+					      M98095_SEG, M98095_SEG);
+		m98095_eq_band(component, channel, 0, coef_set->band1);
+		m98095_eq_band(component, channel, 1, coef_set->band2);
+		m98095_eq_band(component, channel, 2, coef_set->band3);
+		m98095_eq_band(component, channel, 3, coef_set->band4);
+		m98095_eq_band(component, channel, 4, coef_set->band5);
+		snd_soc_component_update_bits(component, M98095_00F_HOST_CFG,
+					      M98095_SEG, 0);
+	}
 
 	/* Restore the original on/off state */
 	snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, regsave);
@@ -1683,12 +1686,14 @@ static int max98095_put_bq_enum(struct snd_kcontrol *kcontrol,
 	regsave = snd_soc_component_read(component, M98095_088_CFG_LEVEL);
 	snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, 0);
 
-	mutex_lock(&max98095->lock);
-	snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, M98095_SEG);
-	m98095_biquad_band(component, channel, 0, coef_set->band1);
-	m98095_biquad_band(component, channel, 1, coef_set->band2);
-	snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, 0);
-	mutex_unlock(&max98095->lock);
+	scoped_guard(mutex, &max98095->lock) {
+		snd_soc_component_update_bits(component, M98095_00F_HOST_CFG,
+					      M98095_SEG, M98095_SEG);
+		m98095_biquad_band(component, channel, 0, coef_set->band1);
+		m98095_biquad_band(component, channel, 1, coef_set->band2);
+		snd_soc_component_update_bits(component, M98095_00F_HOST_CFG,
+					      M98095_SEG, 0);
+	}
 
 	/* Restore the original on/off state */
 	snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, regsave);
-- 
2.43.0



  parent reply	other threads:[~2026-07-10  5:06 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  4:58 [PATCH v3 00/27] ASoC: codecs: Use guard() for mutex & spin locks - part 2 phucduc.bui
2026-07-09  4:58 ` [PATCH v3 01/27] ASoC: codecs: da7213: Use guard() for mutex locks phucduc.bui
2026-07-09  4:58 ` [PATCH v3 02/27] ASoC: codecs: da7219: " phucduc.bui
2026-07-09 17:17 ` [PATCH v3 00/27] ASoC: codecs: Use guard() for mutex & spin locks - part 2 Mark Brown
2026-07-10  2:05   ` Bui Duc Phuc
2026-07-10  5:04 ` [PATCH v3 03/27] ASoC: codecs: es8316: Use guard() for mutex locks phucduc.bui
2026-07-10  5:04   ` [PATCH v3 04/27] ASoC: codecs: es8326: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 05/27] ASoC: codecs: es9356: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 06/27] ASoC: codecs: fs210x: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 07/27] ASoC: codecs: hdac_hdmi: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 08/27] ASoC: codecs: hdmi-codec: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 09/27] ASoC: codecs: idt821034: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 10/27] ASoC: codecs: lpass-macro: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 11/27] ASoC: codecs: madera: " phucduc.bui
2026-07-10  5:04   ` phucduc.bui [this message]
2026-07-10  5:04   ` [PATCH v3 13/27] ASoC: codecs: mt6359-accdet: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 14/27] ASoC: codecs: pcm512x: " phucduc.bui
2026-07-10  5:04   ` [PATCH v3 15/27] ASoC: codecs: pcm6240: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 16/27] ASoC: codecs: peb2466: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 17/27] ASoC: codecs: rt5514-spi: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 18/27] ASoC: codecs: rt5645: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 19/27] ASoC: codecs: rt5665: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 20/27] ASoC: codecs: rt5668: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 21/27] ASoC: codecs: rt5677: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 22/27] ASoC: codecs: rt5682: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 23/27] ASoC: codecs: rt700: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 24/27] ASoC: codecs: rt711: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 25/27] ASoC: codecs: rt712: " phucduc.bui
2026-07-10 15:07     ` Mark Brown
2026-07-10 22:35       ` Bui Duc Phuc
2026-07-11  0:08         ` Bui Duc Phuc
2026-07-12 10:24           ` Bui Duc Phuc
2026-07-13  2:26             ` Bui Duc Phuc
2026-07-13  6:44               ` Bui Duc Phuc
2026-07-10  5:05   ` [PATCH v3 26/27] ASoC: codecs: rt721: " phucduc.bui
2026-07-10  5:05   ` [PATCH v3 27/27] ASoC: codecs: rt722: " phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710050511.14439-10-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=herve.codina@bootlin.com \
    --cc=kees@kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nick.li@foursemi.com \
    --cc=oder_chiou@realtek.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=rongqianfeng@vivo.com \
    --cc=sammiee5311@gmail.com \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=srini@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=zhangyi@everest-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.