From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Nick Li <nick.li@foursemi.com>,
Herve Codina <herve.codina@bootlin.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Srinivas Kandagatla <srini@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Oder Chiou <oder_chiou@realtek.com>,
Linus Walleij <linusw@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
u.kleine-koenig@baylibre.com, Zhang Yi <zhangyi@everest-semi.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Kees Cook <kees@kernel.org>, HyeongJun An <sammiee5311@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Qianfeng Rong <rongqianfeng@vivo.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 27/27] ASoC: codecs: rt722: Use guard() for mutex locks
Date: Fri, 10 Jul 2026 12:05:11 +0700 [thread overview]
Message-ID: <20260710050511.14439-25-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260710050511.14439-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/rt722-sdca-sdw.c | 29 ++++++++++++++++-------------
sound/soc/codecs/rt722-sdca.c | 4 ++--
2 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/sound/soc/codecs/rt722-sdca-sdw.c b/sound/soc/codecs/rt722-sdca-sdw.c
index e68aa0350a5b..db1aeea2ecb3 100644
--- a/sound/soc/codecs/rt722-sdca-sdw.c
+++ b/sound/soc/codecs/rt722-sdca-sdw.c
@@ -6,6 +6,7 @@
//
//
+#include <linux/cleanup.h>
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/module.h>
@@ -513,13 +514,13 @@ static int rt722_sdca_dev_system_suspend(struct device *dev)
* deferred work completes and before the parent disables
* interrupts on the link
*/
- mutex_lock(&rt722_sdca->disable_irq_lock);
- rt722_sdca->disable_irq = true;
- ret1 = sdw_update_no_pm(slave, SDW_SCP_SDCA_INTMASK1,
- SDW_SCP_SDCA_INTMASK_SDCA_0, 0);
- ret2 = sdw_update_no_pm(slave, SDW_SCP_SDCA_INTMASK2,
- SDW_SCP_SDCA_INTMASK_SDCA_8, 0);
- mutex_unlock(&rt722_sdca->disable_irq_lock);
+ scoped_guard(mutex, &rt722_sdca->disable_irq_lock) {
+ rt722_sdca->disable_irq = true;
+ ret1 = sdw_update_no_pm(slave, SDW_SCP_SDCA_INTMASK1,
+ SDW_SCP_SDCA_INTMASK_SDCA_0, 0);
+ ret2 = sdw_update_no_pm(slave, SDW_SCP_SDCA_INTMASK2,
+ SDW_SCP_SDCA_INTMASK_SDCA_8, 0);
+ }
if (ret1 < 0 || ret2 < 0) {
/* log but don't prevent suspend from happening */
@@ -541,13 +542,15 @@ static int rt722_sdca_dev_resume(struct device *dev)
return 0;
if (!slave->unattach_request) {
- mutex_lock(&rt722->disable_irq_lock);
- if (rt722->disable_irq == true) {
- sdw_write_no_pm(slave, SDW_SCP_SDCA_INTMASK1, SDW_SCP_SDCA_INTMASK_SDCA_0);
- sdw_write_no_pm(slave, SDW_SCP_SDCA_INTMASK2, SDW_SCP_SDCA_INTMASK_SDCA_8);
- rt722->disable_irq = false;
+ scoped_guard(mutex, &rt722->disable_irq_lock) {
+ if (rt722->disable_irq) {
+ sdw_write_no_pm(slave, SDW_SCP_SDCA_INTMASK1,
+ SDW_SCP_SDCA_INTMASK_SDCA_0);
+ sdw_write_no_pm(slave, SDW_SCP_SDCA_INTMASK2,
+ SDW_SCP_SDCA_INTMASK_SDCA_8);
+ rt722->disable_irq = false;
+ }
}
- mutex_unlock(&rt722->disable_irq_lock);
}
ret = sdw_slave_wait_for_init(slave, RT722_PROBE_TIMEOUT);
diff --git a/sound/soc/codecs/rt722-sdca.c b/sound/soc/codecs/rt722-sdca.c
index 1b6729f363fc..decf9407ab6d 100644
--- a/sound/soc/codecs/rt722-sdca.c
+++ b/sound/soc/codecs/rt722-sdca.c
@@ -6,6 +6,7 @@
//
//
+#include <linux/cleanup.h>
#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/dmi.h>
@@ -294,7 +295,7 @@ static void rt722_sdca_btn_check_handler(struct work_struct *work)
static void rt722_sdca_jack_init(struct rt722_sdca_priv *rt722)
{
- mutex_lock(&rt722->calibrate_mutex);
+ guard(mutex)(&rt722->calibrate_mutex);
if (rt722->hs_jack) {
/* set SCP_SDCA_IntMask1[0]=1 */
sdw_write_no_pm(rt722->slave, SDW_SCP_SDCA_INTMASK1,
@@ -317,7 +318,6 @@ static void rt722_sdca_jack_init(struct rt722_sdca_priv *rt722)
rt722_sdca_index_update_bits(rt722, RT722_VENDOR_HDA_CTL,
RT722_GE_RELATED_CTL2, 0x4000, 0x4000);
}
- mutex_unlock(&rt722->calibrate_mutex);
}
static int rt722_sdca_set_jack_detect(struct snd_soc_component *component,
--
2.43.0
prev parent reply other threads:[~2026-07-10 5:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 4:58 [PATCH v3 00/27] ASoC: codecs: Use guard() for mutex & spin locks - part 2 phucduc.bui
2026-07-09 4:58 ` [PATCH v3 01/27] ASoC: codecs: da7213: Use guard() for mutex locks phucduc.bui
2026-07-09 4:58 ` [PATCH v3 02/27] ASoC: codecs: da7219: " phucduc.bui
2026-07-09 17:17 ` [PATCH v3 00/27] ASoC: codecs: Use guard() for mutex & spin locks - part 2 Mark Brown
2026-07-10 2:05 ` Bui Duc Phuc
2026-07-10 5:04 ` [PATCH v3 03/27] ASoC: codecs: es8316: Use guard() for mutex locks phucduc.bui
2026-07-10 5:04 ` [PATCH v3 04/27] ASoC: codecs: es8326: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 05/27] ASoC: codecs: es9356: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 06/27] ASoC: codecs: fs210x: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 07/27] ASoC: codecs: hdac_hdmi: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 08/27] ASoC: codecs: hdmi-codec: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 09/27] ASoC: codecs: idt821034: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 10/27] ASoC: codecs: lpass-macro: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 11/27] ASoC: codecs: madera: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 12/27] ASoC: codecs: max98095: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 13/27] ASoC: codecs: mt6359-accdet: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 14/27] ASoC: codecs: pcm512x: " phucduc.bui
2026-07-10 5:04 ` [PATCH v3 15/27] ASoC: codecs: pcm6240: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 16/27] ASoC: codecs: peb2466: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 17/27] ASoC: codecs: rt5514-spi: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 18/27] ASoC: codecs: rt5645: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 19/27] ASoC: codecs: rt5665: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 20/27] ASoC: codecs: rt5668: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 21/27] ASoC: codecs: rt5677: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 22/27] ASoC: codecs: rt5682: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 23/27] ASoC: codecs: rt700: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 24/27] ASoC: codecs: rt711: " phucduc.bui
2026-07-10 5:05 ` [PATCH v3 25/27] ASoC: codecs: rt712: " phucduc.bui
2026-07-10 15:07 ` Mark Brown
2026-07-10 22:35 ` Bui Duc Phuc
2026-07-11 0:08 ` Bui Duc Phuc
2026-07-12 10:24 ` Bui Duc Phuc
2026-07-13 2:26 ` Bui Duc Phuc
2026-07-13 6:44 ` Bui Duc Phuc
2026-07-10 5:05 ` [PATCH v3 26/27] ASoC: codecs: rt721: " phucduc.bui
2026-07-10 5:05 ` phucduc.bui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710050511.14439-25-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=herve.codina@bootlin.com \
--cc=kees@kernel.org \
--cc=kevin-lu@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=matthias.bgg@gmail.com \
--cc=nick.li@foursemi.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=rongqianfeng@vivo.com \
--cc=sammiee5311@gmail.com \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=srini@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.