All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Albershteyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, ebiggers@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
	djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-ext4@vger.kernel.org, hch@lst.de,
	linux-btrfs@vger.kernel.org
Subject: [f2fs-dev] [PATCH v11 01/20] fsverity: report validation errors through fserror to fsnotify
Date: Fri, 10 Jul 2026 10:52:29 +0200	[thread overview]
Message-ID: <20260710085256.3464201-2-aalbersh@kernel.org> (raw)
In-Reply-To: <20260710085256.3464201-1-aalbersh@kernel.org>

Reported verification errors to fsnotify through recently added fserror
interface.

Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 fs/verity/verify.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/verity/verify.c b/fs/verity/verify.c
index 4004a1d42875..db8c350234bb 100644
--- a/fs/verity/verify.c
+++ b/fs/verity/verify.c
@@ -9,6 +9,7 @@
 
 #include <linux/bio.h>
 #include <linux/export.h>
+#include <linux/fserror.h>
 
 #define FS_VERITY_MAX_PENDING_BLOCKS 2
 
@@ -205,6 +206,8 @@ static bool verify_data_block(struct fsverity_info *vi,
 		if (memchr_inv(dblock->data, 0, params->block_size)) {
 			fsverity_err(inode,
 				     "FILE CORRUPTED!  Data past EOF is not zeroed");
+			fserror_report_data_lost(inode, data_pos,
+						 params->block_size, GFP_NOFS);
 			return false;
 		}
 		return true;
@@ -312,6 +315,7 @@ static bool verify_data_block(struct fsverity_info *vi,
 		data_pos, level - 1, params->hash_alg->name, hsize, want_hash,
 		params->hash_alg->name, hsize,
 		level == 0 ? dblock->real_hash : real_hash);
+	fserror_report_data_lost(inode, data_pos, params->block_size, GFP_NOFS);
 error:
 	for (; level > 0; level--) {
 		kunmap_local(hblocks[level - 1].addr);
-- 
2.54.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Albershteyn <aalbersh@kernel.org>
To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, ebiggers@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
	hch@lst.de, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-btrfs@vger.kernel.org, djwong@kernel.org
Subject: [PATCH v11 01/20] fsverity: report validation errors through fserror to fsnotify
Date: Fri, 10 Jul 2026 10:52:29 +0200	[thread overview]
Message-ID: <20260710085256.3464201-2-aalbersh@kernel.org> (raw)
In-Reply-To: <20260710085256.3464201-1-aalbersh@kernel.org>

Reported verification errors to fsnotify through recently added fserror
interface.

Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 fs/verity/verify.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/verity/verify.c b/fs/verity/verify.c
index 4004a1d42875..db8c350234bb 100644
--- a/fs/verity/verify.c
+++ b/fs/verity/verify.c
@@ -9,6 +9,7 @@
 
 #include <linux/bio.h>
 #include <linux/export.h>
+#include <linux/fserror.h>
 
 #define FS_VERITY_MAX_PENDING_BLOCKS 2
 
@@ -205,6 +206,8 @@ static bool verify_data_block(struct fsverity_info *vi,
 		if (memchr_inv(dblock->data, 0, params->block_size)) {
 			fsverity_err(inode,
 				     "FILE CORRUPTED!  Data past EOF is not zeroed");
+			fserror_report_data_lost(inode, data_pos,
+						 params->block_size, GFP_NOFS);
 			return false;
 		}
 		return true;
@@ -312,6 +315,7 @@ static bool verify_data_block(struct fsverity_info *vi,
 		data_pos, level - 1, params->hash_alg->name, hsize, want_hash,
 		params->hash_alg->name, hsize,
 		level == 0 ? dblock->real_hash : real_hash);
+	fserror_report_data_lost(inode, data_pos, params->block_size, GFP_NOFS);
 error:
 	for (; level > 0; level--) {
 		kunmap_local(hblocks[level - 1].addr);
-- 
2.54.0


  reply	other threads:[~2026-07-10  8:53 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10  8:52 [f2fs-dev] [PATCH v11 00/20] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52 ` Andrey Albershteyn
2026-07-10  8:52 ` Andrey Albershteyn via Linux-f2fs-devel [this message]
2026-07-10  8:52   ` [PATCH v11 01/20] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 02/20] fsverity: expose ensure_fsverity_info() Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 03/20] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 04/20] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 05/20] fsverity: improve flushing performance of fsverity_fill_zerohash Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 06/20] fsverity: don't allow setting DAX file attribute on fsverity files Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10 23:46   ` Eric Biggers
2026-07-10 23:46     ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-07-13  8:16     ` Andrey Albershteyn via Linux-f2fs-devel
2026-07-13  8:16       ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 07/20] xfs: introduce fsverity on-disk changes Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 08/20] xfs: initialize fs-verity on file open Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 09/20] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 10/20] xfs: don't report dio_mem_align and dio_offset_align for fsverity files Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 11/20] xfs: disable direct read path for fs-verity files Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 12/20] xfs: handle fsverity I/O in write/read path Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 13/20] xfs: use read ioend for fsverity data verification Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 14/20] xfs: add fs-verity support Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 15/20] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 16/20] xfs: add fs-verity ioctls Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 17/20] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 18/20] xfs: check and repair the verity inode flag state Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 19/20] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10  8:52 ` [f2fs-dev] [PATCH v11 20/20] xfs: enable ro-compat fs-verity flag Andrey Albershteyn via Linux-f2fs-devel
2026-07-10  8:52   ` Andrey Albershteyn
2026-07-10 10:38 ` [PATCH v11 00/20] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-07-10 10:38   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710085256.3464201-2-aalbersh@kernel.org \
    --to=linux-f2fs-devel@lists.sourceforge.net \
    --cc=aalbersh@kernel.org \
    --cc=djwong@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=fsverity@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.