Re: [PATCH rdma-next 03/13] RDMA/core: Support renaming a device when changing its net namespace

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The destination device name requested by userspace is ignored during a net namespace move because NULL is hardcoded in the netlink handler.
--

--- Patch [3]: [PATCH rdma-next 03/13] RDMA/core: Support renaming a device when changing its net namespace ---
commit 481a893ec5cd10a7f8be8c8de249d86cc283c470
Author: Jiri Pirko <jiri@nvidia.com>

RDMA/core: Support renaming a device when changing its net namespace

This patch updates the RDMA core to allow requesting a destination device
name when moving a device to a different network namespace. It modifies
ib_device_set_netns_put to take a requested name and implements the naming
rules during namespace teardown.

> diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
> index 3a9ec43a16f1a..3540cb0b9d4fb 100644
> --- a/drivers/infiniband/core/nldev.c
> +++ b/drivers/infiniband/core/nldev.c
> @@ -1194,7 +1194,7 @@ static int nldev_set_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
>  		u32 ns_fd;
>  
>  		ns_fd = nla_get_u32(tb[RDMA_NLDEV_NET_NS_FD]);
> -		err = ib_device_set_netns_put(skb, device, ns_fd);
> +		err = ib_device_set_netns_put(skb, device, ns_fd, NULL);

[Severity: Medium]
Does this hardcode NULL instead of extracting and passing the user-provided
device name?

The commit message mentions allowing namespace moves to request a destination
device name, but it appears ib_device_set_netns_put is always called with
NULL here.

How does this interact with the rename logic in nldev_set_doit? If a user
supplies both the RDMA_NLDEV_ATTR_DEV_NAME and RDMA_NLDEV_NET_NS_FD
attributes in the netlink command, will the code enter the rename logic first
and return, completely skipping the net namespace change instead of moving and
renaming the device?

>  		if (err == -EEXIST)
>  			NL_SET_ERR_MSG(extack,
>  				       "Device name already exists in the target net namespace");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709095532.855647-1-jiri@resnulli.us?part=3