From: Jiri Pirko <jiri@resnulli.us>
To: "yanjun.zhu" <yanjun.zhu@linux.dev>
Cc: linux-rdma@vger.kernel.org, cgroups@vger.kernel.org,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kselftest@vger.kernel.org, jgg@ziepe.ca, leon@kernel.org,
parav@nvidia.com, mbloch@nvidia.com, cmeiohas@nvidia.com,
roman.gushchin@linux.dev, bvanassche@acm.org,
zyjzyj2000@gmail.com, shuah@kernel.org, tj@kernel.org,
mkoutny@suse.com, hannes@cmpxchg.org, alibuda@linux.alibaba.com,
dust.li@linux.alibaba.com, sidraya@linux.ibm.com,
wenjia@linux.ibm.com
Subject: Re: [PATCH rdma-next 13/13] RDMA/selftests: Add rxe_netns_names test
Date: Mon, 13 Jul 2026 11:02:30 +0200 [thread overview]
Message-ID: <alSoztLdt2of_6rf@FV6GYCPJ69> (raw)
In-Reply-To: <2aec2d14-0000-4595-aa2a-73aa5ae41060@linux.dev>
Sat, Jul 11, 2026 at 01:51:45AM +0200, yanjun.zhu@linux.dev wrote:
>On 7/9/26 2:55 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>>
>> Add a kselftest script that exercises per-netns RDMA device naming
>> with RXE. Cover duplicate names across namespaces, move conflict
>> handling, move-with-rename, and same-namespace rename requests.
>
># timeout set to 45
># selftests: rdma: rxe_netns_names.sh
># TAP version 13
># 1..6
># ok 1 same RDMA device name can exist in two net namespaces
># ok 2 move without rename fails on destination name conflict
># ok 3 move then rename succeeds
># ok 4 move with requested destination name succeeds # SKIP < --- This
>testcase skip
>
># ok 5 same-netns rename rejects duplicate name
># # device returned to init_net as 'ibdev35'
># ok 6 netns delete returns device to init_net and renames on conflict
># # 1 skipped test(s) detected. Consider enabling relevant config options to
>improve coverage.
># # Totals: pass:5 fail:0 xfail:0 xpass:0 skip:1 error:0
>ok 6 selftests: rdma: rxe_netns_names.sh
>
>The above are my test results. But one testcase is skipped.
Yep, you need patched iproute2:
https://github.com/jpirko/iproute2_mlxsw/commit/cfb61f715fb16fc2b6d007408e048786ef3ed3f6
Plan to send this one after this patchset is merged.
>
>Zhu Yanjun
>
>>
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>> ---
>> tools/testing/selftests/rdma/Makefile | 3 +-
>> tools/testing/selftests/rdma/config | 2 +
>> .../testing/selftests/rdma/rxe_netns_names.sh | 282 ++++++++++++++++++
>> 3 files changed, 286 insertions(+), 1 deletion(-)
>> create mode 100755 tools/testing/selftests/rdma/rxe_netns_names.sh
>>
>> diff --git a/tools/testing/selftests/rdma/Makefile b/tools/testing/selftests/rdma/Makefile
>> index 07af7f15c1bf..a91c14c45006 100644
>> --- a/tools/testing/selftests/rdma/Makefile
>> +++ b/tools/testing/selftests/rdma/Makefile
>> @@ -3,6 +3,7 @@ TEST_PROGS := rxe_rping_between_netns.sh \
>> rxe_ipv6.sh \
>> rxe_socket_with_netns.sh \
>> rxe_test_NETDEV_UNREGISTER.sh \
>> - rxe_sent_rcvd_bytes.sh
>> + rxe_sent_rcvd_bytes.sh \
>> + rxe_netns_names.sh
>> include ../lib.mk
>> diff --git a/tools/testing/selftests/rdma/config b/tools/testing/selftests/rdma/config
>> index 4ffb814e253b..e1ff54ec0f57 100644
>> --- a/tools/testing/selftests/rdma/config
>> +++ b/tools/testing/selftests/rdma/config
>> @@ -1,3 +1,5 @@
>> CONFIG_TUN
>> CONFIG_VETH
>> +CONFIG_DUMMY
>> +CONFIG_NET_NS
>> CONFIG_RDMA_RXE
>> diff --git a/tools/testing/selftests/rdma/rxe_netns_names.sh b/tools/testing/selftests/rdma/rxe_netns_names.sh
>> new file mode 100755
>> index 000000000000..a7e57706fdff
>> --- /dev/null
>> +++ b/tools/testing/selftests/rdma/rxe_netns_names.sh
>> @@ -0,0 +1,282 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +#
>> +# Exercise RDMA device name handling across network namespaces.
>> +
>> +source "$(dirname "$0")/../kselftest/ktap_helpers.sh"
>> +
>> +NAME_PREFIX="rxe_netns_names_$$"
>> +NETDEV_PREFIX="rxn$$"
>> +NS1="${NAME_PREFIX}ns1"
>> +NS2="${NAME_PREFIX}ns2"
>> +RXE_A="${NAME_PREFIX}rxe_a"
>> +RXE_B="${NAME_PREFIX}rxe_b"
>> +RXE_SAME="${NAME_PREFIX}rxe_same"
>> +RXE_NEW="${NAME_PREFIX}rxe_new"
>> +DUMMY_A="${NETDEV_PREFIX}a"
>> +DUMMY_B="${NETDEV_PREFIX}b"
>> +OLD_MODE=""
>> +MODE_CHANGED=0
>> +MODS=("dummy" "rdma_rxe")
>> +TEST_SAME_NAMES="same RDMA device name can exist in two net namespaces"
>> +TEST_MOVE_CONFLICT="move without rename fails on destination name conflict"
>> +TEST_MOVE_RENAME="move then rename succeeds"
>> +TEST_COMBINED_MOVE_RENAME="move with requested destination name succeeds"
>> +TEST_SAME_NETNS_DUP_RENAME="same-netns rename rejects duplicate name"
>> +TEST_TEARDOWN_RETURN="netns delete returns device to init_net and renames on conflict"
>> +
>> +ksft_skip()
>> +{
>> + ktap_skip_all "$*"
>> + exit "$KSFT_SKIP"
>> +}
>> +
>> +fail()
>> +{
>> + ktap_exit_fail_msg "$*"
>> +}
>> +
>> +need_cmd()
>> +{
>> + command -v "$1" >/dev/null 2>&1 || ksft_skip "missing command: $1"
>> +}
>> +
>> +rdma_ns()
>> +{
>> + local ns=$1
>> +
>> + shift
>> + ip netns exec "$ns" rdma "$@"
>> +}
>> +
>> +rdma_dev_exists()
>> +{
>> + local ns=$1
>> + local dev=$2
>> +
>> + if [ -n "$ns" ]; then
>> + rdma_ns "$ns" dev show "$dev" >/dev/null 2>&1
>> + else
>> + rdma dev show "$dev" >/dev/null 2>&1
>> + fi
>> +}
>> +
>> +add_dummy()
>> +{
>> + local netdev=$1
>> +
>> + ip link add "$netdev" type dummy || return 1
>> + ip link set "$netdev" up || return 1
>> +}
>> +
>> +add_rxe()
>> +{
>> + local dev=$1
>> + local netdev=$2
>> +
>> + rdma link add "$dev" type rxe netdev "$netdev"
>> +}
>> +
>> +rdma_dev_on_netdev()
>> +{
>> + local netdev=$1
>> +
>> + rdma link show 2>/dev/null | awk -v want="$netdev" '
>> + {
>> + for (i = 1; i < NF; i++)
>> + if ($i == "netdev" && $(i + 1) == want) {
>> + dev = $2
>> + sub(/\/.*/, "", dev)
>> + print dev
>> + exit
>> + }
>> + }'
>> +}
>> +
>> +wait_rdma_dev_on_netdev()
>> +{
>> + local netdev=$1
>> + local dev
>> + local i
>> +
>> + for i in $(seq 1 50); do
>> + dev=$(rdma_dev_on_netdev "$netdev")
>> + if [ -n "$dev" ]; then
>> + echo "$dev"
>> + return 0
>> + fi
>> + sleep 0.1
>> + done
>> +
>> + return 1
>> +}
>> +
>> +setup_devs()
>> +{
>> + cleanup_devs
>> +
>> + add_dummy "$DUMMY_A" || return 1
>> + add_dummy "$DUMMY_B" || return 1
>> +
>> + add_rxe "$RXE_A" "$DUMMY_A" || return 1
>> + add_rxe "$RXE_B" "$DUMMY_B" || return 1
>> +}
>> +
>> +cleanup_devs()
>> +{
>> + ip link del "$DUMMY_A" 2>/dev/null
>> + ip link del "$DUMMY_B" 2>/dev/null
>> +}
>> +
>> +setup()
>> +{
>> + OLD_MODE=$(rdma system show 2>/dev/null |
>> + sed -n 's/.*netns \([^ ]*\).*/\1/p')
>> + [ -n "$OLD_MODE" ] || ksft_skip "failed to read RDMA netns mode"
>> +
>> + rdma system set netns exclusive >/dev/null 2>&1 ||
>> + ksft_skip "rdma netns exclusive mode is not supported"
>> + MODE_CHANGED=1
>> +
>> + ip netns add "$NS1" || return 1
>> + ip netns add "$NS2" || return 1
>> +}
>> +
>> +cleanup()
>> +{
>> + cleanup_devs
>> +
>> + ip netns del "$NS1" 2>/dev/null
>> + ip netns del "$NS2" 2>/dev/null
>> +
>> + if [ "$MODE_CHANGED" -eq 1 ]; then
>> + rdma system set netns "$OLD_MODE" 2>/dev/null
>> + fi
>> +
>> + for m in "${MODS[@]}"; do
>> + modprobe -r "$m" 2>/dev/null
>> + done
>> +}
>> +
>> +rdma_supports_combined_move_rename()
>> +{
>> + rdma dev help 2>&1 | grep -Eq 'netns .*name|name .*netns'
>> +}
>> +
>> +[ "$(id -u)" -eq 0 ] || ksft_skip "must be run as root"
>> +need_cmd ip
>> +need_cmd rdma
>> +need_cmd modprobe
>> +
>> +trap cleanup EXIT
>> +
>> +for m in "${MODS[@]}"; do
>> + modinfo "$m" >/dev/null 2>&1 || ksft_skip "module $m not found"
>> + modprobe "$m" || fail "failed to load $m"
>> +done
>> +
>> +setup || fail "failed to create net namespaces"
>> +
>> +ktap_print_header
>> +ktap_set_plan 7
>> +
>> +if setup_devs &&
>> + rdma dev set "$RXE_A" netns "$NS1" &&
>> + rdma_ns "$NS1" dev set "$RXE_A" name "$RXE_SAME" &&
>> + rdma dev set "$RXE_B" netns "$NS2" &&
>> + rdma_ns "$NS2" dev set "$RXE_B" name "$RXE_SAME" &&
>> + rdma_dev_exists "$NS1" "$RXE_SAME" &&
>> + rdma_dev_exists "$NS2" "$RXE_SAME"; then
>> + ktap_test_pass "$TEST_SAME_NAMES"
>> +else
>> + ktap_test_fail "$TEST_SAME_NAMES"
>> +fi
>> +cleanup_devs
>> +
>> +if ! setup_devs ||
>> + ! rdma dev set "$RXE_A" netns "$NS1" ||
>> + ! rdma_ns "$NS1" dev set "$RXE_A" name "$RXE_SAME" ||
>> + ! rdma dev set "$RXE_B" netns "$NS2" ||
>> + ! rdma_ns "$NS2" dev set "$RXE_B" name "$RXE_SAME"; then
>> + ktap_test_fail "$TEST_MOVE_CONFLICT"
>> +elif rdma_ns "$NS1" dev set "$RXE_SAME" netns "$NS2" >/dev/null 2>&1; then
>> + ktap_test_fail "$TEST_MOVE_CONFLICT"
>> +elif rdma_dev_exists "$NS1" "$RXE_SAME" &&
>> + rdma_dev_exists "$NS2" "$RXE_SAME"; then
>> + ktap_test_pass "$TEST_MOVE_CONFLICT"
>> +else
>> + ktap_test_fail "$TEST_MOVE_CONFLICT"
>> +fi
>> +cleanup_devs
>> +
>> +if ! setup_devs; then
>> + ktap_test_fail "$TEST_MOVE_RENAME"
>> +elif rdma dev set "$RXE_A" netns "$NS2" &&
>> + rdma_ns "$NS2" dev set "$RXE_A" name "$RXE_NEW"; then
>> + if rdma_dev_exists "$NS2" "$RXE_NEW" &&
>> + ! rdma_dev_exists "" "$RXE_A"; then
>> + ktap_test_pass "$TEST_MOVE_RENAME"
>> + else
>> + ktap_test_fail "$TEST_MOVE_RENAME"
>> + fi
>> +else
>> + ktap_test_fail "$TEST_MOVE_RENAME"
>> +fi
>> +cleanup_devs
>> +
>> +if ! rdma_supports_combined_move_rename; then
>> + ktap_test_skip "$TEST_COMBINED_MOVE_RENAME"
>> +elif ! setup_devs; then
>> + ktap_test_fail "$TEST_COMBINED_MOVE_RENAME"
>> +elif rdma dev set "$RXE_A" netns "$NS2" name "$RXE_NEW"; then
>> + if rdma_dev_exists "$NS2" "$RXE_NEW" &&
>> + ! rdma_dev_exists "" "$RXE_A"; then
>> + ktap_test_pass "$TEST_COMBINED_MOVE_RENAME"
>> + else
>> + ktap_test_fail "$TEST_COMBINED_MOVE_RENAME"
>> + fi
>> +else
>> + ktap_test_fail "$TEST_COMBINED_MOVE_RENAME"
>> +fi
>> +cleanup_devs
>> +
>> +if ! setup_devs; then
>> + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME"
>> +elif rdma dev set "$RXE_A" name "$RXE_SAME" &&
>> + rdma dev set "$RXE_B" name "$RXE_NEW"; then
>> + if rdma dev set "$RXE_A" name "$RXE_NEW" >/dev/null 2>&1; then
>> + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME"
>> + elif rdma_dev_exists "" "$RXE_SAME" &&
>> + rdma_dev_exists "" "$RXE_NEW"; then
>> + ktap_test_pass "$TEST_SAME_NETNS_DUP_RENAME"
>> + else
>> + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME"
>> + fi
>> +else
>> + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME"
>> +fi
>> +cleanup_devs
>> +
>> +if ! setup_devs; then
>> + ktap_test_fail "$TEST_TEARDOWN_RETURN"
>> +elif ! rdma dev set "$RXE_A" name "$RXE_SAME" ||
>> + ! rdma dev set "$RXE_B" netns "$NS2" ||
>> + ! rdma_ns "$NS2" dev set "$RXE_B" name "$RXE_SAME" ||
>> + ! rdma_dev_exists "$NS2" "$RXE_SAME"; then
>> + ktap_test_fail "$TEST_TEARDOWN_RETURN"
>> +else
>> + ip netns del "$NS2"
>> + returned=$(wait_rdma_dev_on_netdev "$DUMMY_B")
>> + ktap_print_msg "device returned to init_net as '${returned:-<missing>}'"
>> + if rdma_dev_exists "" "$RXE_SAME" &&
>> + [ -n "$returned" ] &&
>> + [ "$returned" != "$RXE_SAME" ] &&
>> + [ "${returned#ibdev}" != "$returned" ]; then
>> + ktap_test_pass "$TEST_TEARDOWN_RETURN"
>> + else
>> + ktap_test_fail "$TEST_TEARDOWN_RETURN"
>> + fi
>> +fi
>> +cleanup_devs
>> +
>> +ktap_finished
>
prev parent reply other threads:[~2026-07-13 9:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 9:55 [PATCH rdma-next 00/13] RDMA: Make device names unique per net namespace Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 01/13] RDMA/core: Pass the net namespace to the device name lookups Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 02/13] RDMA/core: Handle device name conflicts when changing net namespace Jiri Pirko
2026-07-10 9:56 ` sashiko-bot
2026-07-13 12:32 ` Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 03/13] RDMA/core: Support renaming a device when changing its " Jiri Pirko
2026-07-10 9:56 ` sashiko-bot
2026-07-13 12:17 ` Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 04/13] RDMA/nldev: Report net namespace move errors through extack Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 05/13] RDMA/nldev: Allow setting the device name while changing net namespace Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 06/13] net/smc: Look up the pnetid ib device within the " Jiri Pirko
2026-07-10 9:56 ` sashiko-bot
2026-07-09 9:55 ` [PATCH rdma-next 07/13] RDMA/srp: Make the SRP sysfs class net namespace aware Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 08/13] RDMA/cgroup: Scope rdma cgroup device visibility to the net namespace Jiri Pirko
2026-07-09 13:04 ` Michal Koutný
2026-07-13 9:34 ` Jiri Pirko
2026-07-14 2:28 ` Tao Cui
2026-07-14 7:39 ` Jiri Pirko
2026-07-10 9:56 ` sashiko-bot
2026-07-14 11:39 ` Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 09/13] RDMA/cma: Document that CM configfs cannot be net namespace scoped Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 10/13] RDMA/core: Document the SELinux ibendport net namespace limitation Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 11/13] RDMA/core: Make device names unique per net namespace Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 12/13] RDMA/rxe: Implement disassociate_ucontext callback Jiri Pirko
2026-07-10 4:21 ` Zhu Yanjun
2026-07-10 9:56 ` sashiko-bot
2026-07-13 13:24 ` Jiri Pirko
2026-07-09 9:55 ` [PATCH rdma-next 13/13] RDMA/selftests: Add rxe_netns_names test Jiri Pirko
2026-07-10 4:24 ` Zhu Yanjun
2026-07-13 8:58 ` Jiri Pirko
2026-07-10 9:56 ` sashiko-bot
2026-07-13 13:35 ` Jiri Pirko
2026-07-10 23:51 ` yanjun.zhu
2026-07-13 9:02 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSoztLdt2of_6rf@FV6GYCPJ69 \
--to=jiri@resnulli.us \
--cc=alibuda@linux.alibaba.com \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=cmeiohas@nvidia.com \
--cc=dust.li@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=mkoutny@suse.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=roman.gushchin@linux.dev \
--cc=shuah@kernel.org \
--cc=sidraya@linux.ibm.com \
--cc=tj@kernel.org \
--cc=wenjia@linux.ibm.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.