Re: [PATCH v2 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding a second phandle to the `allwinner,sram` property has no effect at runtime because the sunxi_sram driver infrastructure hardcodes parsing to only the first index.
--

--- Patch [5]: [PATCH v2 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine ---
commit 8b2bcf328faa458d85d11e3cef06ddda86e2e10e
Author: Chen-Yu Tsai <wens@kernel.org>

arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine

This commit adds a reference to the SRAM C region in the video engine node
to prevent access through a partial alias window.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -205,7 +205,7 @@ video-codec@1c0e000 {
>  			clock-names = "ahb", "mod", "ram";
>  			resets = <&ccu RST_BUS_VE>;
>  			interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> -			allwinner,sram = <&ve_sram 1>;
> +			allwinner,sram = <&ve_sram 1>, <&de2_sram 1>;

[Severity: Medium]
Will the second phandle be silently ignored during runtime?

Looking at the cedrus driver, it calls sunxi_sram_claim() during probe.
However, the underlying infrastructure appears to hardcode index 0 when
parsing this property:

drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_of_parse() {
    ...
    ret = of_parse_phandle_with_fixed_args(node, "allwinner,sram", 1, 0,
                                           &args);
    ...
}

Does the driver infrastructure need to be updated to parse multiple indices
before this device tree addition takes effect?

>  			iommus = <&iommu 3>;
>  		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711135959.3616919-1-wens@kernel.org?part=5