Re: [PATCH v2 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The video-codec node references a non-existent label 've_sram', causing a Device Tree Compiler (DTC) build failure.
- [Low] The `allwinner,sram` property incorrectly references the generic `mmio-sram` parent controller node (`&sram_c`) instead of an `sram-section` child node.
--

--- Patch [7]: [PATCH v2 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine ---
commit f351af2797d5cc85ad73122a961f9b9e63f82153
Author: Jernej Skrabec <jernej.skrabec@gmail.com>

arm64: dts: allwinner: sun50i-h616: Add video engine

This commit adds the video engine node to the sun50i-h616 device tree file.
It defines the required memory regions, clocks, resets, interrupts, and
SRAM nodes needed by the engine.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
[ ... ]
> @@ -175,6 +175,18 @@ crypto: crypto@1904000 {
>  			resets = <&ccu RST_BUS_CE>;
>  		};
>  
> +		video-codec@1c0e000 {
> +			compatible = "allwinner,sun50i-h616-video-engine";
> +			reg = <0x01c0e000 0x2000>;
> +			clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>,
> +				 <&ccu CLK_MBUS_VE>;
> +			clock-names = "ahb", "mod", "ram";
> +			resets = <&ccu RST_BUS_VE>;
> +			interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> +			iommus = <&iommu 3>, <&iommu 2>;
> +			allwinner,sram = <&ve_sram 1>, <&sram_c 1>;

[Severity: Low]
Is the ve_sram label defined elsewhere? The Device Tree Compiler (DTC) will
fail to build because of this unresolved reference. It appears the sram_c1
node and its ve_sram child section might be missing.

[Severity: Low]
Does the second phandle correctly reference an sram-section child node?
Referencing &sram_c here points to the generic mmio-sram parent controller
node, which lacks #sram-cells. This violates the bindings and triggers a
dt-validate schema failure.

> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711135959.3616919-1-wens@kernel.org?part=7