From: Miles Krause <mileskrause5200@gmail.com>
To: Willy Tarreau <willy@haproxy.com>,
Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, Miles Krause <mileskrause5200@gmail.com>
Subject: [PATCH] auxdisplay: panel: Remove unused callback binding code
Date: Sun, 12 Jul 2026 21:07:11 -0400 [thread overview]
Message-ID: <20260712-panel-remove-dead-callback-v1-1-1091ce75b8d5@gmail.com> (raw)
panel_bind_callback() has been compiled out with #if 0 since it was
introduced and has no callers. Remove the dead function to reduce
maintenance burden.
No functional change.
Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Compile-tested on x86_64 with:
make O=out allmodconfig
make O=out W=1 drivers/auxdisplay/panel.o
Sparse-tested with:
make O=out C=2 CHECK=sparse drivers/auxdisplay/panel.o
---
drivers/auxdisplay/panel.c | 37 -------------------------------------
1 file changed, 37 deletions(-)
diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index d8854cf15268..a7dfc53157bc 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1450,43 +1450,6 @@ static struct logical_input *panel_bind_key(const char *name, const char *press,
return key;
}
-#if 0
-/* tries to bind a callback function to the signal name <name>. The function
- * <press_fct> will be called with the <press_data> arg when the signal is
- * activated, and so on for <release_fct>/<release_data>
- * Returns the pointer to the new signal if ok, NULL if the signal could not
- * be bound.
- */
-static struct logical_input *panel_bind_callback(char *name,
- void (*press_fct)(int),
- int press_data,
- void (*release_fct)(int),
- int release_data)
-{
- struct logical_input *callback;
-
- callback = kmalloc(sizeof(*callback), GFP_KERNEL);
- if (!callback)
- return NULL;
-
- memset(callback, 0, sizeof(struct logical_input));
- if (!input_name2mask(name, &callback->mask, &callback->value,
- &scan_mask_i, &scan_mask_o))
- return NULL;
-
- callback->type = INPUT_TYPE_STD;
- callback->state = INPUT_ST_LOW;
- callback->rise_time = 1;
- callback->fall_time = 1;
- callback->u.std.press_fct = press_fct;
- callback->u.std.press_data = press_data;
- callback->u.std.release_fct = release_fct;
- callback->u.std.release_data = release_data;
- list_add(&callback->list, &logical_inputs);
- return callback;
-}
-#endif
-
static void keypad_init(void)
{
int keynum;
---
base-commit: 30a41cf47aecb4dafb81183b5e046e93498773ff
change-id: 20260712-panel-remove-dead-callback-46b2251e4feb
Best regards,
--
Miles Krause <mileskrause5200@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Miles Krause via B4 Relay <devnull+mileskrause5200.gmail.com@kernel.org>
To: Willy Tarreau <willy@haproxy.com>,
Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, Miles Krause <mileskrause5200@gmail.com>
Subject: [PATCH] auxdisplay: panel: Remove unused callback binding code
Date: Sun, 12 Jul 2026 21:07:11 -0400 [thread overview]
Message-ID: <20260712-panel-remove-dead-callback-v1-1-1091ce75b8d5@gmail.com> (raw)
From: Miles Krause <mileskrause5200@gmail.com>
panel_bind_callback() has been compiled out with #if 0 since it was
introduced and has no callers. Remove the dead function to reduce
maintenance burden.
No functional change.
Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Compile-tested on x86_64 with:
make O=out allmodconfig
make O=out W=1 drivers/auxdisplay/panel.o
Sparse-tested with:
make O=out C=2 CHECK=sparse drivers/auxdisplay/panel.o
---
drivers/auxdisplay/panel.c | 37 -------------------------------------
1 file changed, 37 deletions(-)
diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index d8854cf15268..a7dfc53157bc 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1450,43 +1450,6 @@ static struct logical_input *panel_bind_key(const char *name, const char *press,
return key;
}
-#if 0
-/* tries to bind a callback function to the signal name <name>. The function
- * <press_fct> will be called with the <press_data> arg when the signal is
- * activated, and so on for <release_fct>/<release_data>
- * Returns the pointer to the new signal if ok, NULL if the signal could not
- * be bound.
- */
-static struct logical_input *panel_bind_callback(char *name,
- void (*press_fct)(int),
- int press_data,
- void (*release_fct)(int),
- int release_data)
-{
- struct logical_input *callback;
-
- callback = kmalloc(sizeof(*callback), GFP_KERNEL);
- if (!callback)
- return NULL;
-
- memset(callback, 0, sizeof(struct logical_input));
- if (!input_name2mask(name, &callback->mask, &callback->value,
- &scan_mask_i, &scan_mask_o))
- return NULL;
-
- callback->type = INPUT_TYPE_STD;
- callback->state = INPUT_ST_LOW;
- callback->rise_time = 1;
- callback->fall_time = 1;
- callback->u.std.press_fct = press_fct;
- callback->u.std.press_data = press_data;
- callback->u.std.release_fct = release_fct;
- callback->u.std.release_data = release_data;
- list_add(&callback->list, &logical_inputs);
- return callback;
-}
-#endif
-
static void keypad_init(void)
{
int keynum;
---
base-commit: 30a41cf47aecb4dafb81183b5e046e93498773ff
change-id: 20260712-panel-remove-dead-callback-46b2251e4feb
Best regards,
--
Miles Krause <mileskrause5200@gmail.com>
next reply other threads:[~2026-07-13 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 1:07 Miles Krause [this message]
2026-07-13 1:07 ` [PATCH] auxdisplay: panel: Remove unused callback binding code Miles Krause via B4 Relay
2026-07-13 8:18 ` Geert Uytterhoeven
2026-07-13 8:25 ` Willy TARREAU
2026-07-13 11:28 ` Andy Shevchenko
2026-07-14 7:11 ` Geert Uytterhoeven
2026-07-14 8:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712-panel-remove-dead-callback-v1-1-1091ce75b8d5@gmail.com \
--to=mileskrause5200@gmail.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@haproxy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.