Re: [PATCH v3 1/7] dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Validation failure: sun50i-h6.dtsi fails dtbs_check due to the new minItems: 2 constraint.
--

--- Patch [1]: [PATCH v3 1/7] dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6 ---
commit 17817354e28859038f6eb81e492f4c4b1bc51a02
Author: Chen-Yu Tsai <wens@kernel.org>

dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6

This commit updates the device tree binding for the sun4i-a10-video-engine to
specify that the H6 SoC requires two IOMMU connections. It adds a conditional
schema block enforcing a minimum of two items for the iommus property on H6
devices.

> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> index 541325f900a1d..b4c0fabb38211 100644
> --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml

[ ... ]

> @@ -72,6 +75,22 @@ required:
>    - resets
>    - allwinner,sram
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - allwinner,sun50i-h6-video-engine
> +    then:
> +      properties:
> +        iommus:
> +          minItems: 2

[Severity: Low]
Will this strict constraint cause dtbs_check failures for existing device
trees?

Looking at the H6 dtsi file, the video-codec node only provides a single IOMMU
connection:

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi:video-codec@1c0e000 {
	...
	iommus = <&iommu 3>;
};

Since this commit enforces minItems: 2 without simultaneously updating the
device tree, will it cause make dtbs_check to report validation errors for the
H6 SoC?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712030011.3778169-1-wens@kernel.org?part=1