Re: [PATCH v3 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `video-codec` node references an undefined `ve_sram` phandle, causing a device tree compilation error, and a structurally incorrect `sram_c` phandle.
--

--- Patch [7]: [PATCH v3 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine ---
commit 47b5fe1ab74e2eb5363068c14fed457f3e1ad7e1
Author: Jernej Skrabec <jernej.skrabec@gmail.com>

arm64: dts: allwinner: sun50i-h616: Add video engine

This commit adds the video engine node to the sun50i-h616 dtsi file. It
defines the clocks, resets, interrupts, iommus, and SRAM regions required
by the video engine hardware.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index bf054869e78be..fc912ed80a3e4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -175,6 +175,18 @@ crypto: crypto@1904000 {
>  			resets = <&ccu RST_BUS_CE>;
>  		};
>  
> +		video-codec@1c0e000 {
> +			compatible = "allwinner,sun50i-h616-video-engine";
> +			reg = <0x01c0e000 0x2000>;
> +			clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>,
> +				 <&ccu CLK_MBUS_VE>;
> +			clock-names = "ahb", "mod", "ram";
> +			resets = <&ccu RST_BUS_VE>;
> +			interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> +			iommus = <&iommu 3>, <&iommu 2>;
> +			allwinner,sram = <&ve_sram 1>, <&sram_c 1>;

[Severity: Low]
Will this cause a device tree compilation error? The &ve_sram phandle doesn't
appear to be defined, which could prevent the device tree from building.

Also, does the &sram_c phandle reference the parent mmio-sram node instead
of a valid sram-section child node? If it points to the parent,
sunxi_sram_of_parse() might return -EINVAL during driver probe.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712030011.3778169-1-wens@kernel.org?part=7