From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Thomas Huth <thuth@redhat.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] crypto: pcrypt - Disallow nesting of the pcrypt wrapper
Date: Sun, 12 Jul 2026 22:46:54 -0400 [thread overview]
Message-ID: <20260713024654.GE4362@quark> (raw)
In-Reply-To: <alRNusgXIT06hTow@gondor.apana.org.au>
On Mon, Jul 13, 2026 at 12:30:18PM +1000, Herbert Xu wrote:
> This doesn't fix the problem completely since you can nest in other
> ways, e.g., pcrypt(cryptd(pcrypt(...))). How about handling the name-
> too-long error more gracefully?
Could we just delete pcrypt instead of continuing to try to fix all the
weird problems it has? A web search for pcrypt just finds CVEs and
advice not to use it, e.g.
https://github.com/libreswan/libreswan/wiki/Internals:-Cryptographic-Acceleration#obsoleted-ipsec-accelerations
What is the rationale for keeping it? Who cares about it, other than
people looking for vulnerabilities?
- Eric
next prev parent reply other threads:[~2026-07-13 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 14:39 [RFC PATCH] crypto: pcrypt - Disallow nesting of the pcrypt wrapper Thomas Huth
2026-07-13 2:30 ` Herbert Xu
2026-07-13 2:46 ` Eric Biggers [this message]
2026-07-13 2:56 ` Herbert Xu
2026-07-14 8:00 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713024654.GE4362@quark \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.