Re: [PATCH 4/8] ARM: dts: mstar: unitv2: Link cpu to core regulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete hardware description: `cpu-supply` is omitted for `cpu1` on a dual-core SoC.
--

--- Patch [4]: [PATCH 4/8] ARM: dts: mstar: unitv2: Link cpu to core regulator ---
commit 15b5fb30c26091d181dfb33beb3faccbf6865c52
Author: Daniel Palmer <daniel@0x0f.com>

ARM: dts: mstar: unitv2: Link cpu to core regulator

This commit adds a reference to the core voltage regulator as the CPU
supply, ensuring the regulator is correctly described as feeding the CPU.

> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts

[ ... ]

> @@ -85,6 +85,10 @@ reg_vcc_wifi: regulator-vcc-wifi {
>  	};
>  };
>  
> +&cpu0 {
> +	cpu-supply = <&reg_vcc_core>;
> +};
> +

[Severity: Low]
Since the SSD202D is a dual-core SoC and both Cortex-A7 cores share the same
physical voltage domain fed by reg_vcc_core, should there also be a matching
cpu-supply property added for &cpu1?

While the cpufreq-dt driver might infer the shared supply via the opp-shared
property when processing cpu0, would adding it for cpu1 provide a more
complete OS-agnostic hardware description for the device tree?

>  &pm_uart {
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713105950.1346962-1-daniel@thingy.jp?part=4