Re: [PATCH 2/8] ARM: dts: mstar: unitv2: Add regulators

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `enable-active-high` property in `reg_vcc_wifi` causes the gpiolib core to forcefully invert its GPIO polarity to active-low.
--

--- Patch [2]: [PATCH 2/8] ARM: dts: mstar: unitv2: Add regulators ---
commit 45b1e50aa0d58e3444d010d9375cea0bd438d0d9
Author: Daniel Palmer <daniel@0x0f.com>
ARM: dts: mstar: unitv2: Add regulators

This commit adds fixed regulators for the core, IO, and DRAM voltage rails.
It also introduces a GPIO-controlled switch that supplies the WiFi chip.

> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-unitv2.dts
[ ... ]
> +	reg_vcc_wifi: regulator-vcc-wifi {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_wifi";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio SSD20XD_GPIO_GPIO14 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
Will the gpiolib core force this GPIO to active-low polarity?

Due to a legacy quirk for regulator-fixed nodes in the gpiolib core, the
GPIO_ACTIVE_HIGH flag in the phandle is ignored in favor of the boolean
enable-active-high property. Without the enable-active-high property present
here, will the WiFi chip receive inverted power control and fail to operate?

> +	};
>  };
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713105950.1346962-1-daniel@thingy.jp?part=2