Re: [PATCH v16 02/10] dt-bindings: iio: imu: icm42600: Remove interrupts from required

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree binding removes the `interrupts` requirement, making it optional, but the associated kernel driver still unconditionally requires an interrupt to probe successfully. The driver fetches the interrupt via `fwnode_irq_get_byname()` or `fwnode_irq_get()` and aborts the probe with `dev_err_probe()` if none is found. Relaxing the binding allows device trees to omit the interrupt property and pass schema validation, but such configurations will unconditionally fail at runtime because the driver currently lacks support for polling mode.
--

--- Patch [2]: [PATCH v16 02/10] dt-bindings: iio: imu: icm42600: Remove interrupts from required ---
commit 161a6f84f50962ef8b7d4035dc0e3aa2eb3afb64
Author: Chris Morgan <macromorgan@hotmail.com>

dt-bindings: iio: imu: icm42600: Remove interrupts from required

This commit removes the interrupts requirement from the icm42600 device tree
binding schema. The commit message notes that interrupts are rarely required
for IIO devices.

> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index 9b2af104f186d..f6f97ea030389 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> @@ -67,7 +67,6 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - interrupts

[Severity: Medium]
Does this change introduce a mismatch with the driver implementation?

If a device tree omits the interrupts property, it will now pass schema
validation, but it appears the driver will still fail to probe.

Looking at inv_icm42600_core_probe() in
drivers/iio/imu/inv_icm42600/inv_icm42600_core.c:

    if (irq < 0)
        return dev_err_probe(dev, irq, "error missing INT1 interrupt\n");

Will the driver need to be updated to support a polling mode, or should the
interrupt remain required until the driver can support operating without one?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713215842.69097-1-macroalpha82@gmail.com?part=2