Re: [PATCH v16 06/10] iio: imu: inv_icm42607: Add PM support for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Bypassing explicit platform workaround for 0-delays
- [Low] Incompatible pointer type for enum parameter
--

--- Patch [6]: [PATCH v16 06/10] iio: imu: inv_icm42607: Add PM support for icm42607 ---
commit 2cc6ce210d26cf1a702e03730729ef340784c90f
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add PM support for icm42607
    
Add power management support for the ICM42607 device driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index b90e578c3fb2c..303a6a0b1b21e 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c

[ ... ]

> @@ -102,6 +106,90 @@ const struct inv_icm42607_hw inv_icm42607p_hw_data = {
>  };
>  EXPORT_SYMBOL_NS_GPL(inv_icm42607p_hw_data, "IIO_ICM42607");
>  
> +int inv_icm42607_get_pwr_mgmt0(struct inv_icm42607_state *st,
> +			       enum inv_icm42607_sensor_mode *gyro,
> +			       enum inv_icm42607_sensor_mode *accel)
> +{

[ ... ]

> +}
> +
> +static int inv_icm42607_set_pwr_mgmt0(struct inv_icm42607_state *st,
> +				      enum inv_icm42607_sensor_mode gyro,
> +				      enum inv_icm42607_sensor_mode accel)
> +{
> +	unsigned int oldaccel, oldgyro;
> +	unsigned int sleepval_us;
> +	unsigned int val;
> +	s64 disable_wait;
> +	int ret;
> +
> +	ret = inv_icm42607_get_pwr_mgmt0(st, &oldgyro, &oldaccel);

[Severity: Low]
Will this cause an incompatible pointer type compiler warning or error?
inv_icm42607_get_pwr_mgmt0() expects enum inv_icm42607_sensor_mode pointers,
but oldgyro and oldaccel are declared as unsigned int.

> +	if (ret)
> +		return ret;
> +
> +	if (gyro == oldgyro && accel == oldaccel)
> +		return 0;
> +
> +	/*
> +	 * Datasheet on page 14.26 says we need to ensure the gyro sensor is on
> +	 * for a minimum of 45ms. So if we transition from an on state to an
> +	 * off state make sure at least 45ms have passed before power off and
> +	 * wait if it hasn't.
> +	 */
> +	if (!gyro && oldgyro) {
> +		disable_wait = ktime_us_delta(st->conf.gyro_stop, ktime_get());
> +		disable_wait = clamp(disable_wait,
> +				     0, INV_ICM42607_GYRO_STOP_TIME_US);
> +		fsleep(disable_wait);

[Severity: Low]
Can disable_wait evaluate to 0 here and cause issues on certain platforms? 

The comment later in this function mentions that some platforms have
issues with a 0 delay, but this fsleep() is called unconditionally even if
disable_wait is clamped to 0.

> +	}
> +
> +	val = FIELD_PREP(INV_ICM42607_PWR_MGMT0_GYRO_MODE_MASK, gyro) |

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713215842.69097-1-macroalpha82@gmail.com?part=6