From: sashiko-bot@kernel.org
To: "Jia Wang" <wangjia@ultrarisc.com>
Cc: robh@kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 3/3] PCI: ultrarisc: allow DP1000 driver to build as module
Date: Tue, 14 Jul 2026 01:15:20 +0000 [thread overview]
Message-ID: <20260714011520.E61621F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714-ultrarisc-pci-clk-v3-3-e72723fc0ef1@ultrarisc.com>
> From: Jia Wang <wangjia@ultrarisc.com>
>
> CONFIG_PCIE_ULTRARISC is a tristate option, so the driver can be selected
> as a module when COMPILE_TEST or platform configuration allows it. Using
> builtin_platform_driver() leaves the module build without the module
> init/exit plumbing and causes modpost failures for the generated .ko.
>
> Use module_platform_driver() so the driver works for both module and
> built-in builds while keeping the existing tristate Kconfig entry.
>
> Add a remove callback and call dw_pcie_host_deinit() during removal so the
> root bus is torn down before devres releases the controller data.
>
> Fixes: 5fc35740c3b3 ("PCI: ultrarisc: Add UltraRISC DP1000 PCIe Root Complex driver")
> Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-ultrarisc-pci-clk-v3-0-e72723fc0ef1@ultrarisc.com?part=3
prev parent reply other threads:[~2026-07-14 1:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 1:11 [PATCH v3 0/3] PCI: ultrarisc: Add DP1000 PCIe clock support Jia Wang via B4 Relay
2026-07-14 1:11 ` Jia Wang
2026-07-14 1:11 ` [PATCH v3 1/3] dt-bindings: pci: ultrarisc: add required DP1000 PCIe clocks Jia Wang via B4 Relay
2026-07-14 1:11 ` Jia Wang
2026-07-14 1:24 ` sashiko-bot
2026-07-14 1:11 ` [PATCH v3 2/3] PCI: ultrarisc: get and enable " Jia Wang via B4 Relay
2026-07-14 1:11 ` Jia Wang
2026-07-14 1:18 ` sashiko-bot
2026-07-14 1:11 ` [PATCH v3 3/3] PCI: ultrarisc: allow DP1000 driver to build as module Jia Wang via B4 Relay
2026-07-14 1:11 ` Jia Wang
2026-07-14 1:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714011520.E61621F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wangjia@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.