From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: OrangeBlack0765@outlook.com,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()
Date: Tue, 14 Jul 2026 11:00:49 +0200 [thread overview]
Message-ID: <20260714110049.00001c34@gmail.com> (raw)
In-Reply-To: <alX5FkSyqo6taYl9@ashevche-desk.local>
On Tue, 14 Jul 2026 11:53:42 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > for (i = 0; i < ARRAY_SIZE(chip->als_settings.als_device_lux); i++) {
> > - offset += sprintf(buf + offset, "%u,%u,%u,",
> > + offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
> > chip->als_settings.als_device_lux[i].ratio,
> > chip->als_settings.als_device_lux[i].ch0,
> > chip->als_settings.als_device_lux[i].ch1);
>
> Now the indentation becomes broken.
I seem to be blind when reviewing.
--
Kind regards
CJD
next prev parent reply other threads:[~2026-07-14 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 17:08 [PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at() OrangeBlack0765
2026-07-14 6:52 ` Joshua Crofts
2026-07-14 8:53 ` Andy Shevchenko
2026-07-14 9:00 ` Joshua Crofts [this message]
2026-07-14 13:32 ` [PATCH] iio: light: tsl2583: migrate to sysfs_emit() OrangeBlack0765
2026-07-14 13:39 ` [PATCH v2] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at() OrangeBlack0765
2026-07-14 13:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714110049.00001c34@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=OrangeBlack0765@outlook.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.