[PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[OrangeBlack0765]

From: Chengrui Liu <OrangeBlack0765@outlook.com>

Replace sprintf() with sysfs_emit() for single-value sysfs show
functions, and use sysfs_emit_at() for lux_table_show() which
concatenates multiple values. This ensures buffer safety and
follows the modern kernel sysfs API.

Signed-off-by: Chengrui Liu <OrangeBlack0765@outlook.com>
---
 drivers/iio/light/tsl2583.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index a0dd122af..9ec2747e5 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -475,7 +475,7 @@ static ssize_t in_illuminance_input_target_show(struct device *dev,
 	int ret;
 
 	mutex_lock(&chip->als_mutex);
-	ret = sprintf(buf, "%d\n", chip->als_settings.als_cal_target);
+	ret = sysfs_emit(buf, "%d\n", chip->als_settings.als_cal_target);
 	mutex_unlock(&chip->als_mutex);
 
 	return ret;
@@ -533,7 +533,7 @@ static ssize_t in_illuminance_lux_table_show(struct device *dev,
 	int offset = 0;
 
 	for (i = 0; i < ARRAY_SIZE(chip->als_settings.als_device_lux); i++) {
-		offset += sprintf(buf + offset, "%u,%u,%u,",
+		offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
 				  chip->als_settings.als_device_lux[i].ratio,
 				  chip->als_settings.als_device_lux[i].ch0,
 				  chip->als_settings.als_device_lux[i].ch1);
@@ -547,7 +547,7 @@ static ssize_t in_illuminance_lux_table_show(struct device *dev,
 		}
 	}
 
-	offset += sprintf(buf + offset, "\n");
+	offset += sysfs_emit_at(buf, offset, "\n");
 
 	return offset;
 }
-- 
2.53.0

Re: [PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[Joshua Crofts]

On Tue, 14 Jul 2026 01:08:33 +0800
OrangeBlack0765@outlook.com wrote:

> From: Chengrui Liu <OrangeBlack0765@outlook.com>
> 
> Replace sprintf() with sysfs_emit() for single-value sysfs show
> functions, and use sysfs_emit_at() for lux_table_show() which
> concatenates multiple values. This ensures buffer safety and
> follows the modern kernel sysfs API.
> 
> Signed-off-by: Chengrui Liu <OrangeBlack0765@outlook.com>
> ---

LGTM.

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards

CJD

Re: [PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[Andy Shevchenko]

On Tue, Jul 14, 2026 at 01:08:33AM +0800, OrangeBlack0765@outlook.com wrote:

> Replace sprintf() with sysfs_emit() for single-value sysfs show
> functions, and use sysfs_emit_at() for lux_table_show() which
> concatenates multiple values. This ensures buffer safety and
> follows the modern kernel sysfs API.

...

>  	for (i = 0; i < ARRAY_SIZE(chip->als_settings.als_device_lux); i++) {
> -		offset += sprintf(buf + offset, "%u,%u,%u,",
> +		offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
>  				  chip->als_settings.als_device_lux[i].ratio,
>  				  chip->als_settings.als_device_lux[i].ch0,
>  				  chip->als_settings.als_device_lux[i].ch1);

Now the indentation becomes broken.

>  	}

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[Joshua Crofts]

On Tue, 14 Jul 2026 11:53:42 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >  	for (i = 0; i < ARRAY_SIZE(chip->als_settings.als_device_lux); i++) {
> > -		offset += sprintf(buf + offset, "%u,%u,%u,",
> > +		offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
> >  				  chip->als_settings.als_device_lux[i].ratio,
> >  				  chip->als_settings.als_device_lux[i].ch0,
> >  				  chip->als_settings.als_device_lux[i].ch1);  
> 
> Now the indentation becomes broken.

I seem to be blind when reviewing.

-- 
Kind regards

CJD

Re: [PATCH] iio: light: tsl2583: migrate to sysfs_emit()

[OrangeBlack0765]

From: OrangeBlack0765 <OrangeBlack0765@outlook.com>

On Tue, Jul 14, 2026 at 11:53:42AM +0300, Andy Shevchenko wrote:
> >  	for (i = 0; i < ARRAY_SIZE(chip->als_settings.als_device_lux); i++) {
> > -		offset += sprintf(buf + offset, "%u,%u,%u,",
> > +		offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
> >  				  chip->als_settings.als_device_lux[i].ratio,
> >  				  chip->als_settings.als_device_lux[i].ch0,
> >  				  chip->als_settings.als_device_lux[i].ch1);
> 
> Now the indentation becomes broken.

Thanks for catching this. I will fix the indentation and send v2 shortly.

[PATCH v2] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[OrangeBlack0765]

From: Chengrui Liu <OrangeBlack0765@outlook.com>

Replace sprintf() with sysfs_emit() for single-value sysfs show
functions, and use sysfs_emit_at() for lux_table_show() which
concatenates multiple values. This ensures buffer safety and
follows the modern kernel sysfs API.

Changes in v2:
- Fix indentation for multi-line function arguments (align with first param)

Signed-off-by: Chengrui Liu <OrangeBlack0765@outlook.com>
---
 drivers/iio/light/tsl2583.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index a0dd122af..db0dc2c3e 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -475,7 +475,7 @@ static ssize_t in_illuminance_input_target_show(struct device *dev,
 	int ret;
 
 	mutex_lock(&chip->als_mutex);
-	ret = sprintf(buf, "%d\n", chip->als_settings.als_cal_target);
+	ret = sysfs_emit(buf, "%d\n", chip->als_settings.als_cal_target);
 	mutex_unlock(&chip->als_mutex);
 
 	return ret;
@@ -533,10 +533,10 @@ static ssize_t in_illuminance_lux_table_show(struct device *dev,
 	int offset = 0;
 
 	for (i = 0; i < ARRAY_SIZE(chip->als_settings.als_device_lux); i++) {
-		offset += sprintf(buf + offset, "%u,%u,%u,",
-				  chip->als_settings.als_device_lux[i].ratio,
-				  chip->als_settings.als_device_lux[i].ch0,
-				  chip->als_settings.als_device_lux[i].ch1);
+		offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
+				  	chip->als_settings.als_device_lux[i].ratio,
+				  	chip->als_settings.als_device_lux[i].ch0,
+				  	chip->als_settings.als_device_lux[i].ch1);
 		if (chip->als_settings.als_device_lux[i].ratio == 0) {
 			/*
 			 * We just printed the first "0" entry.
@@ -547,7 +547,7 @@ static ssize_t in_illuminance_lux_table_show(struct device *dev,
 		}
 	}
 
-	offset += sprintf(buf + offset, "\n");
+	offset += sysfs_emit_at(buf, offset, "\n");
 
 	return offset;
 }
-- 
2.53.0

Re: [PATCH v2] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()

[Andy Shevchenko]

On Tue, Jul 14, 2026 at 09:39:00PM +0800, OrangeBlack0765@outlook.com wrote:

First of all, do not reply with a new version into the thread from
the previous one.

> Replace sprintf() with sysfs_emit() for single-value sysfs show
> functions, and use sysfs_emit_at() for lux_table_show() which
> concatenates multiple values. This ensures buffer safety and
> follows the modern kernel sysfs API.

> Changes in v2:
> - Fix indentation for multi-line function arguments (align with first param)

Next, the changelog should be in the comments block...

> Signed-off-by: Chengrui Liu <OrangeBlack0765@outlook.com>
> ---

...somewhere here (mind the cutter '---' line).

>  drivers/iio/light/tsl2583.c | 12 ++++++------

...

> +		offset += sysfs_emit_at(buf, offset, "%u,%u,%u,",
> +				  	chip->als_settings.als_device_lux[i].ratio,
> +				  	chip->als_settings.als_device_lux[i].ch0,
> +				  	chip->als_settings.als_device_lux[i].ch1);

And last, but not least. Indentation is still broken. Now it's mix tabs
and spaces (in a wrong order).

...

Do not hurry up with v3, wait at least 24+h.

-- 
With Best Regards,
Andy Shevchenko