Re: [PATCH v5 11/20] vfio: Enforce preserved devices are retrieved via LIVEUPDATE_SESSION_RETRIEVE_FD

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function `pci_liveupdate_is_incoming()` is called but is neither declared nor defined anywhere in the kernel tree.
--

--- Patch [11]: [PATCH v5 11/20] vfio: Enforce preserved devices are retrieved via LIVEUPDATE_SESSION_RETRIEVE_FD ---
commit 27d87a41631434a0adb6626f478ee97f35b6c917
Author: David Matlack <dmatlack@google.com>

vfio: Enforce preserved devices are retrieved via LIVEUPDATE_SESSION_RETRIEVE_FD

This commit enforces that incoming VFIO devices preserved by a previous
kernel are retrieved using LIVEUPDATE_SESSION_RETRIEVE_FD. It adds checks
during device open and group device fd retrieval to return -EBUSY if
an attempt is made to bypass the preserved state.

> diff --git a/drivers/vfio/vfio.h b/drivers/vfio/vfio.h
> index e4b72e79b7e3e..496180950eb6d 100644
> --- a/drivers/vfio/vfio.h
> +++ b/drivers/vfio/vfio.h

[ ... ]

> @@ -461,4 +462,21 @@ static inline void vfio_device_debugfs_init(struct vfio_device *vdev) { }
>  static inline void vfio_device_debugfs_exit(struct vfio_device *vdev) { }
>  #endif /* CONFIG_VFIO_DEBUGFS */
>  
> +#ifdef CONFIG_VFIO_PCI_LIVEUPDATE
> +static inline bool vfio_liveupdate_incoming_is_preserved(struct vfio_device *device)
> +{
> +	struct device *d = device->dev;
> +
> +	if (dev_is_pci(d))
> +		return pci_liveupdate_is_incoming(to_pci_dev(d));

[Severity: Low]
Does this code compile successfully when CONFIG_VFIO_PCI_LIVEUPDATE is enabled?
It appears that pci_liveupdate_is_incoming is neither declared nor defined
anywhere in the kernel tree.

Could a prerequisite patch adding this functionality to the PCI subsystem
have been left out of this series?

> +
> +	return false;
> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714151505.3466855-1-vipinsh@google.com?part=11